-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix snapshot repository registration failure in mixed OpenSearch version setups #16831
base: main
Are you sure you want to change the base?
Conversation
❌ Gradle check result for 2c427aa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…ation Signed-off-by: Ashish Singh <ssashish@amazon.com>
2c427aa
to
51a6e67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's difficult to add unit tests as the BlobStoreRepositoryTest.java is actually a single node spin up and testing. There are existing integration tests that invokes this flow. The code is partially tested in the ITs that spins up the remote store nodes.
❌ Gradle check result for 51a6e67: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test - #15831 |
❌ Gradle check result for 51a6e67: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 51a6e67: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test - #16015 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16831 +/- ##
============================================
+ Coverage 72.11% 72.15% +0.04%
- Complexity 65237 65271 +34
============================================
Files 5318 5318
Lines 304003 304015 +12
Branches 43992 43995 +3
============================================
+ Hits 219228 219377 +149
+ Misses 66874 66649 -225
- Partials 17901 17989 +88 ☔ View full report in Codecov by Sentry. |
Description
This PR addresses issue #16830, where snapshot repository registration fails in clusters with mixed OpenSearch versions, specifically when nodes running OS 2.17 are present alongside nodes running earlier 1.x or 2.x versions.
Problem:
Solution:
Changes:
Testing:
This fix ensures smooth operation of snapshot repositories during cluster upgrades and in environments where different OpenSearch versions coexist.
Related Issues
Resolves #16830
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.