Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LegacyESVersion.V_6_2_x constants #1686

Merged
merged 8 commits into from
Dec 9, 2021
Merged

Remove LegacyESVersion.V_6_2_x constants #1686

merged 8 commits into from
Dec 9, 2021

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Dec 9, 2021

This PR removes LegacyESVersion.V_6_2_x constants including all
pre-release versions and bug fixes.

closes #1680

@nknize
Remove LegacyESVersion.V_6_2_x constants
a1c7672 
This commit removes LegacyESVersion.V_6_2_x constants including all
pre-release versions and bug fixes.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize added v2.0.0 Version 2.0.0 non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues labels Dec 9, 2021
@nknize nknize requested a review from a team as a code owner December 9, 2021 06:00
@nknize
remove LUCENE_7_2_1 constant
9c91c31 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure a1c7672
Log 1399

Reports 1399

@nknize
fix typo
d210ef6 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure d210ef6
Log 1400

Reports 1400

@adnapibar
Copy link
Contributor

Formatting error - run spotlessApply?

@nknize
spotless
8a20293 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize
Copy link
Collaborator Author

nknize commented Dec 9, 2021

le ugh.. never forget to run precommit locally. :)

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 8a20293
Log 1401

Reports 1401

@nknize
fix failing tests
ddae89e 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure ddae89e
Log 1409

Reports 1409

@nknize
remove unused import
ff997a6 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure ff997a6
Log 1410

Reports 1410

@nknize
fix SyncedFlushService
e1c5ea3 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize mentioned this pull request Dec 9, 2021
Closed
19 tasks
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure e1c5ea3
Log 1411

Reports 1411

@nknize
fix GeoTileVS serialization
e6f5809 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success e6f5809
Log 1412

Reports 1412

adnapibar
adnapibar approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@adnapibar adnapibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nknize nknize merged commit 538b40a into opensearch-project:main Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnapibar adnapibar adnapibar approved these changes

Assignees
No one assigned
Labels
non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove LegacyESVersion.V_6_2_x constants
3 participants
@nknize @opensearch-ci-bot @adnapibar