-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to log4j 2.15.0 #1698
Upgrade to log4j 2.15.0 #1698
Conversation
Can one of the admins verify this patch? |
@andrross you should be able to add I believe other plugins will also fail. The same fix should take care of it. |
1caf63e
to
044fb86
Compare
❌ Gradle Check failure 8812f3cbb48fd49981b5a41e67f4909b0501c014 |
044fb86
to
36979af
Compare
❌ Gradle Check failure 1caf63ec4daa6cb5536ca63c383afc6df94e3a75 |
❌ Gradle Check failure 044fb86cb2b85b0b551a384b42e686e2f33a84da |
❌ Gradle Check failure 36979afcf0e0c03e7df45c43fd59fd75534ab52f |
Test failure that succeeds on retry:
Will start another gradle check |
start gradle check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming it can be green
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gce build.gradle thirdPartyAudit looks correct to me. Interesting that was updated even on old 2.11 versions. If gradle check doesn't succeed it'll either be from a missing class or some unrelated PR.
❌ Gradle Check failure 36979afcf0e0c03e7df45c43fd59fd75534ab52f |
Another test failure that succeeds on retry:
|
start gradle check |
❌ Gradle Check failure 36979afcf0e0c03e7df45c43fd59fd75534ab52f |
Signed-off-by: Andrew Ross <andrross@amazon.com>
36979af
to
79e49d2
Compare
Another test failure that succeeds on retry:
|
start gradle check |
Not the first time HAProxy has failed. This is unrelated to the PR but I'm not sure it's a "flake". Wondering if this is a CI config issue. /cc @peternied @peterzhuamazon It's tiresome chasing these red herring failures.
Capturing here for posterity (will open and move to separate issue):
RemoteConnectionInfo logging is useless. (todo: add |
|
Just checked in, I don't see any blips in the system. Looking forward to the day when everyone can see it on demand. |
This commit upgrades to log4j version 2.15.0.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.