Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Semaphore with ReleasableLock in Engine and Translog related classes #17304

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Replace Semaphore with ReleasableLock in Engine and Translog related classes #17304

wants to merge 4 commits into from
+19 −18

Conversation

ahnyujin
Copy link

@ahnyujin ahnyujin commented Feb 8, 2025

Description

This refactor replaces the use of Semaphore with ReleasableLock for better consistency across the codebase. By aligning with the existing locking mechanisms, this change improves readability and ensures uniform lock acquisition and release patterns.

Changes

  • Replaced Semaphore with ReleasableLock in RemoteFsTranslog.
  • Ensured that lock handling follows the established project conventions.
  • Improved code maintainability by using a more structured locking approach.

Related Issues

Resolves #11360

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers Storage:Durability Issues and PRs related to the durability framework labels Feb 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2025

❌ Gradle check result for 93c1fbc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Feb 8, 2025
Open
Closed
@ahnyujin ahnyujin force-pushed the use-releasableLock branch 2 times, most recently from a70f320 to fb61223 Compare February 9, 2025 14:31
@ahnyujin
Replace Semaphore with ReleasableLock for consistency
8cf56b4 
Signed-off-by: Yujin Ahn <ujahnn@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025

❌ Gradle check result for 8cf56b4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

dbwiddis
dbwiddis reviewed Feb 9, 2025
View reviewed changes
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Generally. A few comments/questions.

@ahnyujin
Add assertion for lock held when draining sync
da1aff1 
Signed-off-by: Yujin Ahn <ujahnn@gmail.com>
@ahnyujin
Implement translog isLockAvailable
6516873 
Signed-off-by: Yujin Ahn <ujahnn@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 6516873: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Feb 10, 2025
Open
Open
Open
Open
Open
Open
Open
Open
@ahnyujin
Update is not possible during drainSync
f82640b 
Signed-off-by: Yujin Ahn <ujahnn@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for f82640b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis left review comments

@Bukhtawar Bukhtawar Bukhtawar left review comments

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers Storage:Durability Issues and PRs related to the durability framework
Projects
Storage Project Board
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use ReleasableLock within Engine and Translog related classes
3 participants
@ahnyujin @dbwiddis @Bukhtawar