Allow plugins to access/override some functions of ParametrizedFieldMapper; Modify the the constructor of the MappedFieldType to support FilterFieldType. #17575
Conversation
bzhangam
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
jed326,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
server/src/main/java/org/opensearch/index/mapper/TermBasedFieldType.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for 1cc9d6b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17575 +/- ##
============================================
- Coverage 72.44% 72.37% -0.08%
- Complexity 66483 66676 +193
============================================
Files 5409 5449 +40
Lines 308282 309080 +798
Branches 44759 44982 +223
============================================
+ Hits 223344 223699 +355
- Misses 66608 66973 +365
- Partials 18330 18408 +78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…apper; Modify the the constructor of the MappedFieldType to support FilterFieldType. Signed-off-by: Bo Zhang <bzhangam@amazon.com>
bzhangam
changed the title
|
❌ Gradle check result for ed5264d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
msfroh
left a comment
msfroh
left a comment
There was a problem hiding this comment.
I believe these changes make sense. Obviously, making stuff public / non-final is not ideal, but the scope seems limited enough.
|
❌ Gradle check result for ed5264d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for ed5264d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for ed5264d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for ed5264d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…apper; Modify the the constructor of the MappedFieldType to support FilterFieldType. (opensearch-project#17575) Signed-off-by: Bo Zhang <bzhangam@amazon.com> Signed-off-by: Sriram Ganesh <srignsh22@gmail.com>
…apper; Modify the the constructor of the MappedFieldType to support FilterFieldType. (opensearch-project#17575) Signed-off-by: Bo Zhang <bzhangam@amazon.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
…apper; Modify the the constructor of the MappedFieldType to support FilterFieldType. (opensearch-project#17575) Signed-off-by: Bo Zhang <bzhangam@amazon.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
3 participants
Description
Allow plugins to access/override some functions of ParametrizedFieldMapper;
Modify the the constructor of the MappedFieldType to support FilterFieldType.
Related Issues
This is needed to support this PR for this feature.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.