Skip to content

Conversation

@reta
Copy link
Contributor

@reta reta commented Apr 1, 2025

Description

Enhance Java Agent to intercept Runtime::halt calls

Related Issues

Closes #17755

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request security Anything security related labels Apr 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

✅ Gradle check result for b0a901f: SUCCESS

@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 46 lines in your changes missing coverage. Please review.

Project coverage is 72.33%. Comparing base (8312e42) to head (69abd27).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...rg/opensearch/javaagent/bootstrap/AgentPolicy.java 0.00% 20 Missing ⚠️
...g/opensearch/javaagent/RuntimeHaltInterceptor.java 0.00% 10 Missing ⚠️
.../src/main/java/org/opensearch/javaagent/Agent.java 0.00% 6 Missing ⚠️
...rg/opensearch/javaagent/SystemExitInterceptor.java 0.00% 5 Missing ⚠️
...arch/javaagent/StackCallerClassChainExtractor.java 0.00% 3 Missing ⚠️
...opensearch/javaagent/SocketChannelInterceptor.java 0.00% 1 Missing ⚠️
...ent/StackCallerProtectionDomainChainExtractor.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17757      +/-   ##
============================================
- Coverage     72.51%   72.33%   -0.18%     
+ Complexity    66142    65992     -150     
============================================
  Files          5356     5358       +2     
  Lines        306421   306460      +39     
  Branches      44393    44400       +7     
============================================
- Hits         222192   221670     -522     
- Misses        66024    66611     +587     
+ Partials      18205    18179      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

❌ Gradle check result for 4f49099: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Member

@cwperks cwperks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @reta. Left a few comments.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

❌ Gradle check result for 2db4d8c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Member

@cwperks cwperks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one comment above test coverage for AnyCanExit.apply.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

❕ Gradle check result for 2db4d8c: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

reta added 2 commits April 2, 2025 21:51
Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

✅ Gradle check result for 80c8ecf: SUCCESS

Signed-off-by: Andriy Redko <drreta@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

❕ Gradle check result for 69abd27: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request security Anything security related skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Enhance Java Agent to intercept Runtime::halt

3 participants