-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Enhance Java Agent to intercept Runtime::halt #17757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17757 +/- ##
============================================
- Coverage 72.51% 72.33% -0.18%
+ Complexity 66142 65992 -150
============================================
Files 5356 5358 +2
Lines 306421 306460 +39
Branches 44393 44400 +7
============================================
- Hits 222192 221670 -522
- Misses 66024 66611 +587
+ Partials 18205 18179 -26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
libs/agent-sm/bootstrap/src/main/java/org/opensearch/javaagent/bootstrap/AgentPolicy.java
Outdated
Show resolved
Hide resolved
libs/agent-sm/bootstrap/src/main/java/org/opensearch/javaagent/bootstrap/AgentPolicy.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for 4f49099: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
cwperks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @reta. Left a few comments.
libs/agent-sm/agent/src/main/java/org/opensearch/javaagent/RuntimeHaltInterceptor.java
Outdated
Show resolved
Hide resolved
libs/agent-sm/bootstrap/src/main/java/org/opensearch/javaagent/bootstrap/AgentPolicy.java
Outdated
Show resolved
Hide resolved
libs/agent-sm/bootstrap/src/main/java/org/opensearch/javaagent/bootstrap/AgentPolicy.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for 2db4d8c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
cwperks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left one comment above test coverage for AnyCanExit.apply.
libs/agent-sm/agent/src/test/java/org/opensearch/javaagent/AgentTests.java
Show resolved
Hide resolved
|
❕ Gradle check result for 2db4d8c: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
libs/agent-sm/agent/src/main/java/org/opensearch/javaagent/StackCallerClassChainExtractor.java
Outdated
Show resolved
Hide resolved
libs/agent-sm/bootstrap/src/main/java/org/opensearch/javaagent/bootstrap/AgentPolicy.java
Show resolved
Hide resolved
Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
|
❕ Gradle check result for 69abd27: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Description
Enhance Java Agent to intercept
Runtime::haltcallsRelated Issues
Closes #17755
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.