Create thread id to SourceLookup map #17927
Merged
+34
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jed326
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
cwperks,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Contributor
|
❌ Gradle check result for 501d8f9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❌ Gradle check result for eea1ced: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❌ Gradle check result for 9248b29: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
jed326
changed the title
Contributor
|
❌ Gradle check result for c0f5565: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Author
|
Gradle check failing on this: |
Contributor
Author
|
I'm a little confused on this one as the mockito version we're on (5.16) is supposed to be able to mock final classes. Will go with an alternative approach for now while I look into that. |
Signed-off-by: Jay Deng <jayd0104@gmail.com>
Contributor
|
❕ Gradle check result for 42ae9a0: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
This was referenced Apr 26, 2025
sohami
approved these changes
Apr 28, 2025
msfroh
approved these changes
Apr 28, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 28, 2025
Signed-off-by: Jay Deng <jayd0104@gmail.com> (cherry picked from commit a06cf2c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
pushed a commit
that referenced
this pull request
Apr 28, 2025
(cherry picked from commit a06cf2c) Signed-off-by: Jay Deng <jayd0104@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
prudhvigodithi
pushed a commit
to prudhvigodithi/OpenSearch
that referenced
this pull request
May 6, 2025
…pensearch-project#18107) (cherry picked from commit a06cf2c) Signed-off-by: Jay Deng <jayd0104@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
qianheng-aws
added a commit
to opensearch-project/sql
that referenced
this pull request
Aug 20, 2025
…#17927 in core 2.19 Signed-off-by: Heng Qian <qianheng@amazon.com>
LantaoJin
pushed a commit
to opensearch-project/sql
that referenced
this pull request
Aug 21, 2025
* Support script push down on text field (#4010) * Support script push down on text field Signed-off-by: Heng Qian <qianheng@amazon.com> * Fix IT Signed-off-by: Heng Qian <qianheng@amazon.com> * Add UT for struct type push down Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com> (cherry picked from commit bb1a644) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix CI failure because of plan having changed (#4077) Signed-off-by: Heng Qian <qianheng@amazon.com> (cherry picked from commit acc055e) * set segment and document as missing PR: opensearch-project/OpenSearch#17927 in core 2.19 Signed-off-by: Heng Qian <qianheng@amazon.com> * Fix IT Signed-off-by: Heng Qian <qianheng@amazon.com> * fix compiling Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: qianheng <qianheng@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes changes to retrieve SourceLookup based on the current thread id. See #17743 (comment) for more details.
Testing
This PR includes new test coverage on the cache case, as well as the existing scripting tests passing.
More broadly we need to invest in better perf testing related to scripting: opensearch-project/opensearch-benchmark-workloads#362
Related Issues
Relates #17743
Check List
- [ ] API changes companion pull request created, if applicable.- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.