Resolve compile error in DefaultStreamPoller #18005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
gaobinlong
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
cwperks,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Contributor
Author
|
@yupeng9 @varunbharadwaj please help to review, thanks! |
Contributor
|
❕ Gradle check result for 655f5a7: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18005 +/- ##
============================================
+ Coverage 72.51% 72.55% +0.04%
- Complexity 67108 67132 +24
============================================
Files 5475 5478 +3
Lines 309916 310034 +118
Branches 45060 45066 +6
============================================
+ Hits 224725 224937 +212
+ Misses 66895 66798 -97
- Partials 18296 18299 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cwperks
approved these changes
Apr 18, 2025
varunbharadwaj
approved these changes
Apr 18, 2025
Contributor
|
Thanks for the fix. LGTM. |
andrross
approved these changes
Apr 18, 2025
This was referenced Apr 18, 2025
andrross
pushed a commit
that referenced
this pull request
Apr 22, 2025
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
andrross
pushed a commit
that referenced
this pull request
Apr 22, 2025
Signed-off-by: Binlong Gao <gbinlong@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross
pushed a commit
that referenced
this pull request
Apr 23, 2025
…config to poller (#18036) * pass the maxPoll, timeout from config to poller (#17995) (cherry picked from commit cf6ed3c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Resolve compile error (#18005) Signed-off-by: Binlong Gao <gbinlong@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com> --------- Signed-off-by: Binlong Gao <gbinlong@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: gaobinlong <gbinlong@amazon.com>
x-INFiN1TY-x
pushed a commit
to x-INFiN1TY-x/OpenSearch_Local
that referenced
this pull request
Apr 24, 2025
Signed-off-by: Binlong Gao <gbinlong@amazon.com> Signed-off-by: Tanishq Ranjan <tqranjan@amazon.com>
prudhvigodithi
pushed a commit
to prudhvigodithi/OpenSearch
that referenced
this pull request
May 6, 2025
…config to poller (opensearch-project#18036) * pass the maxPoll, timeout from config to poller (opensearch-project#17995) (cherry picked from commit cf6ed3c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Resolve compile error (opensearch-project#18005) Signed-off-by: Binlong Gao <gbinlong@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com> --------- Signed-off-by: Binlong Gao <gbinlong@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
Signed-off-by: Binlong Gao <gbinlong@amazon.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
Signed-off-by: Binlong Gao <gbinlong@amazon.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a compile error due to the both change in the DefaultStreamPoller class in the latest 2 PRs https://github.com/opensearch-project/OpenSearch/pull/17995/files#diff-f8b0b74e29348e27ce7f607a570e6fe30656f008a5296f637597aad55edbb293R218 and https://github.com/opensearch-project/OpenSearch/pull/17995/files#diff-f8b0b74e29348e27ce7f607a570e6fe30656f008a5296f637597aad55edbb293R218, need to replace the two parameters with the local variables.
Related Issues
No issue.
Check List
- [ ] Functionality includes testing.
- [ ] API changes companion pull request created, if applicable.
- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.