-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix flaky multimatchquerybuildertests #18013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky multimatchquerybuildertests #18013
Conversation
|
❌ Gradle check result for 1c80555: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@harshavamsi Can you rebase this with the latest from main? |
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
1c80555 to
d7472e8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18013 +/- ##
============================================
+ Coverage 72.59% 72.61% +0.02%
+ Complexity 67172 67151 -21
============================================
Files 5478 5478
Lines 310125 310125
Branches 45080 45080
============================================
+ Hits 225135 225204 +69
+ Misses 66676 66535 -141
- Partials 18314 18386 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> (cherry picked from commit 17eeaa2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 17eeaa2) Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Signed-off-by: Tanishq Ranjan <tqranjan@amazon.com>
…nsearch-project#18035) (cherry picked from commit 17eeaa2) Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Description
Just adds a new instance type for new Query type. Ran this for 1500+ iterations with no failures
Related Issues
Resolves #17934
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.