Remove LegacyESVersion.V_6_6_x constants #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
andrross
approved these changes
Dec 23, 2021
reta
reviewed
Dec 23, 2021
| AbstractShapeGeometryFieldMapper<?, ?> shapeMapper = (context.indexCreatedVersion().before(LegacyESVersion.V_6_6_0)) | ||
| ? legacyShapeBuilder.build(context) | ||
| : shapeBuilder.build(context); | ||
| AbstractShapeGeometryFieldMapper<?, ?> shapeMapper = shapeBuilder.build(context); |
There was a problem hiding this comment.
I think you could completely drop legacyShapeBuilder from this class
adnapibar
added
non-issue
|
✅ Gradle Check success 92b6c6b517dc44a2779406a23c0417582f029f6d |
19 tasks
This commit removes all usages of the `LegacyESVersion.V_6_6_x` constants from the codebase. Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
LegacyESVersion.V_6_6_xconstants and all their usages.Issues Resolved
Part of #1674
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Rabi Panda adnapibar@gmail.com