Skip to content

Conversation

@kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Apr 28, 2025

Description

When I put the PR #18069 with the newest main branch, the ci throws the exception, as shown in this link: TransportMultiSearchActionTests.testCancellation:
https://build.ci.opensearch.org/job/gradle-check/57253/

Here are two scenarios regarding this issue:

  1. If the unit test executes too quickly, the async search might not get a chance to execute, so the unit test seems doesn't work.
  2. On the other hand, if the unit test does not execute quickly, it may trigger the exception, which is the case I encountered.
    https://github.com/opensearch-project/OpenSearch/blob/main/server/src/test/java/org/opensearch/action/search/TransportMultiSearchActionTests.java#L402

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kkewwei
Copy link
Contributor Author

kkewwei commented Apr 28, 2025

@msfroh Please have a look in your spare time, I saw you have also fixed the flaky TransportMultiSearchActionTests.testCancellation in #17193

@github-actions
Copy link
Contributor

❌ Gradle check result for 7084c40: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for 7084c40: SUCCESS

@codecov
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.41%. Comparing base (a6724d3) to head (3839317).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18099      +/-   ##
============================================
- Coverage     72.53%   72.41%   -0.13%     
+ Complexity    67207    67121      -86     
============================================
  Files          5476     5476              
  Lines        310436   310436              
  Branches      45121    45121              
============================================
- Hits         225179   224803     -376     
- Misses        66894    67319     +425     
+ Partials      18363    18314      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

❌ Gradle check result for 589df35: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 589df35: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kotwanikunal
Copy link
Member

@kkewwei Mind rebasing your PR? We have muted a few flaky more tests with #18142

kkewwei and others added 2 commits April 29, 2025 09:04
Signed-off-by: kkewwei <kewei.11@bytedance.com>
Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
@andrross
Copy link
Member

@kotwanikunal I just pushed a rebase commit

@github-actions
Copy link
Contributor

❕ Gradle check result for 3839317: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@kotwanikunal kotwanikunal merged commit 0795bb2 into opensearch-project:main Apr 29, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants