-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix flaky TransportMultiSearchActionTests.testCancellation #18099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
❌ Gradle check result for 7084c40: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/test/java/org/opensearch/action/search/TransportMultiSearchActionTests.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18099 +/- ##
============================================
- Coverage 72.53% 72.41% -0.13%
+ Complexity 67207 67121 -86
============================================
Files 5476 5476
Lines 310436 310436
Branches 45121 45121
============================================
- Hits 225179 224803 -376
- Misses 66894 67319 +425
+ Partials 18363 18314 -49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
❌ Gradle check result for 589df35: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 589df35: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com>
|
@kotwanikunal I just pushed a rebase commit |
|
❕ Gradle check result for 3839317: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Description
When I put the PR #18069 with the newest
mainbranch, thecithrows the exception, as shown in this link: TransportMultiSearchActionTests.testCancellation:https://build.ci.opensearch.org/job/gradle-check/57253/
Here are two scenarios regarding this issue:
https://github.com/opensearch-project/OpenSearch/blob/main/server/src/test/java/org/opensearch/action/search/TransportMultiSearchActionTests.java#L402
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.