[rule based autotagging] Add Delete Rule API Logic #18184

Lindsay-00 · 2025-05-02T09:13:10Z

Description

This PR introduces the Delete Rule API Logic.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

github-actions · 2025-05-02T09:26:39Z

❌ Gradle check result for 5129a79: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

modules/autotagging-commons/common/src/main/java/org/opensearch/rule/DeleteRuleRequest.java

modules/autotagging-commons/common/src/main/java/org/opensearch/rule/DeleteRuleResponse.java

.../autotagging-commons/src/main/java/org/opensearch/rule/action/TransportDeleteRuleAction.java

modules/autotagging-commons/src/main/java/org/opensearch/rule/rest/RestDeleteRuleAction.java

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

github-actions · 2025-05-05T23:59:06Z

❌ Gradle check result for c6a1825: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

...otagging-commons/common/src/test/java/org/opensearch/rule/action/DeleteRuleRequestTests.java

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

github-actions · 2025-05-06T07:15:07Z

❌ Gradle check result for f37990f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

ruai0511

LGTM!

modules/autotagging-commons/common/src/main/java/org/opensearch/rule/DeleteRuleRequest.java

modules/autotagging-commons/src/main/java/org/opensearch/rule/rest/RestDeleteRuleAction.java

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

...es/autotagging-commons/src/main/java/org/opensearch/rule/RulePersistenceServiceRegistry.java

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

github-actions · 2025-05-06T22:19:47Z

❌ Gradle check result for 1669731: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

modules/autotagging-commons/common/src/main/java/org/opensearch/rule/DeleteRuleRequest.java

...mons/common/src/main/java/org/opensearch/rule/service/IndexStoredRulePersistenceService.java

.../autotagging-commons/src/main/java/org/opensearch/rule/action/TransportDeleteRuleAction.java

Lindsay-00 · 2025-05-07T22:00:39Z

@jainankitk For Feature Type we're keeping it to get the RulePersistenceService from the Registry class

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

github-actions · 2025-05-07T22:24:25Z

❌ Gradle check result for 5e38cb0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

jainankitk · 2025-05-08T00:05:15Z

@Lindsay-00 - Can you resolve the failing precommit and other checks?

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

github-actions · 2025-05-08T21:32:55Z

❌ Gradle check result for 0d33419: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

jainankitk · 2025-05-08T23:08:34Z

@Lindsay-00 - Precommit is still failing. Maybe you can try running it locally to verify? Also, can you add changelog entry?

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

github-actions · 2025-05-12T21:19:21Z

❌ Gradle check result for 2120016: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

jainankitk · 2025-05-13T00:40:04Z

@Lindsay-00 - Failures look related, can you check:

[Test Result](https://build.ci.opensearch.org/job/gradle-check/57992/testReport/) (2 failures / +2)

    [org.opensearch.rule.service.IndexStoredRulePersistenceServiceTests.testDeleteRule_notFound](https://build.ci.opensearch.org/job/gradle-check/57992/testReport/junit/org.opensearch.rule.service/IndexStoredRulePersistenceServiceTests/testDeleteRule_notFound/)
    [org.opensearch.rule.service.IndexStoredRulePersistenceServiceTests.testDeleteRule_successful](https://build.ci.opensearch.org/job/gradle-check/57992/testReport/junit/org.opensearch.rule.service/IndexStoredRulePersistenceServiceTests/testDeleteRule_successful/)

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

github-actions · 2025-05-13T01:24:10Z

❌ Gradle check result for f1f0783: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Lindsay-00 · 2025-05-13T01:27:07Z

@Lindsay-00 - Failures look related, can you check:

[Test Result](https://build.ci.opensearch.org/job/gradle-check/57992/testReport/) (2 failures / +2)

    [org.opensearch.rule.service.IndexStoredRulePersistenceServiceTests.testDeleteRule_notFound](https://build.ci.opensearch.org/job/gradle-check/57992/testReport/junit/org.opensearch.rule.service/IndexStoredRulePersistenceServiceTests/testDeleteRule_notFound/)
    [org.opensearch.rule.service.IndexStoredRulePersistenceServiceTests.testDeleteRule_successful](https://build.ci.opensearch.org/job/gradle-check/57992/testReport/junit/org.opensearch.rule.service/IndexStoredRulePersistenceServiceTests/testDeleteRule_successful/)

Thanks for pointing it out! Just fixed them.

github-actions · 2025-05-13T21:22:37Z

❌ Gradle check result for f1f0783: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-05-13T23:30:59Z

❌ Gradle check result for 7f90f40: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-05-13T23:59:31Z

❌ Gradle check result for 7f90f40: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-05-14T05:21:05Z

❌ Gradle check result for 7f90f40: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-05-14T16:49:10Z

❌ Gradle check result for 7f90f40: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

jainankitk · 2025-05-16T21:06:26Z

@Lindsay-00 - Can you check the build log for issues? - https://build.ci.opensearch.org/job/gradle-check/58062/console. cc: @kaushalmahi12

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

…penSearch into delete-rule-api-pr-v2

github-actions · 2025-05-19T18:28:06Z

❌ Gradle check result for 1ea4330: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

github-actions · 2025-05-19T19:46:17Z

❕ Gradle check result for cddf074: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2025-05-19T19:46:39Z

Codecov Report

Attention: Patch coverage is 72.72727% with 15 lines in your changes missing coverage. Please review.

Project coverage is 72.52%. Comparing base (998ae73) to head (cddf074).
Report is 22 commits behind head on main.

Files with missing lines	Patch %	Lines
...org/opensearch/rule/rest/RestDeleteRuleAction.java	30.00%	7 Missing ⚠️
...ule/service/IndexStoredRulePersistenceService.java	60.00%	3 Missing and 3 partials ⚠️
...in/java/org/opensearch/rule/DeleteRuleRequest.java	89.47%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #18184      +/-   ##
============================================
+ Coverage     72.48%   72.52%   +0.03%     
- Complexity    67357    67385      +28     
============================================
  Files          5488     5492       +4     
  Lines        311023   311076      +53     
  Branches      45217    45218       +1     
============================================
+ Hits         225444   225606     +162     
+ Misses        67282    67063     -219     
- Partials      18297    18407     +110

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…t#18184) Signed-off-by: Lingxi Chen <lingxich@amazon.com> Co-authored-by: Lingxi Chen <lingxich@amazon.com>

…t#18184) Signed-off-by: Lingxi Chen <lingxich@amazon.com> Co-authored-by: Lingxi Chen <lingxich@amazon.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>

…t#18184) Signed-off-by: Lingxi Chen <lingxich@amazon.com> Co-authored-by: Lingxi Chen <lingxich@amazon.com>

Lingxi Chen added 2 commits May 1, 2025 16:48

delete rule feature

e39446a

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

unit tests

5129a79

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

Lindsay-00 requested a review from a team as a code owner May 2, 2025 09:13

ruai0511 reviewed May 5, 2025

View reviewed changes

revised based on comments

c6a1825

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

ruai0511 reviewed May 6, 2025

View reviewed changes

...otagging-commons/common/src/test/java/org/opensearch/rule/action/DeleteRuleRequestTests.java Outdated Show resolved Hide resolved

revised based on comments

f37990f

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

ruai0511 approved these changes May 6, 2025

View reviewed changes

kaushalmahi12 reviewed May 6, 2025

View reviewed changes

modules/autotagging-commons/common/src/main/java/org/opensearch/rule/DeleteRuleRequest.java Show resolved Hide resolved

modules/autotagging-commons/src/main/java/org/opensearch/rule/rest/RestDeleteRuleAction.java Show resolved Hide resolved

revised based on comments

c6d6515

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

kaushalmahi12 reviewed May 6, 2025

View reviewed changes

...es/autotagging-commons/src/main/java/org/opensearch/rule/RulePersistenceServiceRegistry.java Outdated Show resolved Hide resolved

Revert to commit f37990f

1669731

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

kaushalmahi12 approved these changes May 6, 2025

View reviewed changes

jainankitk reviewed May 7, 2025

View reviewed changes

fixing comments

5e38cb0

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

jainankitk approved these changes May 7, 2025

View reviewed changes

fixing precommit error

0d33419

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

Lingxi Chen added 2 commits May 12, 2025 13:47

fixed precommit error in IndexStoredRulePersistenceServiceTests

170d776

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

changed changelog

2120016

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

fixing jenkins tests

f1f0783

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

Merge branch 'opensearch-project:main' into delete-rule-api-pr-v2

7f90f40

opensearch-ci-bot mentioned this pull request May 14, 2025

[AUTOCUT] Gradle Check Flaky Test Report for IndexServiceTests #14407

Open

Lingxi Chen added 2 commits May 19, 2025 11:11

fix gradle check error

6f23de0

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

Merge branch 'delete-rule-api-pr-v2' of https://github.com/ruai0511/O…

1ea4330

…penSearch into delete-rule-api-pr-v2

fix assertion error

cddf074

Signed-off-by: Lingxi Chen <lingxich@amazon.com>

This was referenced May 20, 2025

[AUTOCUT] Gradle Check Flaky Test Report for S3BlobStoreRepositoryTests #14299

Open

[AUTOCUT] Gradle Check Flaky Test Report for ClientYamlTestSuiteIT #14319

Open

jainankitk merged commit 54af445 into opensearch-project:main May 20, 2025
30 checks passed

tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Jun 1, 2025

[rule based autotagging] Add Delete Rule API Logic (opensearch-projec…

b5d5992

…t#18184) Signed-off-by: Lingxi Chen <lingxich@amazon.com> Co-authored-by: Lingxi Chen <lingxich@amazon.com>

BrewTestBot mentioned this pull request Jun 24, 2025

opensearch 3.1.0 Homebrew/homebrew-core#228059

Merged

ruai0511 deleted the delete-rule-api-pr-v2 branch July 9, 2025 23:27

[rule based autotagging] Add Delete Rule API Logic #18184

[rule based autotagging] Add Delete Rule API Logic #18184

Uh oh!

Conversation

Lindsay-00 commented May 2, 2025

Description

Related Issues

Check List

Uh oh!

github-actions bot commented May 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 5, 2025

Uh oh!

Uh oh!

github-actions bot commented May 6, 2025

Uh oh!

ruai0511 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lindsay-00 commented May 7, 2025

Uh oh!

github-actions bot commented May 7, 2025

Uh oh!

jainankitk commented May 8, 2025

Uh oh!

github-actions bot commented May 8, 2025

Uh oh!

jainankitk commented May 8, 2025

Uh oh!

github-actions bot commented May 12, 2025

Uh oh!

jainankitk commented May 13, 2025

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

Lindsay-00 commented May 13, 2025

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

github-actions bot commented May 14, 2025

Uh oh!

github-actions bot commented May 14, 2025

Uh oh!

jainankitk commented May 16, 2025

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

codecov bot commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented May 19, 2025 •

edited

Loading