Enhance terms lookup query to take a query clause #18195

srikanthpadakanti · 2025-05-05T01:42:30Z

Description

Enhances the Terms lookup query to accept a query clause instead of only supporting a single docId. This expands functionality by enabling users to define document matches through flexible query logic rather than relying solely on fixed document IDs.

This change includes:

Support for Terms lookup query to use a query clause.
Validation logic to prevent using both id and query simultaneously.
Associated unit test updates to cover query-based lookup behavior.

Related Issues

Resolves #17599

Check List

[ X] Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2025-05-05T01:49:53Z

❌ Gradle check result for 085edf2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

server/src/main/java/org/opensearch/indices/TermsLookup.java

server/src/main/java/org/opensearch/index/query/TermsQueryBuilder.java

server/src/main/java/org/opensearch/indices/TermsLookup.java

github-actions · 2025-05-09T20:11:07Z

❌ Gradle check result for edfa605: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-05-14T17:27:39Z

❌ Gradle check result for f7146ff: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-05-14T22:27:29Z

❌ Gradle check result for 90f90c7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-05-14T23:53:33Z

❌ Gradle check result for 997ddbe: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-05-15T01:03:56Z

❌ Gradle check result for 9c85868: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-05-15T18:23:35Z

❌ Gradle check result for 6f52602: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…use rather than docId Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

…checks and updated unit tests Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

github-actions · 2025-05-15T19:29:41Z

❌ Gradle check result for 6ab5410: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

github-actions · 2025-05-15T20:04:46Z

❌ Gradle check result for 101c8ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

srikanthpadakanti · 2025-07-31T04:51:29Z

Hello @andrross @msfroh I have addressed all the PR comments and made the necessary modifications and pushed my changes.

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

github-actions · 2025-07-31T06:38:06Z

❌ Gradle check result for 87ec917: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-07-31T17:14:53Z

❌ Gradle check result for 2774f72: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-07-31T19:16:07Z

❌ Gradle check result for 2774f72: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

server/src/main/java/org/opensearch/index/query/TermsQueryBuilder.java

github-actions · 2025-07-31T22:06:17Z

✅ Gradle check result for 2774f72: SUCCESS

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

github-actions · 2025-08-01T01:37:22Z

❕ Gradle check result for ae9d422: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

…#18195) Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com> Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com> Co-authored-by: Srikanth Padakanti <srikanth_padakanti@apple.com> Signed-off-by: sunqijun.jun <sunqijun.jun@bytedance.com>

…#18195) Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com> Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com> Co-authored-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

kotwanikunal reviewed May 8, 2025

View reviewed changes

github-actions bot added enhancement Enhancement or improvement to existing feature or request Search:Query Capabilities labels May 15, 2025

srikanthpadakanti force-pushed the FeatureRequest17599 branch from da0ba03 to 964f452 Compare May 15, 2025 18:53

srikanthpadakanti added 14 commits May 15, 2025 13:56

FeatureRequest17599: Enhancing Terms lookup query to take a query cla…

c3533a7

…use rather than docId Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

Checkpoint 2 fixed the index issue when query is null

5d07141

Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

Checkpoint 3 fixed the optional argument id, query handling

25a2bf8

Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

Debugging the parsing issue

da93337

Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

Address the PR comments

cbafd35

Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

Both id and query is working checkpoint

6cc6ab0

Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

Both id and query is working checkpoint

1cd1dd5

Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

Both id and query is working and basic unittests

a95a3b5

Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

Fix: Ensure TermsLookup supports both id and query; added validation …

ba6785a

…checks and updated unit tests Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

Fix: Ensure TermsLookup supports both id and query; added validation …

f560563

…checks and updated unit tests Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

Fix: Ensure TermsLookup supports both id and query; added validation …

741290d

…checks and updated unit tests Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

Fix: Ensure TermsLookup supports both id and query; added validation …

f4af35e

…checks and updated unit tests Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

Add CHANGELOG entry for feature request opensearch-project#17599

8e5330f

Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

Add CHANGELOG entry for feature request opensearch-project#17599

6ab5410

Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

srikanthpadakanti force-pushed the FeatureRequest17599 branch from 964f452 to 6ab5410 Compare May 15, 2025 18:56

Add retry logic to gradle wrapper validation

101c8ad

Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>

opensearch-ci-bot mentioned this pull request May 16, 2025

[AUTOCUT] Gradle Check Flaky Test Report for ClientYamlTestSuiteIT #14319

Open

Address the PR comments and add unittests to the new changes

6afb0f7

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

Srikanth Padakanti added 2 commits July 31, 2025 00:21

Address the PR comments and add unittests to the new changes

d39a2f9

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

Address the PR comments and add unittests to the new changes

87ec917

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

opensearch-ci-bot mentioned this pull request Jul 30, 2025

[AUTOCUT] Gradle Check Flaky Test Report for FullClusterRestartIT #15813

Open

opensearch-ci-bot mentioned this pull request Jul 29, 2025

[AUTOCUT] Gradle Check Flaky Test Report for SearchWeightedRoutingIT #15843

Open

Merge branch 'opensearch-project:main' into FeatureRequest17599

2774f72

opensearch-ci-bot mentioned this pull request Jul 31, 2025

[AUTOCUT] Gradle Check Flaky Test Report for ClusterDisruptionIT #14308

Open

andrross reviewed Jul 31, 2025

View reviewed changes

server/src/main/java/org/opensearch/index/query/TermsQueryBuilder.java Outdated Show resolved Hide resolved

srikanthpadakanti and others added 2 commits July 31, 2025 18:36

Merge branch 'opensearch-project:main' into FeatureRequest17599

ecafcf4

Address the PR comments

ae9d422

Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>

andrross approved these changes Aug 1, 2025

View reviewed changes

andrross merged commit 88dc1e3 into opensearch-project:main Aug 1, 2025
31 checks passed

This was referenced Aug 3, 2025

[AUTOCUT] Gradle Check Flaky Test Report for IndexingIT #14302

Open

[AUTOCUT] Gradle Check Flaky Test Report for LeafSorterOptimizationTests #18898

Closed

BrewTestBot mentioned this pull request Aug 20, 2025

opensearch 3.2.0 Homebrew/homebrew-core#234146

Merged

Copilot AI mentioned this pull request Sep 2, 2025

Test srikanthpadakanti/OpenSearch#1

Closed

Enhance terms lookup query to take a query clause #18195

Enhance terms lookup query to take a query clause #18195

Uh oh!

Conversation

srikanthpadakanti commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Check List

Uh oh!

github-actions bot commented May 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 9, 2025

Uh oh!

github-actions bot commented May 14, 2025

Uh oh!

github-actions bot commented May 14, 2025

Uh oh!

github-actions bot commented May 14, 2025

Uh oh!

github-actions bot commented May 15, 2025

Uh oh!

github-actions bot commented May 15, 2025

Uh oh!

github-actions bot commented May 15, 2025

Uh oh!

github-actions bot commented May 15, 2025

Uh oh!

srikanthpadakanti commented Jul 31, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

github-actions bot commented Aug 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

srikanthpadakanti commented May 5, 2025 •

edited

Loading