Skip to content

Conversation

@rayshrey
Copy link
Contributor

Description

In composite directory for deleteFile method, we currently throw a NoSuchFileException if the file is not found in the directory.

In this PR we are adding a modification that instead of throwing a NoSuchFileException we simply fail silently.
This is needed because we can run into scenarios where stale files are evicted locally (zero refCount in FileCache) and not present in remote as well (due to metadata refresh). In such scenarios listAll() of composite directory will not show the file and operations such as refresh/merge where we calling this deleteFile method will fail.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
@github-actions
Copy link
Contributor

❕ Gradle check result for 75db1d3: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.53%. Comparing base (58c281f) to head (75db1d3).
Report is 16 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18299      +/-   ##
============================================
+ Coverage     72.44%   72.53%   +0.09%     
- Complexity    67256    67387     +131     
============================================
  Files          5488     5488              
  Lines        310994   311004      +10     
  Branches      45212    45213       +1     
============================================
+ Hits         225288   225595     +307     
+ Misses        67297    67067     -230     
+ Partials      18409    18342      -67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gbbafna gbbafna merged commit 6f4d6c5 into opensearch-project:main May 15, 2025
56 of 57 checks passed
tanik98 pushed a commit to tanik98/OpenSearch that referenced this pull request May 27, 2025
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Jun 1, 2025
rayshrey added a commit to rayshrey/OpenSearch that referenced this pull request Jun 26, 2025
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
…ory (opensearch-project#18299)

Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants