Composite Directory - silently fail instead of throwing error for non-existent file in deleteFile() call #18299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In composite directory for deleteFile method, we currently throw a NoSuchFileException if the file is not found in the directory.
In this PR we are adding a modification that instead of throwing a NoSuchFileException we simply fail silently.
This is needed because we can run into scenarios where stale files are evicted locally (zero refCount in FileCache) and not present in remote as well (due to metadata refresh). In such scenarios listAll() of composite directory will not show the file and operations such as refresh/merge where we calling this deleteFile method will fail.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.