Replace usage of deprecated createIndex() method in tests

[andrross]

The deprecated versions of this method take a type parameter, support for which was removed back in 2.0. The parameter is not used. I have kept the deprecated methods so as to not break downstream components that may be using them but changed all the code in server to stop passing in a type parameter.

Check List

• Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 98664e1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 98664e1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[gaobinlong]

❌ Gradle check result for 98664e1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Seems org.opensearch.index.mapper.size.SizeMappingTests.testSizeNotSet is flaky.

[andrross]

❌ Gradle check result for 98664e1: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Seems org.opensearch.index.mapper.size.SizeMappingTests.testSizeNotSet is flaky.

Previously the code was passing an empty string array as a simple mapping and the new code is passing null in the XContentBuilder argument position. It turns out those are not quite the same. I'll push a fix.

[github-actions]

❌ Gradle check result for 75c4f47: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 75c4f47: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.

[github-actions]

✅ Gradle check result for f30c5a8: SUCCESS

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.88%. Comparing base (64da5f1) to head (f30c5a8).
⚠️ Report is 59 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #18389      +/-   ##
============================================
- Coverage     72.91%   72.88%   -0.03%     
+ Complexity    69391    69358      -33     
============================================
  Files          5645     5645              
  Lines        318789   318789              
  Branches      46126    46126              
============================================
- Hits         232442   232348      -94     
- Misses        67551    67691     +140     
+ Partials      18796    18750      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[andrross]

@gaobinlong Can you take another look?

[gaobinlong]

LGTM