Skip to content

Ensure feature flags from opensearch.yml are set prior to plugin initialization #18432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rishabhmaurya merged 1 commit into from
Jun 5, 2025
Merged

Ensure feature flags from opensearch.yml are set prior to plugin initialization #18432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions server/src/main/java/org/opensearch/node/Node.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,10 @@ protected Node(final Environment initialEnvironment, Collection<PluginInfo> clas
);
}

// Ensure feature flags from opensearch.yml are valid during plugin initialization.
// Bug fix: https://github.com/opensearch-project/OpenSearch/issues/18417
Copy link
Member

@andrross andrross Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, but the commit message/PR description is the right place for this type of context. Unless it's a TODO or some other exception case we don't need to be adding issue links for code modifications.

FeatureFlags.initializeFeatureFlags(tmpSettings);

this.pluginsService = new PluginsService(
tmpSettings,
initialEnvironment.configDir(),
Expand Down
Loading