-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Remove searchable_snapshot.extended_compatibility experimental feature #18735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Hyunsang Han <gustkd3@gmail.com>
|
❌ Gradle check result for ef2dc57: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @HyunSangHan -- it's nice to see so much red in the diff! 😁
I've retried the failing checks, because they look like random flaky tests, not related to your change.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18735 +/- ##
=========================================
Coverage 72.80% 72.80%
- Complexity 68535 68557 +22
=========================================
Files 5572 5573 +1
Lines 314779 314781 +2
Branches 45691 45687 -4
=========================================
+ Hits 229166 229174 +8
- Misses 67014 67082 +68
+ Partials 18599 18525 -74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Andrew Ross <andrross@amazon.com>
|
@msfroh I just pushed a commit to appease the breaking changes check |
|
❌ Gradle check result for 2e78acd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Whoa... I thought I had merged this last week. Sorry about that. Just finally merged this now. |
opensearch-project#18735) --------- Signed-off-by: Hyunsang Han <gustkd3@gmail.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Co-authored-by: Andrew Ross <andrross@amazon.com>
opensearch-project#18735) --------- Signed-off-by: Hyunsang Han <gustkd3@gmail.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Co-authored-by: Andrew Ross <andrross@amazon.com>
Description
Removed the experimental
searchable_snapshot.extended_compatibilityfeature flag and all related functionality. (This feature was designed to allow Searchable Snapshots to read snapshots older than the guaranteed backward compatibility for OpenSearch on a best effort basis.)The removal simplifies the codebase by eliminating experimental functionality that was not widely adopted and reduces complexity in the searchable snapshot implementation.
Related Issues
Resolves #18592
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.