Skip to content

Conversation

@HyunSangHan
Copy link
Contributor

Description

Removed the experimental searchable_snapshot.extended_compatibility feature flag and all related functionality. (This feature was designed to allow Searchable Snapshots to read snapshots older than the guaranteed backward compatibility for OpenSearch on a best effort basis.)

The removal simplifies the codebase by eliminating experimental functionality that was not widely adopted and reduces complexity in the searchable snapshot implementation.

Related Issues

Resolves #18592

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Hyunsang Han <gustkd3@gmail.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for ef2dc57: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

@msfroh msfroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @HyunSangHan -- it's nice to see so much red in the diff! 😁

I've retried the failing checks, because they look like random flaky tests, not related to your change.

@github-actions
Copy link
Contributor

✅ Gradle check result for ef2dc57: SUCCESS

@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.80%. Comparing base (b609a50) to head (2e78acd).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
.../main/java/org/opensearch/index/IndexSettings.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #18735   +/-   ##
=========================================
  Coverage     72.80%   72.80%           
- Complexity    68535    68557   +22     
=========================================
  Files          5572     5573    +1     
  Lines        314779   314781    +2     
  Branches      45691    45687    -4     
=========================================
+ Hits         229166   229174    +8     
- Misses        67014    67082   +68     
+ Partials      18599    18525   -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Andrew Ross <andrross@amazon.com>
@andrross
Copy link
Member

@msfroh I just pushed a commit to appease the breaking changes check

@github-actions
Copy link
Contributor

❌ Gradle check result for 2e78acd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for 2e78acd: SUCCESS

@msfroh msfroh merged commit 592f4c8 into opensearch-project:main Jul 21, 2025
32 of 34 checks passed
@msfroh
Copy link
Contributor

msfroh commented Jul 21, 2025

Whoa... I thought I had merged this last week. Sorry about that. Just finally merged this now.

rgsriram pushed a commit to rgsriram/OpenSearch that referenced this pull request Jul 22, 2025
opensearch-project#18735)

---------

Signed-off-by: Hyunsang Han <gustkd3@gmail.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
Co-authored-by: Andrew Ross <andrross@amazon.com>
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Aug 5, 2025
opensearch-project#18735)

---------

Signed-off-by: Hyunsang Han <gustkd3@gmail.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
Co-authored-by: Andrew Ross <andrross@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request Search:Remote Search skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Remove searchable_snapshot.extended_compatibility experimental feature

3 participants