Skip to content

Conversation

@andrross
Copy link
Member

@peternied @reta Was this just a miss, or am I confused here? It seems like the whole point of experimental APIs is to exclude them from this compatibility enforcement. See #18754 where a change to an experimental API failed the compatibility check.

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andrew Ross <andrross@amazon.com>
@github-actions
Copy link
Contributor

✅ Gradle check result for 85f762f: SUCCESS

@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.89%. Comparing base (40e9e40) to head (85f762f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18832      +/-   ##
============================================
+ Coverage     72.80%   72.89%   +0.09%     
- Complexity    68609    68625      +16     
============================================
  Files          5572     5572              
  Lines        315196   315196              
  Branches      45750    45750              
============================================
+ Hits         229466   229774     +308     
+ Misses        67166    66758     -408     
- Partials      18564    18664     +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reta
Copy link
Contributor

reta commented Jul 25, 2025

@andrross I don't think it is a miss, there is an explicit set of annotations to include, (public, deprecated), do you run into compatibilities with experimental APIs anywhere? I see the reference to pull request, will take a look shortly

@andrross
Copy link
Member Author

@andrross I don't think it is a miss, there is an explicit set of annotations to include, (public, deprecated), do you run into compatibilities with experimental APIs anywhere? I see the reference to pull request, will take a look shortly

@reta Ah, that makes sense. Perhaps the issue here is that the experimental interface is an inner class inside an interface that is annotated with @PublicApi.

@reta
Copy link
Contributor

reta commented Jul 28, 2025

@reta Ah, that makes sense. Perhaps the issue here is that the experimental interface is an inner class inside an interface that is annotated with @PublicApi.

That's right, adding @ExperimentalApi to the exclusion list would solve the problem, thanks @andrross

@reta reta merged commit 1f761f2 into opensearch-project:main Jul 28, 2025
35 of 36 checks passed
@andrross andrross deleted the experimental-annotation-exclude branch July 29, 2025 20:14
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Aug 5, 2025
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants