-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Exclude @ExperimentalApi from compatibility check
#18832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude @ExperimentalApi from compatibility check
#18832
Conversation
Signed-off-by: Andrew Ross <andrross@amazon.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18832 +/- ##
============================================
+ Coverage 72.80% 72.89% +0.09%
- Complexity 68609 68625 +16
============================================
Files 5572 5572
Lines 315196 315196
Branches 45750 45750
============================================
+ Hits 229466 229774 +308
+ Misses 67166 66758 -408
- Partials 18564 18664 +100 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@andrross I don't think it is a miss, there is an explicit set of annotations to include, (public, deprecated), |
@reta Ah, that makes sense. Perhaps the issue here is that the experimental interface is an inner class inside an interface that is annotated with |
…ct#18832) Signed-off-by: Andrew Ross <andrross@amazon.com>
…ct#18832) Signed-off-by: Andrew Ross <andrross@amazon.com>
@peternied @reta Was this just a miss, or am I confused here? It seems like the whole point of experimental APIs is to exclude them from this compatibility enforcement. See #18754 where a change to an experimental API failed the compatibility check.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.