Skip to content

Conversation

@Harsh-87
Copy link
Contributor

Description

Addition of fileCache activeUsage evaluator to DiskThresholdMonitor

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

❌ Gradle check result for cb54acc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 9c613d1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for ec5db41: SUCCESS

@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 74.88372% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.86%. Comparing base (2c6a404) to head (508cf90).
⚠️ Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
...uster/routing/allocation/DiskThresholdMonitor.java 77.65% 17 Missing and 4 partials ⚠️
...routing/allocation/FileCacheThresholdSettings.java 80.00% 16 Missing and 4 partials ⚠️
...cluster/routing/allocation/FileCacheEvaluator.java 29.41% 8 Missing and 4 partials ⚠️
...tore/remote/filecache/AggregateFileCacheStats.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19071      +/-   ##
============================================
- Coverage     72.95%   72.86%   -0.10%     
+ Complexity    70115    70029      -86     
============================================
  Files          5687     5689       +2     
  Lines        321703   321885     +182     
  Branches      46534    46555      +21     
============================================
- Hits         234702   234538     -164     
- Misses        68074    68348     +274     
- Partials      18927    18999      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

❌ Gradle check result for b9fe4cd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 3a55fa2: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Harsh Kothari added 2 commits September 29, 2025 12:50
…ing' into filecache_disk_utilization_handling

Signed-off-by: Harsh Kothari <techarsh@amazon.com>
…ing' into filecache_disk_utilization_handling
@Harsh-87 Harsh-87 requested a review from gbbafna September 29, 2025 07:21
@github-actions
Copy link
Contributor

❌ Gradle check result for a36a36d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Harsh Kothari added 2 commits September 29, 2025 16:03
…ing' into filecache_disk_utilization_handling

Signed-off-by: Harsh Kothari <techarsh@amazon.com>
…ing' into filecache_disk_utilization_handling
@github-actions
Copy link
Contributor

❌ Gradle check result for 988bd02: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Harsh Kothari added 2 commits September 29, 2025 19:11
…ing' into filecache_disk_utilization_handling

Signed-off-by: Harsh Kothari <techarsh@amazon.com>
…ing' into filecache_disk_utilization_handling
@github-actions
Copy link
Contributor

❌ Gradle check result for 2055cb6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Harsh Kothari added 2 commits September 30, 2025 07:59
…ing' into filecache_disk_utilization_handling

Signed-off-by: Harsh Kothari <techarsh@amazon.com>
…ing' into filecache_disk_utilization_handling
@github-actions
Copy link
Contributor

❌ Gradle check result for a141b14: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for 3dbec5c: SUCCESS

Harsh-87 and others added 2 commits October 1, 2025 11:29
…n_handling

Signed-off-by: Harsh Kothari <techarsh@amazon.com>
…ing' into filecache_disk_utilization_handling
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

❕ Gradle check result for 508cf90: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@gbbafna gbbafna merged commit d151cfa into opensearch-project:main Oct 6, 2025
33 checks passed
@Harsh-87 Harsh-87 deleted the filecache_disk_utilization_handling branch October 6, 2025 05:23
rgsriram pushed a commit to rgsriram/OpenSearch that referenced this pull request Oct 11, 2025
Gagan6164 pushed a commit to Gagan6164/OpenSearch that referenced this pull request Oct 13, 2025
…pensearch-project#19071)

Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants