Skip to content

Change field data cache size setting defaults #19152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Sep 23, 2025
Merged

Change field data cache size setting defaults #19152

merged 21 commits into from
Sep 23, 2025

Conversation

@peteralfonsi
Copy link
Contributor

@peteralfonsi peteralfonsi commented Aug 26, 2025

Description

Changes field data cache size setting to default to 35% rather than no limit (-1). Previously, by default the FD cache was only limited by the (separate) field breaker setting at 40% of heap size, which would confusingly stop further requests rather than just evicting. Also makes the size setting dynamic.

As mentioned in the original issue, I'm open to changing the actual values from 35% and 40% to whatever people think is reasonable. See original issue for reasoning behind the two settings having different values.

Related Issues

Resolves #19104

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Make FD cache size setting dynamic
5c91795 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc labels Aug 26, 2025
changelog
285140f 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@peteralfonsi peteralfonsi mentioned this pull request Aug 26, 2025
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2025

❌ Gradle check result for 285140f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peteralfonsi peteralfonsi marked this pull request as draft August 26, 2025 19:19
fix tests
cd7b00c 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@peteralfonsi
Copy link
Contributor Author

peteralfonsi commented Aug 26, 2025

Flaky test: #14407

@peteralfonsi
Copy link
Contributor Author

peteralfonsi commented Sep 19, 2025

Flaky test: #14306

Merge branch 'main' into fd-cache-settings
1d5dd75 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2025

❌ Gradle check result for 1d5dd75: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

rerun gradle
0c7ffe5 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025

❌ Gradle check result for 0c7ffe5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peteralfonsi
Copy link
Contributor Author

peteralfonsi commented Sep 22, 2025

Flaky test: #19325

rerun gradle
d5d2141 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 22, 2025
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025

❌ Gradle check result for d5d2141: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peteralfonsi
Copy link
Contributor Author

peteralfonsi commented Sep 22, 2025

Flaky test: #18938

rerun gradle
b4b8d95 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025

❌ Gradle check result for b4b8d95: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Sep 22, 2025
Open
Open
@jainankitk
Copy link
Contributor

jainankitk commented Sep 22, 2025

Unrelated failures:

[Test Result](https://build.ci.opensearch.org/job/gradle-check/64066/testReport/) (2 failures / +2)

    [org.opensearch.plugin.kinesis.IngestFromKinesisIT.testAllActiveIngestion](https://build.ci.opensearch.org/job/gradle-check/64066/testReport/junit/org.opensearch.plugin.kinesis/IngestFromKinesisIT/testAllActiveIngestion/)
    [org.opensearch.index.IndexServiceTests.testAsyncTranslogTrimTaskOnClosedIndex](https://build.ci.opensearch.org/job/gradle-check/64066/testReport/junit/org.opensearch.index/IndexServiceTests/testAsyncTranslogTrimTaskOnClosedIndex/)

Retrying gradle check

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025

❌ Gradle check result for b4b8d95: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Peter Alfonsi added 2 commits September 23, 2025 09:03
rerun gradle
beb25e2 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Merge branch 'main' into fd-cache-settings
7d033c2
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025

✅ Gradle check result for 7d033c2: SUCCESS

@jainankitk jainankitk merged commit af75e0b into opensearch-project:main Sep 23, 2025
32 of 33 checks passed
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 24, 2025
Open
@peteralfonsi peteralfonsi mentioned this pull request Sep 25, 2025
Merged
1 task
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
@peteralfonsi @vinaykpud
Change field data cache size setting defaults (opensearch-project#19152)
f6ac04a 
---------
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Co-authored-by: Peter Alfonsi <petealft@amazon.com>
@andrross andrross mentioned this pull request Oct 6, 2025
Closed
@BrewTestBot BrewTestBot mentioned this pull request Oct 15, 2025
Merged
This was referenced Oct 22, 2025
Open
Open
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Nov 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkewwei kkewwei kkewwei left review comments

@jainankitk jainankitk jainankitk approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

+1 more reviewer

@sgup432 sgup432 sgup432 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc v3.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Change default settings for field data cache size

4 participants

@peteralfonsi @sgup432 @jainankitk @kkewwei