Add max_expansions option to wildcard interval #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
❌ Gradle Check failure df40fd7dcb6e780a97faf46ffeff980aa027743e |
|
Failure is unrelated to PR, please rerun. |
Add support for setting the max expansions on a wildcard interval. The default value is still 128 and the max value is bounded by `BooleanQuery.getMaxClauseCount()`. Signed-off-by: Matt Weber <matt@mattweber.org>
mattweber
force-pushed
the
wildcard_interval_max_expansions
branch
from
83fb289 to
4790ad8
Compare
|
❌ Gradle Check failure 83fb2891e6ed3c8714722b89ba46a34a853cbaa0 |
reta
reviewed
Jan 17, 2022
server/src/main/java/org/opensearch/index/query/IntervalsSourceProvider.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Jan 17, 2022
server/src/main/java/org/opensearch/index/query/IntervalsSourceProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matt Weber <matt@mattweber.org>
|
Thanks for the review @reta, I have pushed up the change. |
reta
approved these changes
Jan 17, 2022
|
start gradle check |
|
@nknize can you please take a look at this when you have a chance? |
|
thanks @nknize, can I backport it? |
|
Yes please! Thx! |
@mattweber Yes, basically you change it to V_1_3_0 and (sadly) it needs one more PR to master to change V_2_0_0 to V_1_3_0, otherwise backward compatibility tests will fail, thank you |
mattweber
added a commit
to mattweber/OpenSearch
that referenced
this pull request
Jan 26, 2022
Add support for setting the max expansions on a wildcard interval. The default value is still 128 and the max value is bounded by `BooleanQuery.getMaxClauseCount()`. Signed-off-by: Matt Weber <matt@mattweber.org>
5 tasks
mattweber
added a commit
to mattweber/OpenSearch
that referenced
this pull request
Jan 26, 2022
Change from 2x to 1.3 for wildcard interval max_expansion version check since opensearch-project#1916 was backported. Signed-off-by: Matt Weber <matt@mattweber.org>
5 tasks
nknize
pushed a commit
that referenced
this pull request
Jan 26, 2022
andrross
pushed a commit
that referenced
this pull request
Jan 27, 2022
Change from 2x to 1.3 for wildcard interval max_expansion version check since #1916 was backported. Signed-off-by: Matt Weber <matt@mattweber.org>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for setting the max expansions on a wildcard interval.
The default value is still 128 and the max value is bounded by
BooleanQuery.getMaxClauseCount().Issues Resolved
#1857
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.