add graceful handling of failures in QueryPhaseResultConsumer #19231
+26
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
github-actions
bot
added
>test-failure
Contributor
|
❌ Gradle check result for fb09d68: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Author
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
kaushalmahi12
force-pushed
the
flaky-ut
branch
from
fb09d68 to
6207664
Compare
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19231 +/- ##
============================================
+ Coverage 72.81% 72.86% +0.05%
- Complexity 69631 69666 +35
============================================
Files 5658 5658
Lines 320087 320096 +9
Branches 46345 46347 +2
============================================
+ Hits 233057 233230 +173
+ Misses 68118 67985 -133
+ Partials 18912 18881 -31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrross
reviewed
Sep 4, 2025
server/src/main/java/org/opensearch/action/search/QueryPhaseResultConsumer.java
Show resolved
Hide resolved
jainankitk
approved these changes
Sep 4, 2025
Contributor
jainankitk
left a comment
jainankitk
left a comment
There was a problem hiding this comment.
Thanks @kaushalmahi12 for addressing this flaky test. LGTM!
andrross
approved these changes
Sep 5, 2025
jainankitk
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 22, 2025
…arch-project#19231) --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
jainankitk
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 22, 2025
…arch-project#19231) --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Signed-off-by: Ankit Jain <jainankitk@apache.org>
jainankitk
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 22, 2025
…arch-project#19231) --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Signed-off-by: Ankit Jain <jainankitk@apache.org>
asimmahmood1
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 23, 2025
…arch-project#19231) --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
pranikum
pushed a commit
to pranikum/OpenSearch
that referenced
this pull request
Sep 23, 2025
…arch-project#19231) --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Sep 26, 2025
…arch-project#19231) --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
kaushalmahi12
added a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Oct 27, 2025
…arch-project#19231) --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the current shard level query phase result consumption logic we have incorrect handling of the result consumption callbacks.
The callbacks should always be executed irrespective of whether the error has occurred or not while processing shard level query results.
This change closes those incomplete callback loops by
Related Issues
Resolves #19094
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.