-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Adds a mapper for context aware segments grouping criteria #19233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
❌ Gradle check result for 4009145: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
3298285 to
1147e4a
Compare
f9a9828 to
94b7ce4
Compare
|
❌ Gradle check result for ddb577b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
ddb577b to
1960464
Compare
Signed-off-by: Tejas Shah <shatejas@amazon.com>
…teg tests Signed-off-by: Tejas Shah <shatejas@amazon.com>
507dcd2 to
d5f920b
Compare
|
❌ Gradle check result for ec031b2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Tejas Shah <shatejas@amazon.com>
ec031b2 to
3be7f35
Compare
|
❌ Gradle check result for 3be7f35: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 81c6291: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Tejas Shah <shatejas@amazon.com>
81c6291 to
5a9e26c
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19233 +/- ##
============================================
+ Coverage 73.00% 73.04% +0.04%
- Complexity 70534 70585 +51
============================================
Files 5719 5722 +3
Lines 323260 323387 +127
Branches 46816 46833 +17
============================================
+ Hits 235993 236220 +227
+ Misses 68224 68063 -161
- Partials 19043 19104 +61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…h-project#19233) * Adds Context aware grouping mapper The change also stores grouping criteria for each doc in parsed context Signed-off-by: Tejas Shah <shatejas@amazon.com> * Adds a test for ContextAwareGroupingScript Signed-off-by: Tejas Shah <shatejas@amazon.com> * Adds ContextAwareGroupingScript support in mockScriptEngine to fix integ tests Signed-off-by: Tejas Shah <shatejas@amazon.com> * Corrects CHANGELOG.md Signed-off-by: Tejas Shah <shatejas@amazon.com> * Fixes LangPainlessClientYamlTestSuiteIT Signed-off-by: Tejas Shah <shatejas@amazon.com> --------- Signed-off-by: Tejas Shah <shatejas@amazon.com> Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com>
…h-project#19233) * Adds Context aware grouping mapper The change also stores grouping criteria for each doc in parsed context Signed-off-by: Tejas Shah <shatejas@amazon.com> * Adds a test for ContextAwareGroupingScript Signed-off-by: Tejas Shah <shatejas@amazon.com> * Adds ContextAwareGroupingScript support in mockScriptEngine to fix integ tests Signed-off-by: Tejas Shah <shatejas@amazon.com> * Corrects CHANGELOG.md Signed-off-by: Tejas Shah <shatejas@amazon.com> * Fixes LangPainlessClientYamlTestSuiteIT Signed-off-by: Tejas Shah <shatejas@amazon.com> --------- Signed-off-by: Tejas Shah <shatejas@amazon.com>
…h-project#19233) * Adds Context aware grouping mapper The change also stores grouping criteria for each doc in parsed context Signed-off-by: Tejas Shah <shatejas@amazon.com> * Adds a test for ContextAwareGroupingScript Signed-off-by: Tejas Shah <shatejas@amazon.com> * Adds ContextAwareGroupingScript support in mockScriptEngine to fix integ tests Signed-off-by: Tejas Shah <shatejas@amazon.com> * Corrects CHANGELOG.md Signed-off-by: Tejas Shah <shatejas@amazon.com> * Fixes LangPainlessClientYamlTestSuiteIT Signed-off-by: Tejas Shah <shatejas@amazon.com> --------- Signed-off-by: Tejas Shah <shatejas@amazon.com>
* Introduce Interceptor to Grpc Plugin - Signed-off-by: Aparajita Pandey <aparajita29pandey@gmail.com> Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * This is a combination of 7 commits. Add testcases for gRPC Interceptor Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Ran spotlessAppy Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> refactor Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> spotlesssCheck Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> check if it verified Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Added GrpcInterceptorChain check if it verified Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> revert Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> empty commit Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Added GrpcInterceptorChain Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Added GrpcInterceptorChain Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Added GrpcInterceptorChain Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> testCases Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> logger Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Resolve Conflict Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> javadoc Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * javadoc Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * cleanuo Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * move GrpcInterceptor Interface to spi Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * move GrpcInterceptor Interface to spi Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * build.gradle fixes Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * GrpcInterceptorChain refactoring Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * GrpcInterceptorChain refactoring Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * rebase Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * coverage Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * spotless Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * Add logic to throw exception on workload group deletion with associated rules (#19502) Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * add documentation about debug-server-jvm in testing.md (#19567) Signed-off-by: Vigya Sharma <vigya.work@gmail.com> Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * Adds a mapper for context aware segments grouping criteria (#19233) * Adds Context aware grouping mapper The change also stores grouping criteria for each doc in parsed context Signed-off-by: Tejas Shah <shatejas@amazon.com> * Adds a test for ContextAwareGroupingScript Signed-off-by: Tejas Shah <shatejas@amazon.com> * Adds ContextAwareGroupingScript support in mockScriptEngine to fix integ tests Signed-off-by: Tejas Shah <shatejas@amazon.com> * Corrects CHANGELOG.md Signed-off-by: Tejas Shah <shatejas@amazon.com> * Fixes LangPainlessClientYamlTestSuiteIT Signed-off-by: Tejas Shah <shatejas@amazon.com> --------- Signed-off-by: Tejas Shah <shatejas@amazon.com> Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * Refactor README.md and GrpcInterceptorChain Constructor Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * UpdateREADME & switch to implmentation Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * refactoring Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * refactoring Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * Address PR review comments - Changed SPI dependencies from api to implementation - Made OrderedGrpcInterceptor a nested interface inside GrpcInterceptorProvider - Updated README with build.gradle extension declaration examples - Simplified duplicate order handling documentation Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * empty commit Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * resolve conflict Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> --------- Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Signed-off-by: Vigya Sharma <vigya.work@gmail.com> Signed-off-by: Tejas Shah <shatejas@amazon.com> Signed-off-by: Aparajita Pandey <37636092+aparajita31pandey@users.noreply.github.com> Co-authored-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Co-authored-by: Vigya Sharma <vigyas@amazon.com> Co-authored-by: Tejas Shah <shatejas@amazon.com>
…h-project#19233) * Adds Context aware grouping mapper The change also stores grouping criteria for each doc in parsed context Signed-off-by: Tejas Shah <shatejas@amazon.com> * Adds a test for ContextAwareGroupingScript Signed-off-by: Tejas Shah <shatejas@amazon.com> * Adds ContextAwareGroupingScript support in mockScriptEngine to fix integ tests Signed-off-by: Tejas Shah <shatejas@amazon.com> * Corrects CHANGELOG.md Signed-off-by: Tejas Shah <shatejas@amazon.com> * Fixes LangPainlessClientYamlTestSuiteIT Signed-off-by: Tejas Shah <shatejas@amazon.com> --------- Signed-off-by: Tejas Shah <shatejas@amazon.com>
…ct#19005) * Introduce Interceptor to Grpc Plugin - Signed-off-by: Aparajita Pandey <aparajita29pandey@gmail.com> Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * This is a combination of 7 commits. Add testcases for gRPC Interceptor Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Ran spotlessAppy Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> refactor Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> spotlesssCheck Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> check if it verified Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Added GrpcInterceptorChain check if it verified Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> revert Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> empty commit Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Added GrpcInterceptorChain Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Added GrpcInterceptorChain Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Added GrpcInterceptorChain Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> testCases Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> logger Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Resolve Conflict Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> javadoc Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * javadoc Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * cleanuo Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * move GrpcInterceptor Interface to spi Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * move GrpcInterceptor Interface to spi Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * build.gradle fixes Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * GrpcInterceptorChain refactoring Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * GrpcInterceptorChain refactoring Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * rebase Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * coverage Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * spotless Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * Add logic to throw exception on workload group deletion with associated rules (opensearch-project#19502) Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * add documentation about debug-server-jvm in testing.md (opensearch-project#19567) Signed-off-by: Vigya Sharma <vigya.work@gmail.com> Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * Adds a mapper for context aware segments grouping criteria (opensearch-project#19233) * Adds Context aware grouping mapper The change also stores grouping criteria for each doc in parsed context Signed-off-by: Tejas Shah <shatejas@amazon.com> * Adds a test for ContextAwareGroupingScript Signed-off-by: Tejas Shah <shatejas@amazon.com> * Adds ContextAwareGroupingScript support in mockScriptEngine to fix integ tests Signed-off-by: Tejas Shah <shatejas@amazon.com> * Corrects CHANGELOG.md Signed-off-by: Tejas Shah <shatejas@amazon.com> * Fixes LangPainlessClientYamlTestSuiteIT Signed-off-by: Tejas Shah <shatejas@amazon.com> --------- Signed-off-by: Tejas Shah <shatejas@amazon.com> Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * Refactor README.md and GrpcInterceptorChain Constructor Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * UpdateREADME & switch to implmentation Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * refactoring Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * refactoring Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * Address PR review comments - Changed SPI dependencies from api to implementation - Made OrderedGrpcInterceptor a nested interface inside GrpcInterceptorProvider - Updated README with build.gradle extension declaration examples - Simplified duplicate order handling documentation Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * empty commit Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * resolve conflict Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> --------- Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Signed-off-by: Vigya Sharma <vigya.work@gmail.com> Signed-off-by: Tejas Shah <shatejas@amazon.com> Signed-off-by: Aparajita Pandey <37636092+aparajita31pandey@users.noreply.github.com> Co-authored-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Co-authored-by: Vigya Sharma <vigyas@amazon.com> Co-authored-by: Tejas Shah <shatejas@amazon.com>
…ct#19005) * Introduce Interceptor to Grpc Plugin - Signed-off-by: Aparajita Pandey <aparajita29pandey@gmail.com> Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * This is a combination of 7 commits. Add testcases for gRPC Interceptor Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Ran spotlessAppy Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> refactor Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> spotlesssCheck Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> check if it verified Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Added GrpcInterceptorChain check if it verified Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> revert Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> empty commit Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Added GrpcInterceptorChain Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Added GrpcInterceptorChain Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Added GrpcInterceptorChain Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> testCases Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> logger Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Resolve Conflict Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> javadoc Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * javadoc Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * cleanuo Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * move GrpcInterceptor Interface to spi Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * move GrpcInterceptor Interface to spi Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * build.gradle fixes Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * GrpcInterceptorChain refactoring Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * GrpcInterceptorChain refactoring Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * rebase Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * coverage Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * spotless Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * Add logic to throw exception on workload group deletion with associated rules (opensearch-project#19502) Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * add documentation about debug-server-jvm in testing.md (opensearch-project#19567) Signed-off-by: Vigya Sharma <vigya.work@gmail.com> Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * Adds a mapper for context aware segments grouping criteria (opensearch-project#19233) * Adds Context aware grouping mapper The change also stores grouping criteria for each doc in parsed context Signed-off-by: Tejas Shah <shatejas@amazon.com> * Adds a test for ContextAwareGroupingScript Signed-off-by: Tejas Shah <shatejas@amazon.com> * Adds ContextAwareGroupingScript support in mockScriptEngine to fix integ tests Signed-off-by: Tejas Shah <shatejas@amazon.com> * Corrects CHANGELOG.md Signed-off-by: Tejas Shah <shatejas@amazon.com> * Fixes LangPainlessClientYamlTestSuiteIT Signed-off-by: Tejas Shah <shatejas@amazon.com> --------- Signed-off-by: Tejas Shah <shatejas@amazon.com> Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * Refactor README.md and GrpcInterceptorChain Constructor Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * UpdateREADME & switch to implmentation Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * refactoring Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * refactoring Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * Address PR review comments - Changed SPI dependencies from api to implementation - Made OrderedGrpcInterceptor a nested interface inside GrpcInterceptorProvider - Updated README with build.gradle extension declaration examples - Simplified duplicate order handling documentation Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * empty commit Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> * resolve conflict Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> --------- Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Signed-off-by: Vigya Sharma <vigya.work@gmail.com> Signed-off-by: Tejas Shah <shatejas@amazon.com> Signed-off-by: Aparajita Pandey <37636092+aparajita31pandey@users.noreply.github.com> Co-authored-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Co-authored-by: Vigya Sharma <vigyas@amazon.com> Co-authored-by: Tejas Shah <shatejas@amazon.com>
Description
This is a new mapper for context aware segments. It also has indexing side of changes and stores the grouping criteria in parsed documents
Related Issues
RFC: #19223
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.