[BUG] Wait for outstanding requests to complete in LastSuccessfulSett… #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ingsUpdate test Signed-off-by: Suraj Singh <surajrider@gmail.com>
|
Can one of the admins verify this patch? |
andrross
reviewed
Jan 20, 2022
| @@ -645,6 +645,14 @@ public void testShardIndexingPressureLastSuccessfulSettingsUpdate() throws Excep | |||
| IndexingPressureService.class, | |||
| coordinatingOnlyNode | |||
| ).getShardIndexingPressure().getShardIndexingPressureTracker(shardId); | |||
| assertBusy( | |||
There was a problem hiding this comment.
Could you refactor this to a static helper like the following? I might make the code a bit more concise and easier to read.
private static void waitForTwoOutstandingRequests(ShardIndexingPressureTracker tracker) {
...
}
…ingsUpdate test Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
andrross
approved these changes
Jan 20, 2022
|
@dreamer-89 can you make sure this gets backported to 1.x? |
owaiskazi19
added
the
pending backport
dreamer-89
added a commit
to dreamer-89/OpenSearch
that referenced
this pull request
Jan 21, 2022
opensearch-project#1939) * [BUG] Wait for outstanding requests to complete in LastSuccessfulSettingsUpdate test Signed-off-by: Suraj Singh <surajrider@gmail.com> * [BUG] Wait for outstanding requests to complete in LastSuccessfulSettingsUpdate test Signed-off-by: Suraj Singh <surajrider@gmail.com>
5 tasks
andrross
pushed a commit
that referenced
this pull request
Jan 21, 2022
* [Bug] Wait for outstanding requests to complete (#1925) Signed-off-by: Suraj Singh <surajrider@gmail.com> * [BUG] Wait for outstanding requests to complete in LastSuccessfulSett… (#1939) * [BUG] Wait for outstanding requests to complete in LastSuccessfulSettingsUpdate test Signed-off-by: Suraj Singh <surajrider@gmail.com> * [BUG] Wait for outstanding requests to complete in LastSuccessfulSettingsUpdate test Signed-off-by: Suraj Singh <surajrider@gmail.com>
andrross
removed
the
pending backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ingsUpdate test
Signed-off-by: Suraj Singh surajrider@gmail.com
Description
The change adds wait for outstanding requests to avoid failure due to occasional processing delays in previous requests. This change fixes the timeout issue in
testShardIndexingPressureLastSuccessfulSettingsUpdatemethod. A previous fix was done fortestShardIndexingPressureEnforcedEnabledDisabledSettingtest here.Issues Resolved
1843
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.