Skip to content

Conversation

@varunbharadwaj
Copy link
Contributor

@varunbharadwaj varunbharadwaj commented Sep 24, 2025

Description

Lag is computed as the difference between system time and last processed message timestamp. In the case no message is consumed for a long time, the lag keeps increasing. We solve this by setting lag to 0 if empty batch is read from the streaming source. We also explicitly set lag to 0 if the poller is paused.

image

Related Issues

Follow up for #17077

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com>
@github-actions
Copy link
Contributor

✅ Gradle check result for 5da5636: SUCCESS

@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.87%. Comparing base (a132bb5) to head (5da5636).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...rch/indices/pollingingest/DefaultStreamPoller.java 75.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19393      +/-   ##
============================================
+ Coverage     72.81%   72.87%   +0.05%     
- Complexity    69838    69857      +19     
============================================
  Files          5674     5674              
  Lines        320850   320890      +40     
  Branches      46383    46390       +7     
============================================
+ Hits         233624   233843     +219     
+ Misses        68361    68073     -288     
- Partials      18865    18974     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@varunbharadwaj varunbharadwaj marked this pull request as ready for review September 24, 2025 03:50
@varunbharadwaj varunbharadwaj requested a review from a team as a code owner September 24, 2025 03:50
@mch2 mch2 merged commit 6fdb010 into opensearch-project:main Sep 24, 2025
36 checks passed
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants