-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Use pack method for half_float and unsigned_long
#19553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
|
Hello! |
|
❕ Gradle check result for cac0791: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19553 +/- ##
============================================
+ Coverage 73.00% 73.06% +0.06%
- Complexity 70534 70582 +48
============================================
Files 5719 5719
Lines 323260 323260
Branches 46816 46816
============================================
+ Hits 235993 236197 +204
+ Misses 68224 67977 -247
- Partials 19043 19086 +43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
server/src/main/java/org/opensearch/index/mapper/NumberFieldMapper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/mapper/NumberFieldMapper.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
|
❌ Gradle check result for 215a0bd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Unrelated test failure: Retrying the gradle check |
jainankitk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
|
❌ Gradle check result for 479e4cb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
d3ad5b8
into
opensearch-project:main
…ject#19553) * use pack methods Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * update changelog Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * update changelog Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Remove array creation Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Fix changelog Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> --------- Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
…ject#19553) * use pack methods Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * update changelog Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * update changelog Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Remove array creation Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Fix changelog Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> --------- Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
…ject#19553) * use pack methods Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * update changelog Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * update changelog Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Remove array creation Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Fix changelog Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> --------- Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
…ject#19553) * use pack methods Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * update changelog Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * update changelog Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Remove array creation Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> * Fix changelog Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> --------- Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
pack method for half_float and usigned_longpack method for half_float and unsigned_long
Description
With this feature apache/lucene#14784 released with Lucene 10.3.0 release (https://lucene.apache.org/core/10_3_0/changes/Changes.html#v10.3.0.new_features) , we should be able to directly use the
packmethod forhalf_floatandusigned_longwhen usingApproximatePointRangeQuery.Related Issues
ApproximatePointRangeQueryto other numeric ranges(int, long, float etc) #14406Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.