Skip to content

Conversation

@prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Oct 7, 2025

Description

With this feature apache/lucene#14784 released with Lucene 10.3.0 release (https://lucene.apache.org/core/10_3_0/changes/Changes.html#v10.3.0.new_features) , we should be able to directly use the pack method for half_float and usigned_long when using ApproximatePointRangeQuery.

Related Issues

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Hello!
We have added a performance benchmark workflow that runs by adding a comment on the PR.
Please refer https://github.com/opensearch-project/OpenSearch/blob/main/PERFORMANCE_BENCHMARKS.md on how to run benchmarks on pull requests.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

❕ Gradle check result for cac0791: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.06%. Comparing base (39b7a59) to head (479e4cb).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19553      +/-   ##
============================================
+ Coverage     73.00%   73.06%   +0.06%     
- Complexity    70534    70582      +48     
============================================
  Files          5719     5719              
  Lines        323260   323260              
  Branches      46816    46816              
============================================
+ Hits         235993   236197     +204     
+ Misses        68224    67977     -247     
- Partials      19043    19086      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Performance Roadmap Oct 7, 2025
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

❌ Gradle check result for 215a0bd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Contributor

Unrelated test failure:

[Test Result](https://build.ci.opensearch.org/job/gradle-check/65126/testReport/) (1 failure / ±0)

    [org.opensearch.upgrades.FullClusterRestartIT.testRecovery](https://build.ci.opensearch.org/job/gradle-check/65126/testReport/junit/org.opensearch.upgrades/FullClusterRestartIT/testRecovery/)

Retrying the gradle check

Copy link
Contributor

@jainankitk jainankitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

❌ Gradle check result for 479e4cb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

✅ Gradle check result for 479e4cb: SUCCESS

@prudhvigodithi prudhvigodithi merged commit d3ad5b8 into opensearch-project:main Oct 8, 2025
34 of 36 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Performance Roadmap Oct 8, 2025
rgsriram pushed a commit to rgsriram/OpenSearch that referenced this pull request Oct 11, 2025
…ject#19553)

* use pack methods

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

* update changelog

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

* update changelog

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

* Remove array creation

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

* Fix changelog

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

---------

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
rgsriram pushed a commit to rgsriram/OpenSearch that referenced this pull request Oct 11, 2025
…ject#19553)

* use pack methods

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

* update changelog

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

* update changelog

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

* Remove array creation

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

* Fix changelog

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

---------

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Gagan6164 pushed a commit to Gagan6164/OpenSearch that referenced this pull request Oct 13, 2025
…ject#19553)

* use pack methods

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

* update changelog

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

* update changelog

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

* Remove array creation

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

* Fix changelog

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

---------

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
…ject#19553)

* use pack methods

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

* update changelog

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

* update changelog

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

* Remove array creation

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

* Fix changelog

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>

---------

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
@sandeshkr419 sandeshkr419 changed the title Use pack method for half_float and usigned_long Use pack method for half_float and unsigned_long Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants