Handle deleted documents for filter rewrite subaggregation optimization #19643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankit Jain <jainankitk@apache.org>
jainankitk
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
github-actions
bot
added
enhancement
Contributor
|
❌ Gradle check result for f031019: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Author
|
{"run-benchmark-test": "id_8"} |
Contributor
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/4731/ . Final results will be published once the job is completed. |
Signed-off-by: Ankit Jain <jainankitk@apache.org>
Contributor
Author
|
{"run-benchmark-test": "id_8"} |
Contributor
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/4732/ . Final results will be published once the job is completed. |
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19643 +/- ##
============================================
+ Coverage 73.09% 73.26% +0.16%
- Complexity 71062 71279 +217
============================================
Files 5754 5766 +12
Lines 325260 325480 +220
Branches 47036 47086 +50
============================================
+ Hits 237736 238447 +711
+ Misses 68383 67868 -515
- Partials 19141 19165 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/4731/
|
Collaborator
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/4732/
|
Contributor
|
{"run-benchmark-test": "id_3"} |
This was referenced Oct 16, 2025
Contributor
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/4744/ . Final results will be published once the job is completed. |
Collaborator
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/4744/
|
Collaborator
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/170/
|
Contributor
Author
|
Okay, I notice very slight improvement (~5%) in the latency for |
Member
|
@jainankitk commented on Oct 17, 2025, 1:07 PM PDT:
5% is normal variance. And the change seems to be same, so I'm not worried about this. |
Signed-off-by: Ankit Jain <jainankitk@apache.org>
Signed-off-by: Ankit Jain <jainankitk@apache.org>
Contributor
Author
|
{"run-benchmark-test": "id_3"} |
Contributor
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/4943/ . Final results will be published once the job is completed. |
Signed-off-by: Ankit Jain <jainankitk@apache.org>
Contributor
bowenlan-amzn
approved these changes
Nov 5, 2025
Collaborator
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/4943/
|
Collaborator
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/175/
|
rishabhmaurya
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, PointRangeTree subaggregation optimization is skipped if there are any deleted documents. But, since we explicitly create bitset of matching docIds for each bucket in case of sub-aggregations, deleted documents can be filtered out.
Related Issues
Resolves #19642
Related PR #17447
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.