-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Update bundled JDK to JDK-25 #19698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bundled JDK to JDK-25 #19698
Conversation
|
Pending merging until these two are merged and updated on dockerhub/ami, so that this PR can be properly tested with JDK 25-enabled gradle check.
Thanks. |
|
❌ Gradle check result for 0d03596: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 0d03596: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Let's not merge this yet. I'm able to get the following to fail about reliably (about 75 out of 100 iterations fails): The test is expecting ScriptException with a LambdaConversionException as the cause, but about 75% of the time it is a java.lang.Error with a LambdaConversionException as the cause. |
|
❌ Gradle check result for 0d03596: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
It looks like there's a behavior change to wrap checked exceptions with java.lang.Error in this commit in the JDK that's causing the issue here. |
jainankitk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, ready to go after #19706 and infra updates - #19698 (comment)!
0d03596 to
77f5b69
Compare
|
❌ Gradle check result for 77f5b69: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 77f5b69: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
77f5b69 to
3162ad3
Compare
|
❌ Gradle check result for 3162ad3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
3162ad3 to
b883021
Compare
|
❌ Gradle check result for b883021: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Jenkins just deployed with the new JDK25 updated agents. Thanks. |
|
❌ Gradle check result for a84e527: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
a84e527 to
da5773b
Compare
|
❌ Gradle check result for da5773b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
buildSrc/src/main/java/org/opensearch/gradle/test/DistroTestPlugin.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/org/opensearch/gradle/test/DistroTestPlugin.java
Outdated
Show resolved
Hide resolved
da5773b to
a553a14
Compare
|
❌ Gradle check result for a553a14: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 8c6cf5a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 8c6cf5a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 8c6cf5a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 8c6cf5a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 1bdc537: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 1bdc537: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Andrew Ross <andrross@amazon.com>
1bdc537 to
a65c874
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19698 +/- ##
============================================
+ Coverage 73.13% 73.15% +0.02%
+ Complexity 71116 71105 -11
============================================
Files 5754 5754
Lines 325301 325301
Branches 47054 47054
============================================
+ Hits 237896 237971 +75
+ Misses 68320 68171 -149
- Partials 19085 19159 +74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Andrew Ross <andrross@amazon.com>
Related Issues
Resolves #19314
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.