Skip to content

Conversation

@andrross
Copy link
Member

Related Issues

Resolves #19314

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@andrross andrross requested a review from a team as a code owner October 20, 2025 19:59
@github-actions github-actions bot added Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. enhancement Enhancement or improvement to existing feature or request release v3.3.0 labels Oct 20, 2025
@peterzhuamazon
Copy link
Member

peterzhuamazon commented Oct 20, 2025

Pending merging until these two are merged and updated on dockerhub/ami, so that this PR can be properly tested with JDK 25-enabled gradle check.

Thanks.

@github-actions
Copy link
Contributor

❌ Gradle check result for 0d03596: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 0d03596: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross andrross marked this pull request as draft October 20, 2025 22:34
@andrross
Copy link
Member Author

Let's not merge this yet. I'm able to get the following to fail about reliably (about 75 out of 100 iterations fails):

./gradlew ':modules:lang-painless:test' --tests 'org.opensearch.painless.FunctionRefTests.testReturnVoidDef'  -Dtests.iters=100

The test is expecting ScriptException with a LambdaConversionException as the cause, but about 75% of the time it is a java.lang.Error with a LambdaConversionException as the cause.

@github-actions
Copy link
Contributor

❌ Gradle check result for 0d03596: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross andrross added v3.4.0 Issues and PRs related to version 3.4.0 and removed v3.3.0 labels Oct 20, 2025
@andrross
Copy link
Member Author

It looks like there's a behavior change to wrap checked exceptions with java.lang.Error in this commit in the JDK that's causing the issue here.

Copy link
Contributor

@jainankitk jainankitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, ready to go after #19706 and infra updates - #19698 (comment)!

@github-actions
Copy link
Contributor

❌ Gradle check result for 77f5b69: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 77f5b69: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 3162ad3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for b883021:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peterzhuamazon
Copy link
Member

Jenkins just deployed with the new JDK25 updated agents.
Let's try again.

Thanks.

@github-actions
Copy link
Contributor

❌ Gradle check result for a84e527: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for da5773b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for a553a14: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Oct 30, 2025

@github-actions
Copy link
Contributor

❌ Gradle check result for 8c6cf5a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 8c6cf5a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 8c6cf5a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 8c6cf5a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 1bdc537: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 1bdc537: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Andrew Ross <andrross@amazon.com>
@github-actions
Copy link
Contributor

✅ Gradle check result for a65c874: SUCCESS

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.15%. Comparing base (0a77be1) to head (a65c874).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19698      +/-   ##
============================================
+ Coverage     73.13%   73.15%   +0.02%     
+ Complexity    71116    71105      -11     
============================================
  Files          5754     5754              
  Lines        325301   325301              
  Branches      47054    47054              
============================================
+ Hits         237896   237971      +75     
+ Misses        68320    68171     -149     
- Partials      19085    19159      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross andrross merged commit bbd226e into opensearch-project:main Oct 31, 2025
33 checks passed
@andrross andrross deleted the bundle-jdk25 branch October 31, 2025 20:25
anandpatel9998 pushed a commit to anandpatel9998/OpenSearch that referenced this pull request Nov 3, 2025
Signed-off-by: Andrew Ross <andrross@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. enhancement Enhancement or improvement to existing feature or request release v3.4.0 Issues and PRs related to version 3.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update bundled JDK to JDK25

5 participants