Replace explicit type conversion with instanceof pattern variable in org.opensearch.index package #19859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…org.opensearch.index package Signed-off-by: Binlong Gao <gbinlong@amazon.com>
gaobinlong
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Contributor
sandeshkr419
approved these changes
Nov 3, 2025
Member
sandeshkr419
left a comment
sandeshkr419
left a comment
There was a problem hiding this comment.
Thanks for making these changes. A few nit-picks to address.
server/src/main/java/org/opensearch/index/analysis/NamedAnalyzer.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/index/compositeindex/datacube/startree/builder/BaseStarTreeBuilder.java
Show resolved
Hide resolved
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Contributor
sandeshkr419
approved these changes
Nov 3, 2025
anandpatel9998
pushed a commit
to anandpatel9998/OpenSearch
that referenced
this pull request
Nov 3, 2025
…org.opensearch.index package (opensearch-project#19859) * Replace explicit type conversion with instanceof pattern variable in org.opensearch.index package Signed-off-by: Binlong Gao <gbinlong@amazon.com> * Optimize some code Signed-off-by: Binlong Gao <gbinlong@amazon.com> --------- Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #19714.
Use the modern instanceof pattern variables instead of explicit type conversions in the package org.opensearch.index, this can improve the code readability and reduce potential ClassCastException risks.
Most code are generated by LLM, and I checked them manually and reverted the unnecessary and wrong changes.
Related Issues
No issue, just #19595 (comment).
Check List
- [ ] Functionality includes testing.
- [ ] API changes companion pull request created, if applicable.
- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.