Skip to content

Conversation

@karenyrx
Copy link
Contributor

@karenyrx karenyrx commented Nov 9, 2025

Description

A series of gRPC bulk API fixes/optimizations:

  1. Fix update operation to use doc field instead of object field (still fallsback to object for backward compatibility)
  2. Fix the default value of fetchSource to null to match REST
  3. Add pipeline support for upsert
  4. Optimize document bytes copying to pass bytes reference

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…llsback to object for bwc)

bytes optimize

Set the default value of source to null to match REST

Support allowExplicitIndex setting

Signed-off-by: Karen Xu <karenxyr@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2025

❌ Gradle check result for f3818ca: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Karen Xu <karenxyr@gmail.com>
Signed-off-by: Karen Xu <karenxyr@gmail.com>
@github-actions
Copy link
Contributor

❕ Gradle check result for 34bbaf4: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 91.83673% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.24%. Comparing base (2f930dc) to head (2fa7426).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...est/document/bulk/BulkRequestParserProtoUtils.java 91.66% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #19937   +/-   ##
=========================================
  Coverage     73.24%   73.24%           
- Complexity    71519    71561   +42     
=========================================
  Files          5789     5789           
  Lines        327121   327142   +21     
  Branches      47117    47120    +3     
=========================================
+ Hits         239591   239608   +17     
- Misses        68269    68324   +55     
+ Partials      19261    19210   -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@karenyrx karenyrx marked this pull request as ready for review November 10, 2025 21:50
@karenyrx karenyrx requested a review from a team as a code owner November 10, 2025 21:50
Signed-off-by: Karen Xu <karenxyr@gmail.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for 6d897b8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 6d897b8: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Karen Xu <karenxyr@gmail.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for 2a16f30: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❕ Gradle check result for 2a16f30: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Signed-off-by: Karen Xu <karenxyr@gmail.com>
@github-actions
Copy link
Contributor

✅ Gradle check result for 3b80f63: SUCCESS

Copy link
Contributor

@msfroh msfroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall. I really appreciate the use of zero-copy for the byte arrays.

I'll hold off on merging until you've had a chance to respond to @varunbharadwaj's comments.

@github-actions
Copy link
Contributor

❌ Gradle check result for 9e0aae9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Karen X <karenxyr@gmail.com>
Signed-off-by: Karen X <karenxyr@gmail.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for 2fa7426: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for 2fa7426: SUCCESS

@karenyrx karenyrx merged commit 6a54b0b into opensearch-project:main Nov 19, 2025
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants