-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[GRPC] Bulk optimization and fixes #19937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…llsback to object for bwc) bytes optimize Set the default value of source to null to match REST Support allowExplicitIndex setting Signed-off-by: Karen Xu <karenxyr@gmail.com>
|
❌ Gradle check result for f3818ca: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 34bbaf4: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19937 +/- ##
=========================================
Coverage 73.24% 73.24%
- Complexity 71519 71561 +42
=========================================
Files 5789 5789
Lines 327121 327142 +21
Branches 47117 47120 +3
=========================================
+ Hits 239591 239608 +17
- Misses 68269 68324 +55
+ Partials 19261 19210 -51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
❌ Gradle check result for 6d897b8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 6d897b8: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...a/org/opensearch/transport/grpc/proto/request/document/bulk/BulkRequestParserProtoUtils.java
Outdated
Show resolved
Hide resolved
...a/org/opensearch/transport/grpc/proto/request/document/bulk/BulkRequestParserProtoUtils.java
Show resolved
Hide resolved
Signed-off-by: Karen Xu <karenxyr@gmail.com>
|
❌ Gradle check result for 2a16f30: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...a/org/opensearch/transport/grpc/proto/request/document/bulk/BulkRequestParserProtoUtils.java
Show resolved
Hide resolved
|
❕ Gradle check result for 2a16f30: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Karen Xu <karenxyr@gmail.com>
...a/org/opensearch/transport/grpc/proto/request/document/bulk/BulkRequestParserProtoUtils.java
Show resolved
Hide resolved
...a/org/opensearch/transport/grpc/proto/request/document/bulk/BulkRequestParserProtoUtils.java
Outdated
Show resolved
Hide resolved
...a/org/opensearch/transport/grpc/proto/request/document/bulk/BulkRequestParserProtoUtils.java
Outdated
Show resolved
Hide resolved
msfroh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall. I really appreciate the use of zero-copy for the byte arrays.
I'll hold off on merging until you've had a chance to respond to @varunbharadwaj's comments.
...a/org/opensearch/transport/grpc/proto/request/document/bulk/BulkRequestParserProtoUtils.java
Show resolved
Hide resolved
|
❌ Gradle check result for 9e0aae9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Karen X <karenxyr@gmail.com>
Signed-off-by: Karen X <karenxyr@gmail.com>
|
❌ Gradle check result for 2fa7426: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
A series of gRPC bulk API fixes/optimizations:
docfield instead ofobjectfield (still fallsback to object for backward compatibility)Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.