Update NoOpResult constructors to be public #19950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com>
varunbharadwaj
force-pushed
the
vb/noop
branch
from
a7cb910 to
08899a2
Compare
Contributor
|
❌ Gradle check result for 08899a2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com>
Contributor
|
❌ Gradle check result for f24fff0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19950 +/- ##
============================================
- Coverage 73.30% 73.21% -0.10%
+ Complexity 71582 71546 -36
============================================
Files 5785 5785
Lines 326961 326961
Branches 47296 47296
============================================
- Hits 239684 239385 -299
- Misses 68026 68275 +249
- Partials 19251 19301 +50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
varunbharadwaj
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale and
saratvemulapalli
as code owners
varunbharadwaj
requested review from
a team,
shwetathareja and
sohami
as code owners
Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com>
Contributor
mgodwan
approved these changes
Nov 11, 2025
andrross
approved these changes
Nov 11, 2025
rgsriram
pushed a commit
to rgsriram/OpenSearch
that referenced
this pull request
Dec 5, 2025
Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update NoOpResult in the Engine to be public. This will allow plugins with custom engine implementations to override the noOp method. Currently, this is required for the TSDB engine variant.
Related Issues
Resolves #19949
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.