[Backport 1.x] Fix AssertionError message

[github-actions]

Backport 270c59f from #2044

[opensearch-ci-bot]

Can one of the admins verify this patch?

[opensearch-ci-bot]

❌   Gradle Check failure f6818d5
Log 2201

Reports 2201

[tlfeng]

In Log 2201:

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.coordination.Zen1IT.testZen2NodesJoiningZen1Cluster" -Dtests.seed=9BEC23D1ED301BA0 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-DO -Dtests.timezone=Pacific/Wallis -Druntime.java=17

org.opensearch.cluster.coordination.Zen1IT > testZen2NodesJoiningZen1Cluster FAILED
    java.lang.AssertionError: node_t0 still having pending states:
    cluster uuid: Dzc-NXAnQIej_D7Uyx2ufw [committed: false]
...
    Expected: an empty array
         but: array size was <1>
        at __randomizedtesting.SeedInfo.seed([9BEC23D1ED301BA0:8EB7DC57E5182715]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.opensearch.test.OpenSearchIntegTestCase.lambda$afterInternal$3(OpenSearchIntegTestCase.java:622)
        at org.opensearch.test.OpenSearchTestCase.assertBusy(OpenSearchTestCase.java:1048)
        at org.opensearch.test.OpenSearchTestCase.assertBusy(OpenSearchTestCase.java:1021)
        at org.opensearch.test.OpenSearchIntegTestCase.afterInternal(OpenSearchIntegTestCase.java:620)
        at org.opensearch.test.OpenSearchIntegTestCase.cleanUpCluster(OpenSearchIntegTestCase.java:2377)
...
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
        at java.base/java.lang.Thread.run(Thread.java:833)

I created an issue #2046 to record the above test failure, and the below test failure reported in issue #1908

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.gateway.QuorumGatewayIT.testQuorumRecovery" -Dtests.seed=9BEC23D1ED301BA0 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ga -Dtests.timezone=Asia/Vientiane -Druntime.java=17

org.opensearch.gateway.QuorumGatewayIT > testQuorumRecovery FAILED
    java.lang.AssertionError: timed out waiting for green state
        at __randomizedtesting.SeedInfo.seed([9BEC23D1ED301BA0:7ED31F024C4DCCBB]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureColor(OpenSearchIntegTestCase.java:1019)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:958)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:947)
        at org.opensearch.gateway.QuorumGatewayIT.testQuorumRecovery(QuorumGatewayIT.java:111)

[tlfeng]

start gradle check, to trigger the check task again.

[opensearch-ci-bot]

✅   Gradle Check success f6818d5
Log 2203

Reports 2203