[Backport 1.x] Support first and last parameter for missing bucket ordering in composite aggregation #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…site aggregation (opensearch-project#1942) Support for "first" and "last" parameters for missing bucket ordering in composite aggregation. By default, if order is asc, missing_bucket at first, if order is desc, missing_bucket at last. If missing_order is "first" or "last", regardless order, missing_bucket is at first or last respectively. Signed-off-by: Peng Huo <penghuo@gmail.com>
|
Can one of the admins verify this patch? |
penghuo
changed the title
saratvemulapalli
added
backport
saratvemulapalli
approved these changes
Feb 15, 2022
6 tasks
andrross
added a commit
to andrross/OpenSearch
that referenced
this pull request
Feb 16, 2022
…in composite aggregation (opensearch-project#1942) (opensearch-project#2049)" This reverts commit 5b27136. Signed-off-by: Andrew Ross <andrross@amazon.com>
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backporting #1942 and #2005 to 1.x branch.
Passed,
./gradlew ':server:test' -Dtests.iters=100 --tests "org.opensearch.search.aggregations.bucket.composite.CompositeAggregatorTests"Passed,
./gradlew precommitIssues Resolved
#1899
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.