-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace internal usages of 'master' term in 'server/src/main' directory #2519
Merged
dblock
merged 20 commits into
opensearch-project:main
from
tlfeng:replace-master-int-server-main
Apr 27, 2022
Merged
Changes from 4 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
11dcbd4
Replace internal usages of 'master' terminology in server/src/main di…
e94fc0a
Restore rename DISCOVERED_MASTER in ClusterHealthResponse
89ad4b9
Rename two methods in unit tests
eec54ae
Merge branch 'main' into replace-master-int-server-main
74a83e9
Merge branch 'main' into replace-master-int-server-main
a88ea40
Replace master word in ClusterState
2ed3d2f
Replace master word in LeaderChecker JoinHelper JoinTaskExecutor
58a8712
Replace master word in more classes
c20658d
Replace master word in more classes
ef76d02
Replace master word in more classes
5447a72
Replace master word in more classes
6636663
Replace master word in more classes
8f27cf7
Replace master word in more classes
32534b8
Replace master word in DiscoveryNodes classes
d5660fd
Replace master word in more classes
e6c10f2
Correct mistakes
be0acc3
Merge remote-tracking branch 'upstream/main' into replace-master-int-…
0c110ca
Adjust format by spotlessApply task
4d50c6f
Change MASTER__NODE_BOOTSTRAPPED_MSG in test
cc57d7e
Fix SnapshotDisruptionIT by renaming to cluster-manager
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -201,10 +201,10 @@ protected void doStart(ClusterState clusterState) { | |
logger.debug("no known master node, scheduling a retry"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch! Thank you, you are so carefully. Those usages are all missed... 😅 |
||
retryOnMasterChange(clusterState, null); | ||
} else { | ||
DiscoveryNode masterNode = nodes.getMasterNode(); | ||
final String actionName = getMasterActionName(masterNode); | ||
DiscoveryNode clusterManagerNode = nodes.getMasterNode(); | ||
final String actionName = getMasterActionName(clusterManagerNode); | ||
transportService.sendRequest( | ||
masterNode, | ||
clusterManagerNode, | ||
actionName, | ||
request, | ||
new ActionListenerResponseHandler<Response>(listener, TransportMasterNodeAction.this::read) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the
getMasterNodeId
below in line 130 need to be changed togetClusterManagerNodeId
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @xuezhou25 , thanks a lot for your time in reviewing my PR! 👍👍.
the method
getMasterNodeId()
in line 130 is published to Maven as Java API. Please see my comment above: #2519 (comment).Although the normal way to rename the Java API is to deprecate old method and create new alternative method, there are too many public methods contain name "master", and it will introduce too many extra codes to deprecate them all. So I plan to rename them all in a future major version, and give the other plugins and clients enough notice before renaming.