-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced "master" terminology in Log message #2575
Replaced "master" terminology in Log message #2575
Conversation
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
start gradle check |
start gradle check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we skipping the comments as well? I'm seeing the use of master-eligible
terminology in comments in AddVotingConfigExclusionsRequest.java, for example (line 57, 69, 78)
Maybe we can clean that here as well?
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changed the log message to cluster-manager from master Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> (cherry picked from commit cc0e66b)
Changed the log message to cluster-manager from master Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> (cherry picked from commit cc0e66b)
Description
Replace "master" terminology in Log messages.
Issues Resolved
#2539
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.