Gradle custom java zippublish plugin #2988

prudhvigodithi · 2022-04-19T22:56:38Z

Description

This change will add custom zippublish plugin, that can publish plugin zips to maven repo.

Issues Resolved

opensearch-project/opensearch-build#1916

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com>

opensearch-ci-bot · 2022-04-19T23:05:40Z

❌ Gradle Check failure 5bd117f950a0e5a2e5c56e39fe37d01f5079fb89
Log 4627

Reports 4627

opensearch-ci-bot · 2022-04-19T23:10:31Z

❌ Gradle Check failure d60eafe
Log 4628

Reports 4628

peterzhuamazon · 2022-04-19T23:39:08Z

buildSrc/src/main/java/org/opensearch/gradle/PublishPlugin.java

-            if (project.getPluginManager().hasPlugin("opensearch.java")) {
-                publication.artifact(project.getTasks().getByName("sourcesJar"));
-                publication.artifact(project.getTasks().getByName("javadocJar"));
+            String search  = "zip";


Hi @prudhvigodithi,

A bit confused.

Can we have a better naming for this var?
search does not tell me anything on it.

And the logic seems to find whether these is any zips, before attempting the publish of java later.

Thanks.

Hi @peterzhuamazon
Fixed some access modifiers and var strings in my latest commit.

Signed-off-by: pgodithi <pgodithi@amazon.com>

opensearch-ci-bot · 2022-04-20T13:37:03Z

❌ Gradle Check failure 4a61852
Log 4637

Reports 4637

Signed-off-by: pgodithi <pgodithi@amazon.com>

opensearch-ci-bot · 2022-04-20T14:19:11Z

✅ Gradle Check success 1e8c5f1
Log 4639

Reports 4639

opensearch-ci-bot · 2022-04-20T14:46:03Z

✅ Gradle Check success 5e87cde
Log 4640

Reports 4640

Signed-off-by: pgodithi <pgodithi@amazon.com>

opensearch-ci-bot · 2022-04-20T18:44:57Z

❌ Gradle Check failure 770c886
Log 4644

Reports 4644

Signed-off-by: pgodithi <pgodithi@amazon.com>

opensearch-ci-bot · 2022-04-20T19:31:24Z

✅ Gradle Check success a8647ec
Log 4645

Reports 4645

dblock · 2022-04-20T21:05:14Z

Will gladly review once you think this is ready!

prudhvigodithi · 2022-04-21T00:49:19Z

Thanks @dblock ,
the reason I still left as draft is, I still dont see the plugin gets added to local maven repo (using build tools) during runtime so that downstream components can use it while the plugin is applied as apply plugin: 'opensearch.zippublish'
However when I add the plugin manually to local maven repo then it gets picked when apply plugin is added.
So just looking for some suggestions if anything I have missed. Just to summarize the plugin functionality works fine as expected, just the pending part is how to integrate with the existing custom plugin setup, so that even this is added to local maven repo during runtime and each component can then use it.
@saratvemulapalli @bbarani

Signed-off-by: pgodithi <pgodithi@amazon.com>

opensearch-ci-bot · 2022-04-21T13:47:17Z

❌ Gradle Check failure 0865be2
Log 4674

Reports 4674

Signed-off-by: pgodithi <pgodithi@amazon.com>

opensearch-ci-bot · 2022-04-21T14:32:42Z

✅ Gradle Check success be37b91
Log 4675

Reports 4675

Signed-off-by: pgodithi <pgodithi@amazon.com>

opensearch-ci-bot · 2022-04-21T18:40:05Z

❌ Gradle Check failure 8a7c18e
Log 4687

Reports 4687

Signed-off-by: pgodithi <pgodithi@amazon.com>

opensearch-ci-bot · 2022-04-21T19:59:14Z

✅ Gradle Check success a43e651
Log 4689

Reports 4689

dblock

Something looks odd about introducing a second kind of publication while that wasn't the case for bin or source JARs.

buildSrc/src/main/groovy/org/opensearch/gradle/test/TestWithSslPlugin.java

buildSrc/src/main/java/org/opensearch/gradle/PublishPlugin.java

buildSrc/src/main/java/org/opensearch/gradle/zipplugin/ZipPublish.java

Signed-off-by: pgodithi <pgodithi@amazon.com>

dblock · 2022-04-25T18:38:10Z

buildSrc/src/main/java/org/opensearch/gradle/zipplugin/ZipPublish.java

+        Task javaDocJarTask = project.getTasks().findByName("javadocJar");
+        if (javaDocJarTask != null) {
+            javaDocJarTask.setEnabled(false);
+        }


I don't see this change here, am I missing something?

Signed-off-by: pgodithi <pgodithi@amazon.com>

prudhvigodithi · 2022-04-26T03:39:36Z

Hey @reta and @dblock I have done some code cleanup as per feedback and modified the following.

Removed the entire extension file, as this only used to fetch the zip's groupID, since its fixed as org.opensearch.plugin, I have hardcoded it, which makes the extensions file not required anymore.
Edited the existing PublishPlugin, to skip if the publication that has name zip in it.
Added proper unit tests, that covers edge cased related to maven zip publish.
Tested with job-scheduler, alerting and anomaly-detection plugin, able to get the zips published excluding the sourceJar and javadocJar only for this zip publication.

@bbarani

opensearch-ci-bot · 2022-04-26T04:03:14Z

✅ Gradle Check success 9b1cb92
Log 4795

Reports 4795

opensearch-ci-bot · 2022-04-26T04:11:18Z

✅ Gradle Check success c866641
Log 4796

Reports 4796

dblock

I am good with these changes if @reta is good with this. I don't see any problems. Good job on the tests, too.

I do want to discuss naming one more time, once we merge this it will be difficult to rename all over the place. The proposed publishMavenzipPublicationToZipstagingRepository does not match the current pattern.

These are the current publish tasks:

publish - Publishes all publications produced by this project.
publishAllPublicationsToSnapshotsRepository - Publishes all Maven publications produced by this project to the Snapshots repository.
publishAllPublicationsToTestRepository - Publishes all Maven publications produced by this project to the test repository.
publishNebulaPublicationToMavenLocal - Publishes Maven publication 'nebula' to the local Maven repository.
publishNebulaPublicationToSnapshotsRepository - Publishes Maven publication 'nebula' to Maven repository 'Snapshots'.
publishNebulaPublicationToTestRepository - Publishes Maven publication 'nebula' to Maven repository 'test'.
publishPluginMavenPublicationToMavenLocal - Publishes Maven publication 'pluginMaven' to the local Maven repository.
publishPluginMavenPublicationToSnapshotsRepository - Publishes Maven publication 'pluginMaven' to Maven repository 'Snapshots'.
publishPluginMavenPublicationToTestRepository - Publishes Maven publication 'pluginMaven' to Maven repository 'test'.
publishShadowPublicationToMavenLocal - Publishes Maven publication 'shadow' to the local Maven repository.
publishShadowPublicationToSnapshotsRepository - Publishes Maven publication 'shadow' to Maven repository 'Snapshots'.
publishShadowPublicationToTestRepository - Publishes Maven publication 'shadow' to Maven repository 'test'.
publishToMavenLocal - Publishes all Maven publications produced by this project to the local Maven cache.

I think what would make sense given this pattern is publishPluginZipPublicationTo* or publishZipPublicationTo*, because:

We are not publishing a maven zip, we're publishing the plugin zip.
CamelCase should match.

Similarly, the name of the plugin org.opensearch.gradle.zipplugin.ZipPublish would then be org.opensearch.gradle.pluginzip.Publish, no need for a double zip.

@prudhvigodithi WDYT? Possible?

prudhvigodithi · 2022-04-26T13:18:58Z

@prudhvigodithi WDYT? Possible?

yes @dblock possible, but how about the META-INF, is the existing one (opensearch.zippublish) fine ?, users should be able to use this with apply apply plugin: 'opensearch.zippublish'

This would be better too apply plugin: 'opensearch.pluginzip'

Signed-off-by: pgodithi <pgodithi@amazon.com>

prudhvigodithi · 2022-04-26T16:01:08Z

@prudhvigodithi WDYT? Possible?

Hey @dblock just pushed with new naming conventions, the task name will now be publishPluginZipPublicationToZipStagingRepository, the plugin name is opensearch.pluginzip, the implementation class is org.opensearch.gradle.pluginzip.Publish
Now once the plugin is applied apply plugin: 'opensearch.pluginzip', get tasks should list the task as publishPluginZipPublicationToZipStagingRepository.

@reta

opensearch-ci-bot · 2022-04-26T16:35:40Z

✅ Gradle Check success cdac61d
Log 4801

Reports 4801

dblock

LGTM, @reta?

This reverts commit d61aa40.

* Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> * fixed failure checks Signed-off-by: pgodithi <pgodithi@amazon.com> * fixed failure checks Signed-off-by: pgodithi <pgodithi@amazon.com> * ref String to null Signed-off-by: pgodithi <pgodithi@amazon.com> * Added gradlePlugin config Signed-off-by: pgodithi <pgodithi@amazon.com> * Added gradlePlugin config Signed-off-by: pgodithi <pgodithi@amazon.com> * Added gradlePlugin config Signed-off-by: pgodithi <pgodithi@amazon.com> * Added zipFilePath injection Signed-off-by: pgodithi <pgodithi@amazon.com> * Added custom plugin eval logic Signed-off-by: pgodithi <pgodithi@amazon.com> * Added system property for version check Signed-off-by: pgodithi <pgodithi@amazon.com> * spotlessApply check Signed-off-by: pgodithi <pgodithi@amazon.com> * Added custom plugin eval logic Signed-off-by: pgodithi <pgodithi@amazon.com> * spotlessJavaCheck fix Signed-off-by: pgodithi <pgodithi@amazon.com> * Reverted back existing publish plugin Signed-off-by: pgodithi <pgodithi@amazon.com> * Added feedback code fix Signed-off-by: pgodithi <pgodithi@amazon.com> * modified BUILD_DISTRIBUTIONS_LOCATION to zipDistributionLocation Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * changed the zip artifcat identify logic Signed-off-by: pgodithi <pgodithi@amazon.com> * Changed the zip file identify logic Signed-off-by: pgodithi <pgodithi@amazon.com> * Changed the zip file identify logic Signed-off-by: pgodithi <pgodithi@amazon.com> * Changed the zip file identify logic Signed-off-by: pgodithi <pgodithi@amazon.com> * Changed the zip file identify logic Signed-off-by: pgodithi <pgodithi@amazon.com> * Changed the zip file identify logic Signed-off-by: pgodithi <pgodithi@amazon.com> * Changed the zip file identify logic Signed-off-by: pgodithi <pgodithi@amazon.com> * ran spotlessApply Signed-off-by: pgodithi <pgodithi@amazon.com> * ran spotlessApply Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * Code cleanup Signed-off-by: pgodithi <pgodithi@amazon.com> * Code cleanup Signed-off-by: pgodithi <pgodithi@amazon.com> * Code cleanup Signed-off-by: pgodithi <pgodithi@amazon.com> * Code cleanup typos Signed-off-by: pgodithi <pgodithi@amazon.com> * code cleanup and extended unit tests Signed-off-by: pgodithi <pgodithi@amazon.com> * code cleanup and extended unit tests Signed-off-by: pgodithi <pgodithi@amazon.com> * Naming convention fix Signed-off-by: pgodithi <pgodithi@amazon.com> * Naming convention fix Signed-off-by: pgodithi <pgodithi@amazon.com> (cherry picked from commit d61aa40)

dblock · 2022-04-27T13:11:19Z

I didn't pay attention and this got merged onto 2.0, it shouldn't have been as 2.0 is stabilizing for RC1 😢 I won't revert it, but someone tell me if I should.

* Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> Added custom plugin Signed-off-by: pgodithi <pgodithi@amazon.com> * fixed failure checks Signed-off-by: pgodithi <pgodithi@amazon.com> * fixed failure checks Signed-off-by: pgodithi <pgodithi@amazon.com> * ref String to null Signed-off-by: pgodithi <pgodithi@amazon.com> * Added gradlePlugin config Signed-off-by: pgodithi <pgodithi@amazon.com> * Added gradlePlugin config Signed-off-by: pgodithi <pgodithi@amazon.com> * Added gradlePlugin config Signed-off-by: pgodithi <pgodithi@amazon.com> * Added zipFilePath injection Signed-off-by: pgodithi <pgodithi@amazon.com> * Added custom plugin eval logic Signed-off-by: pgodithi <pgodithi@amazon.com> * Added system property for version check Signed-off-by: pgodithi <pgodithi@amazon.com> * spotlessApply check Signed-off-by: pgodithi <pgodithi@amazon.com> * Added custom plugin eval logic Signed-off-by: pgodithi <pgodithi@amazon.com> * spotlessJavaCheck fix Signed-off-by: pgodithi <pgodithi@amazon.com> * Reverted back existing publish plugin Signed-off-by: pgodithi <pgodithi@amazon.com> * Added feedback code fix Signed-off-by: pgodithi <pgodithi@amazon.com> * modified BUILD_DISTRIBUTIONS_LOCATION to zipDistributionLocation Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * changed the zip artifcat identify logic Signed-off-by: pgodithi <pgodithi@amazon.com> * Changed the zip file identify logic Signed-off-by: pgodithi <pgodithi@amazon.com> * Changed the zip file identify logic Signed-off-by: pgodithi <pgodithi@amazon.com> * Changed the zip file identify logic Signed-off-by: pgodithi <pgodithi@amazon.com> * Changed the zip file identify logic Signed-off-by: pgodithi <pgodithi@amazon.com> * Changed the zip file identify logic Signed-off-by: pgodithi <pgodithi@amazon.com> * Changed the zip file identify logic Signed-off-by: pgodithi <pgodithi@amazon.com> * ran spotlessApply Signed-off-by: pgodithi <pgodithi@amazon.com> * ran spotlessApply Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * fix lint issues Signed-off-by: pgodithi <pgodithi@amazon.com> * Code cleanup Signed-off-by: pgodithi <pgodithi@amazon.com> * Code cleanup Signed-off-by: pgodithi <pgodithi@amazon.com> * Code cleanup Signed-off-by: pgodithi <pgodithi@amazon.com> * Code cleanup typos Signed-off-by: pgodithi <pgodithi@amazon.com> * code cleanup and extended unit tests Signed-off-by: pgodithi <pgodithi@amazon.com> * code cleanup and extended unit tests Signed-off-by: pgodithi <pgodithi@amazon.com> * Naming convention fix Signed-off-by: pgodithi <pgodithi@amazon.com> * Naming convention fix Signed-off-by: pgodithi <pgodithi@amazon.com> (cherry picked from commit d61aa40)

prudhvigodithi · 2022-04-27T16:05:26Z

Created Manual Backport PR's
Backport to main: PR
Backport to 2.x: PR

prudhvigodithi changed the title ~~Gradleplugin 2.0~~ Gradle custom zippublish plugin Apr 19, 2022

prudhvigodithi changed the title ~~Gradle custom zippublish plugin~~ Gradle custom java zippublish plugin Apr 19, 2022

peterzhuamazon reviewed Apr 19, 2022

View reviewed changes

prudhvigodithi added 2 commits April 20, 2022 06:05

fixed failure checks

4a61852

Signed-off-by: pgodithi <pgodithi@amazon.com>

fixed failure checks

1e8c5f1

Signed-off-by: pgodithi <pgodithi@amazon.com>

ref String to null

5e87cde

Signed-off-by: pgodithi <pgodithi@amazon.com>

Added gradlePlugin config

770c886

Signed-off-by: pgodithi <pgodithi@amazon.com>

prudhvigodithi added 2 commits April 20, 2022 11:50

Added gradlePlugin config

342bc64

Signed-off-by: pgodithi <pgodithi@amazon.com>

Added gradlePlugin config

a8647ec

Signed-off-by: pgodithi <pgodithi@amazon.com>

dblock mentioned this pull request Apr 20, 2022

[Meta] Mechanism to publish the plugin zips to maven repo. opensearch-project/opensearch-build#1916

Closed

38 tasks

Added zipFilePath injection

0865be2

Signed-off-by: pgodithi <pgodithi@amazon.com>

Added custom plugin eval logic

be37b91

Signed-off-by: pgodithi <pgodithi@amazon.com>

Added system property for version check

8a7c18e

Signed-off-by: pgodithi <pgodithi@amazon.com>

spotlessApply check

a43e651

Signed-off-by: pgodithi <pgodithi@amazon.com>

dblock requested changes Apr 21, 2022

View reviewed changes

Added custom plugin eval logic

a523ab1

Signed-off-by: pgodithi <pgodithi@amazon.com>

dblock requested changes Apr 25, 2022

View reviewed changes

prudhvigodithi added 2 commits April 25, 2022 20:23

code cleanup and extended unit tests

9b1cb92

Signed-off-by: pgodithi <pgodithi@amazon.com>

code cleanup and extended unit tests

c866641

Signed-off-by: pgodithi <pgodithi@amazon.com>

dblock reviewed Apr 26, 2022

View reviewed changes

prudhvigodithi added 2 commits April 26, 2022 08:55

Naming convention fix

9f32f4d

Signed-off-by: pgodithi <pgodithi@amazon.com>

Naming convention fix

cdac61d

Signed-off-by: pgodithi <pgodithi@amazon.com>

dblock approved these changes Apr 26, 2022

View reviewed changes

dblock requested a review from reta April 26, 2022 21:02

reta approved these changes Apr 27, 2022

View reviewed changes

dblock merged commit d61aa40 into opensearch-project:2.0 Apr 27, 2022

dblock added the backport 2.x Backport to 2.x branch label Apr 27, 2022

dblock added a commit that referenced this pull request Apr 27, 2022

Revert "Gradle custom java zippublish plugin (#2988)"

b67594b

This reverts commit d61aa40.

opensearch-trigger-bot bot mentioned this pull request Apr 27, 2022

[Backport 2.x] Gradle custom java zippublish plugin #3091

Closed

dblock added the backport main label Apr 27, 2022

opensearch-trigger-bot bot mentioned this pull request Apr 27, 2022

[Backport main] Gradle custom java zippublish plugin #3092

Closed

This was referenced Apr 27, 2022

Custom plugin backport to main branch #3095

Merged

Custom plugin backport to 2.x branch #3096

Merged

This was referenced Apr 28, 2022

default build.sh logic add for Gradle custom java zippublish plugin opensearch-project/opensearch-build#1999

Merged

[WIP]Mechanism to push zip plugins. opensearch-project/job-scheduler#167

Closed

prudhvigodithi mentioned this pull request May 5, 2022

Gradle plugin opensearch.pluginzip Add implicit dependency. #3189

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gradle custom java zippublish plugin #2988

Gradle custom java zippublish plugin #2988

prudhvigodithi commented Apr 19, 2022 •

edited

Loading

opensearch-ci-bot commented Apr 19, 2022

opensearch-ci-bot commented Apr 19, 2022

peterzhuamazon Apr 19, 2022

prudhvigodithi Apr 20, 2022 •

edited

Loading

opensearch-ci-bot commented Apr 20, 2022

opensearch-ci-bot commented Apr 20, 2022

opensearch-ci-bot commented Apr 20, 2022

opensearch-ci-bot commented Apr 20, 2022

opensearch-ci-bot commented Apr 20, 2022

dblock commented Apr 20, 2022

prudhvigodithi commented Apr 21, 2022 •

edited

Loading

opensearch-ci-bot commented Apr 21, 2022

opensearch-ci-bot commented Apr 21, 2022

opensearch-ci-bot commented Apr 21, 2022

opensearch-ci-bot commented Apr 21, 2022

dblock left a comment

dblock Apr 25, 2022

prudhvigodithi commented Apr 26, 2022 •

edited

Loading

opensearch-ci-bot commented Apr 26, 2022

opensearch-ci-bot commented Apr 26, 2022

dblock left a comment

prudhvigodithi commented Apr 26, 2022 •

edited

Loading

prudhvigodithi commented Apr 26, 2022 •

edited

Loading

opensearch-ci-bot commented Apr 26, 2022

dblock left a comment

dblock commented Apr 27, 2022 •

edited

Loading

prudhvigodithi commented Apr 27, 2022

Gradle custom java zippublish plugin #2988

Gradle custom java zippublish plugin #2988

Conversation

prudhvigodithi commented Apr 19, 2022 • edited Loading

Description

Issues Resolved

Check List

opensearch-ci-bot commented Apr 19, 2022

opensearch-ci-bot commented Apr 19, 2022

peterzhuamazon Apr 19, 2022

Choose a reason for hiding this comment

prudhvigodithi Apr 20, 2022 • edited Loading

Choose a reason for hiding this comment

opensearch-ci-bot commented Apr 20, 2022

opensearch-ci-bot commented Apr 20, 2022

opensearch-ci-bot commented Apr 20, 2022

opensearch-ci-bot commented Apr 20, 2022

opensearch-ci-bot commented Apr 20, 2022

dblock commented Apr 20, 2022

prudhvigodithi commented Apr 21, 2022 • edited Loading

opensearch-ci-bot commented Apr 21, 2022

opensearch-ci-bot commented Apr 21, 2022

opensearch-ci-bot commented Apr 21, 2022

opensearch-ci-bot commented Apr 21, 2022

dblock left a comment

Choose a reason for hiding this comment

dblock Apr 25, 2022

Choose a reason for hiding this comment

prudhvigodithi commented Apr 26, 2022 • edited Loading

opensearch-ci-bot commented Apr 26, 2022

opensearch-ci-bot commented Apr 26, 2022

dblock left a comment

Choose a reason for hiding this comment

prudhvigodithi commented Apr 26, 2022 • edited Loading

prudhvigodithi commented Apr 26, 2022 • edited Loading

opensearch-ci-bot commented Apr 26, 2022

dblock left a comment

Choose a reason for hiding this comment

dblock commented Apr 27, 2022 • edited Loading

prudhvigodithi commented Apr 27, 2022

prudhvigodithi commented Apr 19, 2022 •

edited

Loading

prudhvigodithi Apr 20, 2022 •

edited

Loading

prudhvigodithi commented Apr 21, 2022 •

edited

Loading

prudhvigodithi commented Apr 26, 2022 •

edited

Loading

prudhvigodithi commented Apr 26, 2022 •

edited

Loading

prudhvigodithi commented Apr 26, 2022 •

edited

Loading

dblock commented Apr 27, 2022 •

edited

Loading