[Backport 2.x] Support task resource tracking in OpenSearch #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add Task id in Thread Context Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Add resource tracking update support for tasks Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * List tasks action support for task resource refresh Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Handle task unregistration case on same thread Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Add lazy initialisation for RunnableTaskExecutionListener Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Segregate resource tracking logic to a separate service. Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Check for running threads during task unregister Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Moved thread context logic to resource tracking service Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * preserve task id in thread context even after stash Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Add null check for resource tracking service Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Tracking service tests and minor refactoring Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Preserve task id fix with test Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Minor test changes and Task tracking call update Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Fix Auto Queue executor method's signature Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Make task runnable task listener factory implement consumer Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Use reflection for ThreadMXBean Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Formatting Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Replace RunnableTaskExecutionListenerFactory with AtomicReference Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Revert "Use reflection for ThreadMXBean" This reverts commit cbcf3c525bf516fb7164f0221491a7b25c1f96ec. Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Suppress Warning related to ThreadMXBean Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Add separate method for task resource tracking supported check Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Enabled setting by default Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Add debug logs for stale context id Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Remove hardcoded task overhead in tests Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Bump stale task id in thread context log level to warn Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> * Improve assertions and logging Signed-off-by: Tushar Kharbanda <tushar.kharbanda72@gmail.com> Co-authored-by: Tushar Kharbanda <tkharban@amazon.com> (cherry picked from commit 6517eec)
|
@tushar-kharbanda72 Care to take a look at the failure please? |
dblock
requested changes
Apr 22, 2022
There was a problem hiding this comment.
PR introduces CI failures, is being reverted in #3046, cc: @tushar-kharbanda72
|
@tushar-kharbanda72 Can you please address the comments? |
|
@tushar-kharbanda72 are you still aiming to have this backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6517eec from #2639