Rename package 'o.o.action.support.master' to 'o.o.action.support.clustermanager'

[tlfeng]

Description

Replace master terminology by cluster manager in the public Java APIs to support inclusive language.
The PR deal with the only package name in the repository.

• Rename package org.opensearch.action.support.master to org.opensearch.action.support.clustermanager.
• Replace Master to ClusterManager for all the classes in the package, including all the references to the classes.

The above changes are done by the Rename refactoring feature of IntelliJ IDEA, so that both the definition and reference can be renamed.

For an easier review, the change of class definition in the above package is starting with the file AcknowledgedRequest.java, which is located at https://github.com/opensearch-project/OpenSearch/pull/3556/files#diff-2cc8ed7ea18e1fe657578d25badfb9b858659971c84c5f4f6e74f481098b82a1 in the file change list. The other changes are most of the references of the renamed classes.

To keep the git history of the files with name master in the new files with name cluster manager, I have to put renaming and deprecating classes in 2 separate Pull Requests, and then the 2 PRs will result 2 separate git commits after PR merged.

The next PR will be like: tlfeng@e484e0f
Add the old master usage back, and deprecate them.

Issues Resolved

The first PR for issue #3542 .
The issue will be resolved by following 2 PRs: deprecate the classes with and deprecate methods/variables that contains "master" in the names.

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[opensearch-ci-bot]

❌   Gradle Check failure 455f3ea
Log 5890

Reports 5890

[opensearch-ci-bot]

❌   Gradle Check failure b5907e3
Log 5958

Reports 5958

[opensearch-ci-bot]

❌   Gradle Check failure a7694d8
Log 5959

Reports 5959

[tlfeng]

In log 5958:

> Task :server:internalClusterTest

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testHighWatermarkNotExceeded" -Dtests.seed=8717BDA4121AAE4E -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=en-CA -Dtests.timezone=Africa/Addis_Ababa -Druntime.java=17

org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT > testHighWatermarkNotExceeded FAILED
    java.lang.AssertionError: Mismatching shard routings: []
    Expected: a collection with size <1>
         but: collection size was <0>
        at __randomizedtesting.SeedInfo.seed([8717BDA4121AAE4E:6E365C1692DC67A0]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.lambda$assertBusyWithDiskUsageRefresh$5(DiskThresholdDeciderIT.java:362)
        at org.opensearch.test.OpenSearchTestCase.assertBusy(OpenSearchTestCase.java:1049)
        at org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.assertBusyWithDiskUsageRefresh(DiskThresholdDeciderIT.java:355)
        at org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testHighWatermarkNotExceeded(DiskThresholdDeciderIT.java:188)

In log 5959:
The same test failure

> Task :server:internalClusterTest

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testHighWatermarkNotExceeded" -Dtests.seed=3D6C62AF22C0F847 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sr-RS -Dtests.timezone=Pacific/Majuro -Druntime.java=17
...

It's reproducible on main branch, and tracked in issue #3584

[opensearch-ci-bot]

❌   Gradle Check failure 9fd5a4d
Log 5972

Reports 5972

[tlfeng]

In log 5972:

REPRODUCE WITH: ./gradlew ':qa:remote-clusters:integTest' --tests "org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks" -Dtests.seed=8A253528956BADE8 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=hi -Dtests.timezone=America/Virgin -Druntime.java=17
WARNING: System::setSecurityManager has been called by org.gradle.api.internal.tasks.testing.worker.TestWorker (file:/home/ubuntu/.gradle/wrapper/dists/gradle-7.4.2-all/9uukhhbclvbegdvsww0j0cr3p/gradle-7.4.2/lib/plugins/gradle-testing-base-7.4.2.jar)
WARNING: Please consider reporting this to the maintainers of org.gradle.api.internal.tasks.testing.worker.TestWorker
WARNING: System::setSecurityManager will be removed in a future release

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([8A253528956BADE8:8D53E0E3AEEDDBB5]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)

It's reported in issue #1703

[opensearch-ci-bot]

❌   Gradle Check failure 3844ca2
Log 5989

Reports 5989

[tlfeng]

In log 5989:

> Task :server:missingJavadoc FAILED
javadoc: error - org.opensearch.action.support.clustermanager (package): javadocs are missing
javadoc: error - org.opensearch.action.support.clustermanager.info (package): javadocs are missing
2 errors

[reta]

@tlfeng this is good but breaking change, we probably should not target 2.1.0 but 3.0.0 only, wdyt?

[opensearch-ci-bot]

❌   Gradle Check failure 1b6ab60
Log 5994

Reports 5994

[tlfeng]

In log 5994:

org.opensearch.lucene.index.ShuffleForcedMergePolicyTests > testDiagnostics FAILED
    java.lang.AssertionError: 
    Expected: a value greater than <2>
         but: <2> was equal to <2>
        at __randomizedtesting.SeedInfo.seed([1161A2BF9C23F5EE:241F7C459E731AC7]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.junit.Assert.assertThat(Assert.java:930)
        at org.opensearch.lucene.index.ShuffleForcedMergePolicyTests.testDiagnostics(ShuffleForcedMergePolicyTests.java:81)

  2> NOTE: reproduce with: gradlew test --tests ShuffleForcedMergePolicyTests.testDiagnostics -Dtests.seed=1161A2BF9C23F5EE -Dtests.badapples=true -Dtests.locale=sk -Dtests.timezone=America/Lower_Princes -Dtests.asserts=true -Dtests.file.encoding=UTF-8

[tlfeng]

@reta Thank your for the review.
My plan is to support the public Java classes/method in both new name "cluster manager" and old name "master" in version 2.1 . Finally the change is backwards compatible, not a traditional breaking change.
However there will be 2 Pull Requests to achieve the compatibility:

1. Rename the definition and all reference to the public classes or methods, from "master" to "cluster manager"
2. Add the "master" usages back, let the "master" class extends "cluster manager" class, and mark it deprecated.

To keep the git history of the files with name master in the new files with name cluster manager, I have to put renaming and deprecating classes in 2 separate Pull Requests, and then the 2 PRs will result 2 separate git commits after PR merged.

Having 2 PRs will have a sense of separation, but this is the only way to keep the git history in the class with new name, while deprecating the class with old name. I will try to merge the 2 PRs in one day, so that won't affect the compatibility in any snapshot builds.

The next PR will be like: tlfeng@e484e0f
Add the old master usage back, and deprecate them.

[tlfeng]

Haven't seen any test failure in my local ./gradlew check run, so re-trigger the check. start gradle check

[opensearch-ci-bot]

✅   Gradle Check success 1b6ab60
Log 6013

Reports 6013

[reta]

The next PR will be like: tlfeng@e484e0f
Add the old master usage back, and deprecate them.

Got it, thanks @tlfeng, it makes sense !

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3556-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e7679240e0524316d03387dcb8a35166232fd971
# Push it to GitHub
git push --set-upstream origin backport/backport-3556-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3556-to-2.x.

[tlfeng]

@reta Thank you so much for reviewing the huge code change! I planned to rely on my colleagues to review it, but you gave me a big surprise!