Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] server/test/o.e.common #356

Merged

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Mar 17, 2021

This PR refactors all classes in the server/test/o.e.common package to the
o.opensearch namespace. All references throughout the codebase have also been
refactored.

relates #160

@nknize nknize added >FORK Related to the fork process Rename Renaming to OpenSearch labels Mar 17, 2021
@odfe-release-bot
Copy link

✅   DCO Check Passed

@adnapibar adnapibar self-assigned this Mar 17, 2021
@odfe-release-bot
Copy link

✅   DCO Check Passed

Copy link
Contributor

@adnapibar adnapibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 just some minor things I noticed.

@@ -7,7 +7,7 @@
* not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
* http://www.apache.org/licenses/LICENSE-2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this always gets added whenever a file is renamed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's odd but it looks like whitespace is ignored for me at merge time.

nknize added 3 commits March 17, 2021 15:40
This commit refactors all classes in the server/test/o.e.common package to the
o.opensearch namespace. All references throughout the codebase have also been
refactored.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize force-pushed the rename/server/test/common branch from 7412abf to 97a8ef5 Compare March 17, 2021 20:47
@nknize nknize requested a review from adnapibar March 17, 2021 20:47
@odfe-release-bot
Copy link

✅   DCO Check Passed

Copy link
Contributor

@adnapibar adnapibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nknize nknize merged commit bbf7274 into opensearch-project:rename/opensearch Mar 17, 2021
nknize added a commit that referenced this pull request Mar 20, 2021
This commit refactors all classes in the server/test/o.e.common package to the
o.opensearch namespace. All references throughout the codebase have also been
refactored.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize added a commit that referenced this pull request Mar 22, 2021
This commit refactors all classes in the server/test/o.e.common package to the
o.opensearch namespace. All references throughout the codebase have also been
refactored.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>FORK Related to the fork process Rename Renaming to OpenSearch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants