-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] server/test/o.e.common #356
[Rename] server/test/o.e.common #356
Conversation
✅ DCO Check Passed |
✅ DCO Check Passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 just some minor things I noticed.
@@ -7,7 +7,7 @@ | |||
* not use this file except in compliance with the License. | |||
* You may obtain a copy of the License at | |||
* | |||
* http://www.apache.org/licenses/LICENSE-2.0 | |||
* http://www.apache.org/licenses/LICENSE-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: this always gets added whenever a file is renamed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it's odd but it looks like whitespace is ignored for me at merge time.
server/src/test/java/org/opensearch/common/lucene/index/ESDirectoryReaderTests.java
Show resolved
Hide resolved
server/src/test/java/org/opensearch/common/util/concurrent/EsExecutorsTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/common/util/concurrent/EsThreadPoolExecutorTests.java
Outdated
Show resolved
Hide resolved
.../test/java/org/opensearch/common/util/concurrent/QueueResizingEsThreadPoolExecutorTests.java
Outdated
Show resolved
Hide resolved
This commit refactors all classes in the server/test/o.e.common package to the o.opensearch namespace. All references throughout the codebase have also been refactored. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
7412abf
to
97a8ef5
Compare
✅ DCO Check Passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This commit refactors all classes in the server/test/o.e.common package to the o.opensearch namespace. All references throughout the codebase have also been refactored. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
This commit refactors all classes in the server/test/o.e.common package to the o.opensearch namespace. All references throughout the codebase have also been refactored. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
This PR refactors all classes in the server/test/o.e.common package to the
o.opensearch namespace. All references throughout the codebase have also been
refactored.
relates #160