Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [BUG] opensearch crashes on closed client connection before search reply #3645

Merged
merged 1 commit into from
Jun 22, 2022
Merged

[Backport 2.x] [BUG] opensearch crashes on closed client connection before search reply #3645

merged 1 commit into from
Jun 22, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3dba46e from #3626

@reta @github-actions
[BUG] opensearch crashes on closed client connection before search re…
9b4907f 
…ply (#3626)

* [BUG] opensearch crashes on closed client connection before search reply

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Addressing code review comments

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 3dba46e)
@opensearch-trigger-bot opensearch-trigger-bot bot requested review from a team and reta as code owners June 22, 2022 04:26
@tlfeng tlfeng added bug Something isn't working backport PRs or issues specific to backporting features or enhancments v2.1.0 Issues and PRs related to version 2.1.0 labels Jun 22, 2022
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 9b4907f
Log 6203

Reports 6203

@tlfeng
Copy link
Collaborator

tlfeng commented Jun 22, 2022 •
edited
Loading

In log 6203:
It's reported in issue #3603

> Task :server:internalClusterTest

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness" -Dtests.seed=2FC9EEA0E1D7A300 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=en-US -Dtests.timezone=US/Pacific -Druntime.java=17

org.opensearch.cluster.allocation.AwarenessAllocationIT > testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness FAILED
    java.lang.AssertionError: unexpected
        at org.opensearch.test.InternalTestCluster.removeExclusions(InternalTestCluster.java:1912)
        at org.opensearch.test.InternalTestCluster.stopNodesAndClients(InternalTestCluster.java:1777)
        at org.opensearch.test.InternalTestCluster.stopNodesAndClient(InternalTestCluster.java:1764)
        at org.opensearch.test.InternalTestCluster.stopRandomNode(InternalTestCluster.java:1672)
        at org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness(AwarenessAllocationIT.java:425)

        Caused by:
        java.util.concurrent.ExecutionException: MasterNotDiscoveredException[null]
            at org.opensearch.common.util.concurrent.BaseFuture$Sync.getValue(BaseFuture.java:286)
            at org.opensearch.common.util.concurrent.BaseFuture$Sync.get(BaseFuture.java:273)
            at org.opensearch.common.util.concurrent.BaseFuture.get(BaseFuture.java:104)
            at org.opensearch.test.InternalTestCluster.removeExclusions(InternalTestCluster.java:1910)
            ... 4 more

            Caused by:
            MasterNotDiscoveredException[null]
                at app//org.opensearch.action.support.clustermanager.TransportClusterManagerNodeAction$AsyncSingleAction$2.onTimeout(TransportClusterManagerNodeAction.java:282)
...

@tlfeng
Copy link
Collaborator

tlfeng commented Jun 22, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 9b4907f
Log 6205

Reports 6205

@reta reta merged commit 4f340b3 into 2.x Jun 22, 2022
@github-actions github-actions bot deleted the backport/backport-3626-to-2.x branch June 22, 2022 11:39
reta added a commit to reta/OpenSearch that referenced this pull request Jun 22, 2022
@opensearch-trigger-bot @reta
[BUG] opensearch crashes on closed client connection before search re…
3a9e677 
…ply (opensearch-project#3626) (opensearch-project#3645)

* [BUG] opensearch crashes on closed client connection before search reply

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Addressing code review comments

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 3dba46e)

Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Jun 22, 2022
@opensearch-trigger-bot @reta
[BUG] opensearch crashes on closed client connection before search re…
2897a6c 
…ply (opensearch-project#3626) (opensearch-project#3645)

* [BUG] opensearch crashes on closed client connection before search reply

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Addressing code review comments

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 3dba46e)

Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Jun 22, 2022
@opensearch-trigger-bot @reta
[BUG] opensearch crashes on closed client connection before search re…
b77e89d 
…ply (opensearch-project#3626) (opensearch-project#3645)

* [BUG] opensearch crashes on closed client connection before search reply

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Addressing code review comments

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 3dba46e)

Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
kartg pushed a commit that referenced this pull request Jun 22, 2022
@reta @opensearch-trigger-bot
[BUG] opensearch crashes on closed client connection before search re…
2502198 
…ply (#3626) (#3645) (#3653)

* [BUG] opensearch crashes on closed client connection before search reply

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Addressing code review comments

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 3dba46e)

Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
kartg pushed a commit that referenced this pull request Jun 22, 2022
@reta @opensearch-trigger-bot
[BUG] opensearch crashes on closed client connection before search re…
9e98622 
…ply (#3626) (#3645) (#3654)

* [BUG] opensearch crashes on closed client connection before search reply

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Addressing code review comments

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 3dba46e)

Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
kartg pushed a commit that referenced this pull request Jun 22, 2022
@reta @opensearch-trigger-bot
[BUG] opensearch crashes on closed client connection before search re…
d57e8f0 
…ply (#3626) (#3645) (#3655)

* [BUG] opensearch crashes on closed client connection before search reply

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Addressing code review comments

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 3dba46e)

Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

Assignees
No one assigned
Labels
backport PRs or issues specific to backporting features or enhancments bug Something isn't working v2.1.0 Issues and PRs related to version 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@opensearch-ci-bot @tlfeng @reta