Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Revert renaming masterOperation() to clusterManagerOperation() #3714

Merged
merged 1 commit into from
Jun 27, 2022
Merged

[Backport 2.x] Revert renaming masterOperation() to clusterManagerOperation() #3714

merged 1 commit into from
Jun 27, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport f8aa20a from #3681

@github-actions
Revert renaming masterOperation() to clusterManagerOperation() (#3681)
65901a8 
Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit f8aa20a)
@opensearch-trigger-bot opensearch-trigger-bot bot requested review from a team and reta as code owners June 27, 2022 16:41
@tlfeng tlfeng added bug Something isn't working backport PRs or issues specific to backporting features or enhancments backwards-compatibility v2.1.0 Issues and PRs related to version 2.1.0 labels Jun 27, 2022
@tlfeng tlfeng mentioned this pull request Jun 27, 2022
Closed
@tlfeng tlfeng added v2.2.0 and removed v2.1.0 Issues and PRs related to version 2.1.0 labels Jun 27, 2022
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 65901a8
Log 6371

Reports 6371

@tlfeng
Copy link
Collaborator

tlfeng commented Jun 27, 2022

In log 6371:

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testHighWatermarkNotExceeded" -Dtests.seed=1A652E40ECF2EF83 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ru -Dtests.timezone=Asia/Ashgabat -Druntime.java=17

org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT > testHighWatermarkNotExceeded FAILED
    java.lang.AssertionError: Mismatching shard routings: [[eimxhwqgtn][5], node[qb6znhIbRbu_wwO5fEJ2Pw], [P], s[STARTED], a[id=0JTY_zyvRy-3ddBZO94NOQ]]
    Expected: an empty collection
         but: <[[eimxhwqgtn][5], node[qb6znhIbRbu_wwO5fEJ2Pw], [P], s[STARTED], a[id=0JTY_zyvRy-3ddBZO94NOQ]]>
        at __randomizedtesting.SeedInfo.seed([1A652E40ECF2EF83:F344CFF26C34266D]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.lambda$assertBusyWithDiskUsageRefresh$5(DiskThresholdDeciderIT.java:362)
        at org.opensearch.test.OpenSearchTestCase.assertBusy(OpenSearchTestCase.java:1049)
        at org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.assertBusyWithDiskUsageRefresh(DiskThresholdDeciderIT.java:355)
        at org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testHighWatermarkNotExceeded(DiskThresholdDeciderIT.java:184)

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testHighWatermarkNotExceeded" -Dtests.seed=1A652E40ECF2EF83 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ru -Dtests.timezone=Asia/Ashgabat -Druntime.java=17

org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT > testHighWatermarkNotExceeded FAILED
    java.lang.AssertionError: Mismatching shard routings: []
    Expected: a collection with size <1>
         but: collection size was <0>
        at __randomizedtesting.SeedInfo.seed([1A652E40ECF2EF83:F344CFF26C34266D]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.lambda$assertBusyWithDiskUsageRefresh$5(DiskThresholdDeciderIT.java:362)
        at org.opensearch.test.OpenSearchTestCase.assertBusy(OpenSearchTestCase.java:1049)
        at org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.assertBusyWithDiskUsageRefresh(DiskThresholdDeciderIT.java:355)
        at org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testHighWatermarkNotExceeded(DiskThresholdDeciderIT.java:188)

It's reported in #3579

@tlfeng
Copy link
Collaborator

tlfeng commented Jun 27, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 65901a8
Log 6373

Reports 6373

@tlfeng tlfeng merged commit 26c0b6f into 2.x Jun 27, 2022
@github-actions github-actions bot deleted the backport/backport-3681-to-2.x branch June 27, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlfeng tlfeng tlfeng approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

Assignees
No one assigned
Labels
backport PRs or issues specific to backporting features or enhancments backwards-compatibility bug Something isn't working v2.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@opensearch-ci-bot @tlfeng