Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute testHighWatermarkNotExceeded #3844

Conversation

dreamer-89
Copy link
Member

Signed-off-by: Suraj Singh surajrider@gmail.com

Description

testHighWatermarkNotExceeded is failing with > 50% failure rate. There is already a fix in place, muting till the fix is merged.

Related
#3579

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Suraj Singh <surajrider@gmail.com>
@dreamer-89 dreamer-89 requested review from a team and reta as code owners July 11, 2022 16:03
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@peterzhuamazon
Copy link
Member

Hi @dreamer-89 if the fix is already prepare for review, would it be better to just speed up the fix review?
I feel like muting this test is not the best solution.

Thanks.

@dreamer-89
Copy link
Member Author

Hi @dreamer-89 if the fix is already prepare for review, would it be better to just speed up the fix review? I feel like muting this test is not the best solution.

Thanks.

Yes agree muting is not the correct solution. But, weighing in pain due to gradle check job failure ( > 50%), I think it is fine to mute this test temporarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants