[Segment Replication] Add update doc integ test for Segment replication #4234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...er/src/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationIT.java
Show resolved
Hide resolved
...er/src/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationIT.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Suraj Singh <surajrider@gmail.com>
dreamer-89
force-pushed
the
add_segment_replication_updates_tests
branch
from
1429d76
to
516f4d1
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #4234 +/- ##
============================================
- Coverage 70.78% 70.72% -0.07%
+ Complexity 57218 57169 -49
============================================
Files 4605 4606 +1
Lines 274695 274706 +11
Branches 40228 40228
============================================
- Hits 194441 194281 -160
- Misses 63955 64132 +177
+ Partials 16299 16293 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nknize
reviewed
Aug 17, 2022
...er/src/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationIT.java
Show resolved
Hide resolved
| import static org.opensearch.test.hamcrest.OpenSearchAssertions.assertHitCount; | ||
| import static org.opensearch.test.hamcrest.OpenSearchAssertions.assertAcked; | ||
| import static org.opensearch.test.hamcrest.OpenSearchAssertions.assertSearchHits; | ||
|
|
||
| @OpenSearchIntegTestCase.ClusterScope(scope = OpenSearchIntegTestCase.Scope.TEST, numDataNodes = 0) | ||
| public class SegmentReplicationIT extends OpenSearchIntegTestCase { |
There was a problem hiding this comment.
Could we just make this extend OpenSearchSingleNodeTestCase?
There was a problem hiding this comment.
Thanks @nknize for the review. There are certain tests in this class which needs multiple nodes (specially failover related), so I think we can not use OpenSearchSingleNodeTestCase class. Please correct me if I am missing something.
Rishikesh1159
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Suraj Singh surajrider@gmail.com
Description
This PR adds update document integration tests in order to verify the fix (#4185) works for update operations.
Verified without fix above, the added update IT fails with below error
Issues Resolved
#3787
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.