Use RemoteSegmentStoreDirectory instead of RemoteDirectory #4240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle Check (Jenkins) Run Completed with:
|
sachinpkale
force-pushed
the
remote_store_refresh_listener
branch
from
d4db37a to
f50de49
Compare
Gradle Check (Jenkins) Run Completed with:
|
|
Checking and fixing the failing tests. |
sachinpkale
force-pushed
the
remote_store_refresh_listener
branch
from
c9fb9b4 to
2e09922
Compare
Gradle Check (Jenkins) Run Completed with:
|
reta
reviewed
Aug 17, 2022
| this.isPrimary = indexShard.shardRouting.primary(); | ||
| if (indexShard.shardRouting.primary()) { | ||
| try { | ||
| this.remoteDirectory.init(); |
There was a problem hiding this comment.
Why do we need to call init() here? RemoteSegmentStoreDirectory is supposed to be already initialized during construction
There was a problem hiding this comment.
Let me think more about it and will provide update on this comment thread.
There was a problem hiding this comment.
@reta You are right. I could not come up with a scenario where this would be required. Removed the code from constructor.
reta
reviewed
Aug 17, 2022
| public void afterRefresh(boolean didRefresh) { | ||
| synchronized (this) { | ||
| try { | ||
| if (indexShard.shardRouting.primary()) { |
There was a problem hiding this comment.
What happens if index shard was demoted to replica from primary? Shouldn't RemoteStoreRefreshListener reflect that? Otherewise we are risking to lose track of shard state when it is flipping between primary <-> replica
There was a problem hiding this comment.
Only primary should be uploading the segments. If replica is demoted, this check makes sure that we stop uploading segments from replica. Ideally, NRTReplicationEngine should take of this. This if condition is added as a safety check.
There was a problem hiding this comment.
So in this case the usage of isPrimary property is not useful since it never reflects the actual state of the shard (if demoted from primary). I think we could drop it than
There was a problem hiding this comment.
If the shard is demoted and promoted again, we need to make sure that we call RemoteSegmentStoreDirectory.init() to get the latest list of files from remote store (because it could be changed by another primary in the meantime).
There was a problem hiding this comment.
Ok, I will try to go step by step by step:
indexShard.shardRouting.primary() == true: ifisPrimarywasfalse, we set it totrueand proceed withinit()- the shard flips from primary to replica,
indexShard.shardRouting.primary() == false, nothing happens toisPrimary, it is still,true(which is wrong) - the shard flips from replica to primary,
indexShard.shardRouting.primary() == trueandisPrimaryis alsotrue- the initialization call toinit()won't happen anymore because the flip to replica was not reflected
Does it make sense?
There was a problem hiding this comment.
Yeah, this is definitely a bug. Thanks for catching it. I will fix it and will add tests around it as you suggested in another comment.
There was a problem hiding this comment.
@reta I changed the implementation and added tests. Please take a look again.
Gradle Check (Jenkins) Run Completed with:
|
reta
reviewed
Aug 17, 2022
| .forEach(localSegmentChecksumMap::remove); | ||
| } | ||
| } | ||
| } catch (EngineException e) { |
There was a problem hiding this comment.
Since we swallow all exceptions, what happens if shard was promoted to primary but segments were not refreshed due to some failures? Should we go back to replica mode? Or should we schedule the retry later on?
There was a problem hiding this comment.
With the current implementation, we retry segment upload in the next refresh.
If the upload fails, we don't want to demote primary as the failure could be due to issues with remote segment store itself.
sachinpkale
force-pushed
the
remote_store_refresh_listener
branch
from
2e09922 to
4b50a1c
Compare
Gradle Check (Jenkins) Run Completed with:
|
sachinpkale
force-pushed
the
remote_store_refresh_listener
branch
from
4b50a1c to
55dd49d
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #4240 +/- ##
============================================
+ Coverage 70.63% 70.76% +0.12%
- Complexity 57120 57269 +149
============================================
Files 4606 4606
Lines 274839 274956 +117
Branches 40241 40256 +15
============================================
+ Hits 194130 194561 +431
+ Misses 64411 64056 -355
- Partials 16298 16339 +41
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
reta
reviewed
Aug 18, 2022
| /** | ||
| * Guaranteed to throw an exception and leave the RemoteIndexInput unmodified. | ||
| * This method is not implemented as it is not used for the file transfer to/from the remote store. | ||
| * | ||
| * @throws UnsupportedOperationException always | ||
| */ | ||
| @Override | ||
| public long getFilePointer() { | ||
| public void seek(long pos) throws IOException { |
There was a problem hiding this comment.
Just curious, why inputStream.skip(pos); was replaced with UnsupportedOperationException ?
There was a problem hiding this comment.
The implementation was incorrect. This was pointed by @andrross earlier. seek() should provide functionality to go to the exact point provided by the pos argument. That means pos could be 0 and it will take you to the beginning of the inputStream. This requires special handling of the state which is not required at least for the V1 of remote store.
reta
reviewed
Aug 18, 2022
| import static org.mockito.Mockito.verify; | ||
| import static org.mockito.Mockito.times; | ||
| import static org.mockito.Mockito.doThrow; | ||
| public class RemoteStoreRefreshListenerTests extends IndexShardTestCase { |
There was a problem hiding this comment.
Could you please add tests for RemoteStoreRefreshListener in case shard flips from primary to replicate or vise versa
sachinpkale
force-pushed
the
remote_store_refresh_listener
branch
from
55dd49d to
8f44fef
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
sachinpkale
force-pushed
the
remote_store_refresh_listener
branch
from
366c688 to
b5e98aa
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
reta
approved these changes
Aug 24, 2022
Bukhtawar
reviewed
Aug 26, 2022
Comment on lines
-35
to
+61
| public RemoteStoreRefreshListener(Directory storeDirectory, Directory remoteDirectory) throws IOException { | ||
| this.storeDirectory = storeDirectory; | ||
| this.remoteDirectory = remoteDirectory; | ||
| // ToDo: Handle failures in reading list of files (GitHub #3397) | ||
| this.filesUploadedToRemoteStore = new HashSet<>(Arrays.asList(remoteDirectory.listAll())); | ||
| public RemoteStoreRefreshListener(IndexShard indexShard) { | ||
| this.indexShard = indexShard; | ||
| this.storeDirectory = indexShard.store().directory(); | ||
| this.remoteDirectory = (RemoteSegmentStoreDirectory) ((FilterDirectory) ((FilterDirectory) indexShard.remoteStore().directory()) | ||
| .getDelegate()).getDelegate(); | ||
| this.primaryTerm = indexShard.getOperationPrimaryTerm(); | ||
| localSegmentChecksumMap = new HashMap<>(); |
There was a problem hiding this comment.
would have preferred individual dependencies as supplier rather than a full IndexShard dependency, to protect against misuse
There was a problem hiding this comment.
Yeah, I thought about that but there are different IndexShard methods (getOperationPrimaryTerm, getSegmentInfosSnapshot) that are getting called in the afterRefresh() flow.
Created #4316 to track this.
Bukhtawar
reviewed
Aug 26, 2022
Comment on lines
374
to
376
| public Map<String, UploadedSegmentMetadata> getSegmentsUploadedToRemoteStore() { | ||
| return this.segmentsUploadedToRemoteStore; | ||
| } |
There was a problem hiding this comment.
should we return an unmodifiable map instead?
Bukhtawar
reviewed
Aug 26, 2022
Comment on lines
+409
to
+423
| for (String metadataFile : sortedMetadataFileList.subList(0, sortedMetadataFileList.size() - lastNMetadataFilesToKeep)) { | ||
| Map<String, UploadedSegmentMetadata> staleSegmentFilesMetadataMap = readMetadataFile(metadataFile); | ||
| Set<String> staleSegmentRemoteFilenames = staleSegmentFilesMetadataMap.values() | ||
| .stream() | ||
| .map(metadata -> metadata.uploadedFilename) | ||
| .collect(Collectors.toSet()); | ||
| AtomicBoolean deletionSuccessful = new AtomicBoolean(true); | ||
| staleSegmentRemoteFilenames.stream().filter(file -> !activeSegmentRemoteFilenames.contains(file)).forEach(file -> { | ||
| try { | ||
| remoteDataDirectory.deleteFile(file); | ||
| if (!activeSegmentFilesMetadataMap.containsKey(getLocalSegmentFilename(file))) { | ||
| segmentsUploadedToRemoteStore.remove(getLocalSegmentFilename(file)); | ||
| } | ||
| } catch (NoSuchFileException e) { | ||
| logger.info("Segment file {} corresponding to metadata file {} does not exist in remote", file, metadataFile); |
There was a problem hiding this comment.
The underlying blobstore for remote store supports bulk deletes, do you think we could add a deleteFiles interface to leverage the same?
There was a problem hiding this comment.
Yes, we can do that but that involves deviating from directory API that currently supports only single file delete. I am trying to keep the interface same as much as possible (making changes only if there is no other way).
Let me think more on this. I guess we can have a common solution for bulk upload (referring to your comment here) and delete.
I have created a tracking issue here: #4317
Bukhtawar
reviewed
Aug 26, 2022
Comment on lines
+138
to
+159
| boolean uploadNewSegments(Collection<String> localFiles) throws IOException { | ||
| AtomicBoolean uploadSuccess = new AtomicBoolean(true); | ||
| localFiles.stream().filter(file -> !EXCLUDE_FILES.contains(file)).filter(file -> { | ||
| try { | ||
| return !remoteDirectory.containsFile(file, getChecksumOfLocalFile(file)); | ||
| } catch (IOException e) { | ||
| logger.info( | ||
| "Exception while reading checksum of local segment file: {}, ignoring the exception and re-uploading the file", | ||
| file | ||
| ); | ||
| return true; | ||
| } | ||
| }).forEach(file -> { | ||
| try { | ||
| remoteDirectory.copyFrom(storeDirectory, file, file, IOContext.DEFAULT); | ||
| } catch (IOException e) { | ||
| uploadSuccess.set(false); | ||
| // ToDO: Handle transient and permanent un-availability of the remote store (GitHub #3397) | ||
| logger.warn(() -> new ParameterizedMessage("Exception while uploading file {} to the remote segment store", file), e); | ||
| } | ||
| }); | ||
| return uploadSuccess.get(); |
There was a problem hiding this comment.
the upload is happening serially, can we either bulk upload or do concurrent async uploads
Bukhtawar
reviewed
Aug 27, 2022
| lastCommittedLocalSegmentFileName, | ||
| getChecksumOfLocalFile(lastCommittedLocalSegmentFileName) | ||
| )) { | ||
| deleteStaleCommits(); |
There was a problem hiding this comment.
Would clean up stall refresh ? Can we do this in the background?
There was a problem hiding this comment.
Clean up does not happen at each refresh. It would only be called when refresh is called during flush (as new segments_N file gets created). We can definitely preform stale commit deletion in the background. I have created a tracking issue here: #4315
This was referenced Aug 29, 2022
added 6 commits
August 29, 2022 11:31
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
sachinpkale
force-pushed
the
remote_store_refresh_listener
branch
from
72293ef to
5d30441
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Bukhtawar
approved these changes
Aug 29, 2022
sachinpkale
added a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Sep 1, 2022
…h-project#4240) * Use RemoteSegmentStoreDirectory instead of RemoteDirectory Signed-off-by: Sachin Kale <kalsac@amazon.com>
6 tasks
sachinpkale
added a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Sep 2, 2022
…h-project#4240) * Use RemoteSegmentStoreDirectory instead of RemoteDirectory Signed-off-by: Sachin Kale <kalsac@amazon.com>
sachinpkale
added a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Sep 2, 2022
…h-project#4240) * Use RemoteSegmentStoreDirectory instead of RemoteDirectory Signed-off-by: Sachin Kale <kalsac@amazon.com>
Bukhtawar
pushed a commit
that referenced
this pull request
Sep 2, 2022
…4380) * [Remote Store] Upload segments to remote store post refresh (#3460) * Add RemoteDirectory interface to copy segment files to/from remote store Signed-off-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Sachin Kale <kalsac@amazon.com> * Add index level setting for remote store Signed-off-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Sachin Kale <kalsac@amazon.com> * Add RemoteDirectoryFactory and use RemoteDirectory instance in RefreshListener Co-authored-by: Sachin Kale <kalsac@amazon.com> Signed-off-by: Sachin Kale <kalsac@amazon.com> * Upload segment to remote store post refresh Signed-off-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Sachin Kale <kalsac@amazon.com> Signed-off-by: Sachin Kale <kalsac@amazon.com> * [Remote Store] Inject remote store in IndexShard instead of RemoteStoreRefreshListener (#3703) * Inject remote store in IndexShard instead of RemoteStoreRefreshListener Signed-off-by: Sachin Kale <kalsac@amazon.com> * Pass supplier of RepositoriesService to RemoteDirectoryFactory Signed-off-by: Sachin Kale <kalsac@amazon.com> * Create isRemoteStoreEnabled function for IndexShard Signed-off-by: Sachin Kale <kalsac@amazon.com> * Explicitly close remoteStore on indexShard close Signed-off-by: Sachin Kale <kalsac@amazon.com> * Change RemoteDirectory.close to a no-op Signed-off-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Sachin Kale <kalsac@amazon.com> * [Remote Store] Add remote store restore API implementation (#3642) * Add remote restore API implementation Signed-off-by: Sachin Kale <kalsac@amazon.com> * [Remote Store] Add support to add nested settings for remote store (#4060) * Add support to add nested settings for remote store Signed-off-by: Sachin Kale <kalsac@amazon.com> * [Remote Store] Add rest endpoint for remote store restore (#3576) * Add rest endpoint for remote store restore Signed-off-by: Sachin Kale <kalsac@amazon.com> * [Remote Store] Add validator that forces segment replication type before enabling remote store (#4175) * Add validator that forces segment replication type before enabling remote store Signed-off-by: Sachin Kale <kalsac@amazon.com> * [Remote Store] Change remote_store setting validation message to make it more clear (#4199) * Change remote_store setting validation message to make it more clear Signed-off-by: Sachin Kale <kalsac@amazon.com> * [Remote Store] Add RemoteSegmentStoreDirectory to interact with remote segment store (#4020) * Add RemoteSegmentStoreDirectory to interact with remote segment store Signed-off-by: Sachin Kale <kalsac@amazon.com> * Use RemoteSegmentStoreDirectory instead of RemoteDirectory (#4240) * Use RemoteSegmentStoreDirectory instead of RemoteDirectory Signed-off-by: Sachin Kale <kalsac@amazon.com> Signed-off-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Sachin Kale <kalsac@amazon.com>
Bukhtawar
pushed a commit
that referenced
this pull request
Sep 2, 2022
* [BUG] Running "opensearch-service.bat start" and "opensearch-service.bat manager" (#4289) * [BUG] Update opensearch-service-x64.exe parameters to //ES for Execute Service. Update opensearch-service-mgr.exe parameters to //ES for Edit Service. Add code comments for the Apache Commons Daemon. Signed-off-by: Alex Burck <me@alexburck.com> * update changelog with pull request link Signed-off-by: Alex Burck <me@alexburck.com> Signed-off-by: Alex Burck <me@alexburck.com> * Removing dead code in RecoveryTarget. (#4278) * Removing dead code in RecoveryTarget. This code in RecoveryTarget is not invoked, all of these methods are implemented by the parent ReplicationTarget with the same behavior. Signed-off-by: Marc Handalian <handalm@amazon.com> * PR Comments. Signed-off-by: Marc Handalian <handalm@amazon.com> Signed-off-by: Marc Handalian <handalm@amazon.com> * Update the head ref to changelog verifier (#4296) * Update changelog contribution guide Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Fix reference to pull request Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Add 2.x version to CHANGELOG (#4297) Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Do not fail replica shard due to primary closure (#4133) This commit prevents a replica shard from being failed in the case that a replication action to a replica is canceled due to the primary shard being closed. Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com> * Some dependency updates (#4308) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Restore using the class ClusterInfoRequest and ClusterInfoRequestBuilder from package 'org.opensearch.action.support.master.info' for subclasses (#4307) * Restore using the class ClusterInfoRequest and ClusterInfoRequestBuilder from package 'org.opensearch.action.support.master.info' for subclasses Signed-off-by: Tianli Feng <ftianli@amazon.com> * Add changelog Signed-off-by: Tianli Feng <ftianli@amazon.com> Signed-off-by: Tianli Feng <ftianli@amazon.com> Co-authored-by: Andrew Ross <andrross@amazon.com> * [BUG] Create logs directory before running OpenSearch on Windows (#4305) * [BUG] Create logs directory before running OpenSearch on Windows Signed-off-by: Alex Burck <me@alexburck.com> * update changlog pr link Signed-off-by: Alex Burck <me@alexburck.com> Signed-off-by: Alex Burck <me@alexburck.com> * Use RemoteSegmentStoreDirectory instead of RemoteDirectory (#4240) * Use RemoteSegmentStoreDirectory instead of RemoteDirectory Signed-off-by: Sachin Kale <kalsac@amazon.com> * ZIP publication groupId value is configurable (#4156) When publishing Zip POM the groupId value was hard-coded to `org.opensearch.plugin` value which worked fine for existing core plugins but is not convenient for other plugins (such as community plugins maintained in independent repositories). This PR changes the sources of the ZIP publishing groupId value. Specifically, there are two ways to set the value: 1) It is automatically inherited from the Gradle "project.group" 2) It can be manually specified in the ZIP publication POM object This PR also brings a major rework of tests in PublishTests class. Individual testing scenarios are driven by "real" gradle building scripts (utilizing `java-gradle-plugin` gradle plugin). Closes #3692 Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io> Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io> * [Segment Replication] Add timeout on Mockito.verify to reduce flakyness in testReplicationOnDone test (#4314) * [Segment Replication] testReplicationOnDone Add timeout to allow time for verify call Signed-off-by: Suraj Singh <surajrider@gmail.com> * Update changelog Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add change log entry Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Suraj Singh <surajrider@gmail.com> * Adding @dreamer-89 to Opensearch maintainers. (#4342) Signed-off-by: Kartik Ganesh <gkart@amazon.com> Signed-off-by: Kartik Ganesh <gkart@amazon.com> * [CVE] Update snakeyaml dependency (#4341) The package `org.yaml:snakeyaml` before version 1.31 are vulnerable to Denial of Service (DoS) due missing to nested depth limitation for collections. Details at https://nvd.nist.gov/vuln/detail/CVE-2022-25857 Signed-off-by: Rabi Panda <adnapibar@gmail.com> * Fixed commit workflow for dependabot PR helper (#4331) * Fixed label for dependabot PR helper Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Update autocommit workflow for dependabot changelog Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Add version config for dependabot changelog helper Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Add release notes for patch release 1.3.5 (#4343) Signed-off-by: Rabi Panda <adnapibar@gmail.com> * Add release notes for patch release 2.2.1 (#4344) Signed-off-by: Rabi Panda <adnapibar@gmail.com> * Add label configuration for dependabot PRs (#4348) * Support for HTTP/2 (server-side) (#3847) * Support for HTTP/2 (server-side) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Addressing code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Added HTTP/1.1 channel configuration Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Addressing code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Update pul request URL in CHANGELOG.md Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Fix token usage for changelog helper (#4351) Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Revert "Fix token usage for changelog helper (#4351)" (#4361) This reverts commit c28221e. Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Segment Replication - Implement segment replication event cancellation. (#4225) * Segment Replication. Fix Cancellation of replication events. This PR updates segment replication paths to correctly cancel replication events on the primary and replica. In the source service, any ongoing event for a primary that is sending to a replica that shuts down or is promoted as a new primary are cancelled. In the target service, any ongoing event for a replica that is promoted as a new primary or is fetching from a primary that shuts down. It wires up SegmentReplicationSourceService as an IndexEventListener so that it can respond to events and cancel any ongoing transfer state. This change also includes some test cleanup for segment replication to rely on actual components over mocks. Signed-off-by: Marc Handalian <handalm@amazon.com> Fix to not start/stop SegmentReplicationSourceService as a lifecycle component with feature flag off. Signed-off-by: Marc Handalian <handalm@amazon.com> Update logic to properly mark SegmentReplicationTarget as cancelled when cancel initiated by primary. Signed-off-by: Marc Handalian <handalm@amazon.com> Minor updates from self review. Signed-off-by: Marc Handalian <handalm@amazon.com> * Add missing changelog entry. Signed-off-by: Marc Handalian <handalm@amazon.com> Signed-off-by: Marc Handalian <handalm@amazon.com> * Bug fixes for dependabot changelog verifier (#4364) * Fix token usage for changelog helper Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Add conditional check for dependabot steps Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Add dependency section Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Bug fixes for dependabot changelog verifier Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Update the changelog Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Add changes for Create PIT and Delete PIT rest layer and rest high level client (#4064) * Create and delete PIT search rest layer changes Signed-off-by: Bharathwaj G <bharath78910@gmail.com> * Bump com.diffplug.spotless from 6.9.1 to 6.10.0 (#4319) * Update to Netty 4.1.80.Final (#4359) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Bump xmlbeans from 5.1.0 to 5.1.1 in /plugins/ingest-attachment (#4354) * Bump xmlbeans from 5.1.0 to 5.1.1 in /plugins/ingest-attachment Bumps xmlbeans from 5.1.0 to 5.1.1. --- updated-dependencies: - dependency-name: org.apache.xmlbeans:xmlbeans dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * Fix randomized test failure NRTReplicationEngineTests.testUpdateSegments (#4352) Overload `generateHistoryOnReplica` to be able to generate only a specific `Engine.Operation.TYPE` operations as required by the `testUpdateSegments` test Signed-off-by: Rabi Panda <adnapibar@gmail.com> Signed-off-by: Rabi Panda <adnapibar@gmail.com> * [AUTO] [main] Added bwc version 2.2.2. (#4383) * Added bwc version 2.2.2 * Add changelog Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-ci-bot@users.noreply.github.com> Co-authored-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Alex Burck <me@alexburck.com> Signed-off-by: Marc Handalian <handalm@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Tianli Feng <ftianli@amazon.com> Signed-off-by: Sachin Kale <kalsac@amazon.com> Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io> Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Kartik Ganesh <gkart@amazon.com> Signed-off-by: Rabi Panda <adnapibar@gmail.com> Signed-off-by: Bharathwaj G <bharath78910@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Alex Burck <me@alexburck.com> Co-authored-by: Marc Handalian <handalm@amazon.com> Co-authored-by: Kunal Kotwani <kkotwani@amazon.com> Co-authored-by: Andrew Ross <andrross@amazon.com> Co-authored-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: Tianli Feng <ftianli@amazon.com> Co-authored-by: Sachin Kale <sachinpkale@gmail.com> Co-authored-by: Lukáš Vlček <lukas.vlcek@aiven.io> Co-authored-by: Suraj Singh <surajrider@gmail.com> Co-authored-by: Kartik Ganesh <gkart@amazon.com> Co-authored-by: Rabi Panda <adnapibar@gmail.com> Co-authored-by: Bharathwaj G <58062316+bharath-techie@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <opensearch-ci-bot@users.noreply.github.com>
Bukhtawar
pushed a commit
that referenced
this pull request
Oct 1, 2022
* [BUG] Running "opensearch-service.bat start" and "opensearch-service.bat manager" (#4289) * [BUG] Update opensearch-service-x64.exe parameters to //ES for Execute Service. Update opensearch-service-mgr.exe parameters to //ES for Edit Service. Add code comments for the Apache Commons Daemon. Signed-off-by: Alex Burck <me@alexburck.com> * update changelog with pull request link Signed-off-by: Alex Burck <me@alexburck.com> Signed-off-by: Alex Burck <me@alexburck.com> * Removing dead code in RecoveryTarget. (#4278) * Removing dead code in RecoveryTarget. This code in RecoveryTarget is not invoked, all of these methods are implemented by the parent ReplicationTarget with the same behavior. Signed-off-by: Marc Handalian <handalm@amazon.com> * PR Comments. Signed-off-by: Marc Handalian <handalm@amazon.com> Signed-off-by: Marc Handalian <handalm@amazon.com> * Update the head ref to changelog verifier (#4296) * Update changelog contribution guide Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Fix reference to pull request Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Add 2.x version to CHANGELOG (#4297) Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Do not fail replica shard due to primary closure (#4133) This commit prevents a replica shard from being failed in the case that a replication action to a replica is canceled due to the primary shard being closed. Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com> * Some dependency updates (#4308) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Restore using the class ClusterInfoRequest and ClusterInfoRequestBuilder from package 'org.opensearch.action.support.master.info' for subclasses (#4307) * Restore using the class ClusterInfoRequest and ClusterInfoRequestBuilder from package 'org.opensearch.action.support.master.info' for subclasses Signed-off-by: Tianli Feng <ftianli@amazon.com> * Add changelog Signed-off-by: Tianli Feng <ftianli@amazon.com> Signed-off-by: Tianli Feng <ftianli@amazon.com> Co-authored-by: Andrew Ross <andrross@amazon.com> * [BUG] Create logs directory before running OpenSearch on Windows (#4305) * [BUG] Create logs directory before running OpenSearch on Windows Signed-off-by: Alex Burck <me@alexburck.com> * update changlog pr link Signed-off-by: Alex Burck <me@alexburck.com> Signed-off-by: Alex Burck <me@alexburck.com> * Use RemoteSegmentStoreDirectory instead of RemoteDirectory (#4240) * Use RemoteSegmentStoreDirectory instead of RemoteDirectory Signed-off-by: Sachin Kale <kalsac@amazon.com> * ZIP publication groupId value is configurable (#4156) When publishing Zip POM the groupId value was hard-coded to `org.opensearch.plugin` value which worked fine for existing core plugins but is not convenient for other plugins (such as community plugins maintained in independent repositories). This PR changes the sources of the ZIP publishing groupId value. Specifically, there are two ways to set the value: 1) It is automatically inherited from the Gradle "project.group" 2) It can be manually specified in the ZIP publication POM object This PR also brings a major rework of tests in PublishTests class. Individual testing scenarios are driven by "real" gradle building scripts (utilizing `java-gradle-plugin` gradle plugin). Closes #3692 Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io> Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io> * [Segment Replication] Add timeout on Mockito.verify to reduce flakyness in testReplicationOnDone test (#4314) * [Segment Replication] testReplicationOnDone Add timeout to allow time for verify call Signed-off-by: Suraj Singh <surajrider@gmail.com> * Update changelog Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add change log entry Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Suraj Singh <surajrider@gmail.com> * Adding @dreamer-89 to Opensearch maintainers. (#4342) Signed-off-by: Kartik Ganesh <gkart@amazon.com> Signed-off-by: Kartik Ganesh <gkart@amazon.com> * [CVE] Update snakeyaml dependency (#4341) The package `org.yaml:snakeyaml` before version 1.31 are vulnerable to Denial of Service (DoS) due missing to nested depth limitation for collections. Details at https://nvd.nist.gov/vuln/detail/CVE-2022-25857 Signed-off-by: Rabi Panda <adnapibar@gmail.com> * Fixed commit workflow for dependabot PR helper (#4331) * Fixed label for dependabot PR helper Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Update autocommit workflow for dependabot changelog Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Add version config for dependabot changelog helper Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Add release notes for patch release 1.3.5 (#4343) Signed-off-by: Rabi Panda <adnapibar@gmail.com> * Add release notes for patch release 2.2.1 (#4344) Signed-off-by: Rabi Panda <adnapibar@gmail.com> * Add label configuration for dependabot PRs (#4348) * Support for HTTP/2 (server-side) (#3847) * Support for HTTP/2 (server-side) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Addressing code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Added HTTP/1.1 channel configuration Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Addressing code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Update pul request URL in CHANGELOG.md Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Fix token usage for changelog helper (#4351) Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Revert "Fix token usage for changelog helper (#4351)" (#4361) This reverts commit c28221e. Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Segment Replication - Implement segment replication event cancellation. (#4225) * Segment Replication. Fix Cancellation of replication events. This PR updates segment replication paths to correctly cancel replication events on the primary and replica. In the source service, any ongoing event for a primary that is sending to a replica that shuts down or is promoted as a new primary are cancelled. In the target service, any ongoing event for a replica that is promoted as a new primary or is fetching from a primary that shuts down. It wires up SegmentReplicationSourceService as an IndexEventListener so that it can respond to events and cancel any ongoing transfer state. This change also includes some test cleanup for segment replication to rely on actual components over mocks. Signed-off-by: Marc Handalian <handalm@amazon.com> Fix to not start/stop SegmentReplicationSourceService as a lifecycle component with feature flag off. Signed-off-by: Marc Handalian <handalm@amazon.com> Update logic to properly mark SegmentReplicationTarget as cancelled when cancel initiated by primary. Signed-off-by: Marc Handalian <handalm@amazon.com> Minor updates from self review. Signed-off-by: Marc Handalian <handalm@amazon.com> * Add missing changelog entry. Signed-off-by: Marc Handalian <handalm@amazon.com> Signed-off-by: Marc Handalian <handalm@amazon.com> * Bug fixes for dependabot changelog verifier (#4364) * Fix token usage for changelog helper Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Add conditional check for dependabot steps Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Add dependency section Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Bug fixes for dependabot changelog verifier Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Update the changelog Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Add changes for Create PIT and Delete PIT rest layer and rest high level client (#4064) * Create and delete PIT search rest layer changes Signed-off-by: Bharathwaj G <bharath78910@gmail.com> * Bump com.diffplug.spotless from 6.9.1 to 6.10.0 (#4319) * Update to Netty 4.1.80.Final (#4359) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Bump xmlbeans from 5.1.0 to 5.1.1 in /plugins/ingest-attachment (#4354) * Bump xmlbeans from 5.1.0 to 5.1.1 in /plugins/ingest-attachment Bumps xmlbeans from 5.1.0 to 5.1.1. --- updated-dependencies: - dependency-name: org.apache.xmlbeans:xmlbeans dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * Fix randomized test failure NRTReplicationEngineTests.testUpdateSegments (#4352) Overload `generateHistoryOnReplica` to be able to generate only a specific `Engine.Operation.TYPE` operations as required by the `testUpdateSegments` test Signed-off-by: Rabi Panda <adnapibar@gmail.com> Signed-off-by: Rabi Panda <adnapibar@gmail.com> * [AUTO] [main] Added bwc version 2.2.2. (#4383) * Added bwc version 2.2.2 * Add changelog Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-ci-bot@users.noreply.github.com> Co-authored-by: Kunal Kotwani <kkotwani@amazon.com> * [Segment Replication] Bump segment infos counter before commit during replica promotion (#4365) * [Segment Replication] Bump segment infos counter before commit during replica promotion Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add changelog entry Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Suraj Singh <surajrider@gmail.com> * [Segment Replication] Add check to cancel ongoing replication with old primary on onNewCheckpoint on replica (#4363) * [Segment Replication] Add check to cancel ongoing replication with old primary on onNewCheckpoint on replica Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add changelog entry Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments 2 Signed-off-by: Suraj Singh <surajrider@gmail.com> * Test failures Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Suraj Singh <surajrider@gmail.com> * Adding support for labels on version bump PRs, skip label support for… (#4391) * Adding support for labels on version bump PRs, skip label support for changelog verifier Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Add changelog Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * [Segment Replication] Extend FileChunkWriter to allow cancel on transport client (#4386) * [Segment Replication] Extend FileChunkWriter to allow cancel on retryable transport client Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add changelog entry Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments Signed-off-by: Suraj Singh <surajrider@gmail.com> * Integration test Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Suraj Singh <surajrider@gmail.com> * Added RestLayer Changes for PIT stats (#4217) Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> * Modified cat shards test for pit stats (#4408) Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> * [Remote Store] Add index specific setting for remote repository (#4253) * Add index specific setting for remote repository * Fix for failover incremental uploads Signed-off-by: Sachin Kale <kalsac@amazon.com> * [Semgnet Replication] Update flaky testOnNewCheckpointFromNewPrimaryCancelOngoingReplication unit test (#4414) * [Semgnet Replication] Update flaky testOnNewCheckpointFromNewPrimaryCancelOngoingReplication unit test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add changelog entry Signed-off-by: Suraj Singh <surajrider@gmail.com> * Update changelog entry Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Suraj Singh <surajrider@gmail.com> * Segment Replication - Fix NoSuchFileException errors caused when computing metadata snapshot on primary shards. (#4366) * Segment Replication - Fix NoSuchFileException errors caused when computing metadata snapshot on primary shards. This change fixes the errors that occur when computing metadata snapshots on primary shards from the latest in-memory SegmentInfos. The error occurs when a segments_N file that is referenced by the in-memory infos is deleted as part of a concurrent commit. The segments themselves are incref'd by IndexWriter.incRefDeleter but the commit file (Segments_N) is not. This change resolves this by ignoring the segments_N file when computing metadata for CopyState and only sending incref'd segment files to replicas. Signed-off-by: Marc Handalian <handalm@amazon.com> * Fix spotless. Signed-off-by: Marc Handalian <handalm@amazon.com> * Update StoreTests.testCleanupAndPreserveLatestCommitPoint to assert additional segments are deleted. Signed-off-by: Marc Handalian <handalm@amazon.com> * Rename snapshot to metadataMap in CheckpointInfoResponse. Signed-off-by: Marc Handalian <handalm@amazon.com> * Refactor segmentReplicationDiff method to compute off two maps instead of MetadataSnapshots. Signed-off-by: Marc Handalian <handalm@amazon.com> * Fix spotless. Signed-off-by: Marc Handalian <handalm@amazon.com> * Revert catchall in SegmentReplicationSourceService. Signed-off-by: Marc Handalian <handalm@amazon.com> * Revert log lvl change. Signed-off-by: Marc Handalian <handalm@amazon.com> * Fix SegmentReplicationTargetTests Signed-off-by: Marc Handalian <handalm@amazon.com> * Cleanup unused logger. Signed-off-by: Marc Handalian <handalm@amazon.com> Signed-off-by: Marc Handalian <handalm@amazon.com> Co-authored-by: Suraj Singh <surajrider@gmail.com> * Bump org.gradle.test-retry from 1.4.0 to 1.4.1 (#4411) * Bump org.gradle.test-retry from 1.4.0 to 1.4.1 Bumps org.gradle.test-retry from 1.4.0 to 1.4.1. --- updated-dependencies: - dependency-name: org.gradle.test-retry dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * Revert to Netty 4.1.79.Final (#4428) Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Craig Perkins <cwperx@amazon.com> * [Segment Replication] Fix timeout issue by calculating time needed to process getSegmentFiles. (#4426) * Fix timeout issue by calculating time needed to process getSegmentFiles. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Formatting sizeOfSegmentFiles for time calculation. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Addressing comments and applying spotless check. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * [Bug]: gradle check failing with java heap OutOfMemoryError (#4328) * [Bug]: gradle check failing with java heap OutOfMemoryError Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Fork JavaCompile task Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Bump azure-core-http-netty from 1.12.0 to 1.12.4 in /plugins/repository-azure (#4160) * Bump azure-core-http-netty in /plugins/repository-azure Bumps [azure-core-http-netty](https://github.com/Azure/azure-sdk-for-java) from 1.12.0 to 1.12.4. - [Release notes](https://github.com/Azure/azure-sdk-for-java/releases) - [Commits](Azure/azure-sdk-for-java@azure-core_1.12.0...azure-core-http-netty_1.12.4) --- updated-dependencies: - dependency-name: com.azure:azure-core-http-netty dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Added missing forbidden classes Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * update version of azure-storage-common and azure-core-http-netty Signed-off-by: Xue Zhou <xuezhou@amazon.com> * update version of azure-storage-common and azure-core-http-netty Signed-off-by: Xue Zhou <xuezhou@amazon.com> * adding changelog information Signed-off-by: Xue Zhou <xuezhou@amazon.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Xue Zhou <xuezhou@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Owais Kazi <owaiskazi19@gmail.com> Co-authored-by: Xue Zhou <xuezhou@amazon.com> * Bugfix: Allow opensearch.bat file and opensearch-env.bat files to run when install path includes a space. (#4362) * Bugfix: Prevent escaping of in `else-if` statement by setting variable without double quotes. Signed-off-by: Mike Wilkinson <mwilkinson@imohealth.com> * Add changelog entry for fix Signed-off-by: Mike Wilkinson <mwilkinson@imohealth.com> * Escape double quotes for environment variables set by `opensearch-env.bat`. Explicitly apply quotes where those environment variables are invoked. Signed-off-by: Mike Wilkinson <mwilkinson@imohealth.com> Signed-off-by: Mike Wilkinson <mwilkinson@imohealth.com> Co-authored-by: Mike Wilkinson <mwilkinson@imohealth.com> * [Segment Replication] - Update replicas to commit SegmentInfos instead of relying on segments_N from primary shards. (#4402) * Segment Replication - Update replicas to commit SegmentInfos instead of relying on segments_N from primary shards. This change updates replicas to commit SegmentInfos before the shard is closed, on receiving a new commit point from a primary, and when a new primary is detected. This change also makes the public commitSegmentInfos on NRTEngine obsolete, refactoring IndexShard to simply call reset on the engine. Signed-off-by: Marc Handalian <handalm@amazon.com> * Remove noise & extra log statement. Signed-off-by: Marc Handalian <handalm@amazon.com> * PR feedback. Signed-off-by: Marc Handalian <handalm@amazon.com> Signed-off-by: Marc Handalian <handalm@amazon.com> * Bump reactor-netty-core from 1.0.19 to 1.0.22 in /plugins/repository-azure (#4447) * Bump reactor-netty-core in /plugins/repository-azure Bumps [reactor-netty-core](https://github.com/reactor/reactor-netty) from 1.0.19 to 1.0.22. - [Release notes](https://github.com/reactor/reactor-netty/releases) - [Commits](reactor/reactor-netty@v1.0.19...v1.0.22) --- updated-dependencies: - dependency-name: io.projectreactor.netty:reactor-netty-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * Add bwcVersion 2.4.0 (#4455) * Add bwcVersion 2.4.0 Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add changelog entry Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Suraj Singh <surajrider@gmail.com> * add support for s390x architecture (#4001) * add s390x support in systemcallfilter #4000 Signed-off-by: Andrija Pantovic <andrija.pantovic@phoenix-systems.ch> * add gradle cfg for s390x Signed-off-by: Andrija Pantovic <andrija.pantovic@gmail.com> * change assertion for architecture Signed-off-by: Andrija Pantovic <andrija.pantovic@gmail.com> * change assertion for architecture Signed-off-by: Andrija Pantovic <andrija.pantovic@gmail.com> * update changelog Signed-off-by: Andrija Pantovic <andrija.pantovic@gmail.com> Signed-off-by: Andrija Pantovic <andrija.pantovic@phoenix-systems.ch> Signed-off-by: Andrija Pantovic <andrija.pantovic@gmail.com> * 2.3.0 release notes (#4457) (#4464) * 2.3.0 release notes Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add changelog entry Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add getHistoryOperationsFromTranslog method to fetch the history snapshot from translogs (#3948) * Add getHistoryOperationsFromTranslog method to fetch the hostory snapshot from translogs Signed-off-by: Ankit Kala <ankikala@amazon.com> * Fixed flaky test: ResourceAwareTasksTests.testTaskIdPersistsInThreadContext (#4484) Signed-off-by: Ketan Verma <ketan9495@gmail.com> * Getting security exception due to access denied 'java.lang.RuntimePermission' 'accessDeclaredMembers' when trying to get snapshot with S3 IRSA (#4469) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: Suraj Singh <surajrider@gmail.com> * [Javadoc] add missing javadocs for :distribution:tools modules (#4483) * Add javadocs for distribution:tools:java-version-checker Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add javadocs for distribution:tools:keystore-cli Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add javadocs for distribution:tools:plugin-cli Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add javadocs for distribution:tools:launchers Signed-off-by: Daniel Widdis <widdis@gmail.com> * Change log Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> * Bump reactive-streams from 1.0.3 to 1.0.4 in /plugins/repository-azure (#4488) * Bump reactive-streams from 1.0.3 to 1.0.4 in /plugins/repository-azure Bumps [reactive-streams](https://github.com/reactive-streams/reactive-streams) from 1.0.3 to 1.0.4. - [Release notes](https://github.com/reactive-streams/reactive-streams/releases) - [Changelog](https://github.com/reactive-streams/reactive-streams-jvm/blob/master/RELEASE-NOTES.md) - [Commits](reactive-streams/reactive-streams-jvm@v1.0.3...v1.0.4) --- updated-dependencies: - dependency-name: org.reactivestreams:reactive-streams dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * Ignore all malformed objects when ignore_malformed is true (#4494) Fixes a bug to not fail the entire document when "ignore_malformed" is set to true. Allowing the valid fields to be indexed and ignore only the malformed fields. Signed-off-by: Hauck <joaoh14@gmail.com> * [AUTO] [main] Added bwc version 2.3.1. (#4513) * Added bwc version 2.3.1 * Add changelog of adding bwc version 2.3.1 Signed-off-by: Tianli Feng <ftianli@amazon.com> * [Segment Replication] Add snapshot and restore tests for segment replication feature (#3993) * [Segment Replication] Add snapshots tests with segment replication enabled Signed-off-by: Suraj Singh <surajrider@gmail.com> * Fix spotless failures Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add changelog entry, address review comments, add failover test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Fix spotless failures Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments 2 Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Suraj Singh <surajrider@gmail.com> * [Remote Store] Change behaviour in replica recovery for remote translog enabled indices (#4318) Signed-off-by: Ashish Singh <ssashish@amazon.com> * Weighted round-robin scheduling policy for shard coordination traffic… (#4241) * Weighted round-robin scheduling policy for shard coordination traffic routing Signed-off-by: Anshu Agarwal <anshukag@amazon.com> * [Javadoc] add missing javadocs for :example-plugin modules (#4540) * Add javadocs for example-plugins:custom-settings module Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add javadocs for example-plugins:custom-significance-heuristic Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add javadocs for example-plugins:custom-suggester Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add javadocs to example-plugins:painless-allowlist Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add javadocs to example-plugins:rescore Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add javadocs to example-plugins:rest-handler Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add javadocs to example-plugins:script-expert-scoring Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove exclusions for module which aren't giving javadoc errors Signed-off-by: Daniel Widdis <widdis@gmail.com> * CI testing apparently needs to instantiate a no-op class Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add GeoBounds aggregation on GeoShape field type.(#3980) (#4266) Enables geo_bounds aggregation to work with geo_shape field types. This enhancement includes: * Addition of Doc values on the GeoShape Field. * Addition of GeoShape ValueSource level code interfaces for accessing the DocValues. * Addition of Missing Value feature in the GeoShape Aggregations. Signed-off-by: Navneet Verma <navneev@amazon.com> * Updates jackson and snakeyml dependencies (#4556) * Upgrade jackson and snakeyml dependencies Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Updated changelog Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Bump com.diffplug.spotless from 6.10.0 to 6.11.0 (#4547) * Bump com.diffplug.spotless from 6.10.0 to 6.11.0 --- updated-dependencies: - dependency-name: com.diffplug.spotless dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump reactor-core from 3.4.18 to 3.4.23 in /plugins/repository-azure (#4548) * Bump reactor-core from 3.4.18 to 3.4.23 in /plugins/repository-azure Bumps [reactor-core](https://github.com/reactor/reactor-core) from 3.4.18 to 3.4.23. - [Release notes](https://github.com/reactor/reactor-core/releases) - [Commits](reactor/reactor-core@v3.4.18...v3.4.23) --- updated-dependencies: - dependency-name: io.projectreactor:reactor-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump jempbox from 1.8.16 to 1.8.17 in /plugins/ingest-attachment (#4550) * Bump jempbox from 1.8.16 to 1.8.17 in /plugins/ingest-attachment Bumps jempbox from 1.8.16 to 1.8.17. --- updated-dependencies: - dependency-name: org.apache.pdfbox:jempbox dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump log4j-core from 2.18.0 to 2.19.0 in /buildSrc/src/testKit/thirdPartyAudit (#4549) * Bump log4j-core in /buildSrc/src/testKit/thirdPartyAudit Bumps log4j-core from 2.18.0 to 2.19.0. --- updated-dependencies: - dependency-name: org.apache.logging.log4j:log4j-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * Ignore lock file when testing cleanupAndPreserveLatestCommitPoint (#4544) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove deprecated code to add node name into log pattern of log4j property file (#4568) Signed-off-by: Tianli Feng <ftianli@amazon.com> * Unmute RelocationIT.testRelocationWhileIndexingRandom. (#4580) Signed-off-by: Marc Handalian <handalm@amazon.com> Signed-off-by: Marc Handalian <handalm@amazon.com> * Add DecommissionService and helper to execute awareness attribute decommissioning (#4084) * Add Executor to decommission node attribute * Decommission service implementation with cluster metadata * Master abdication changes to decommission local awareness leader * Update join validator changes to validate decommissioned node join request Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Added rest layer changes for List all PITs and PIT segments (#4388) * Changes for list all and pit segments Signed-off-by: Bharathwaj G <bharath78910@gmail.com> * Add PUT api to update shard routing weights (#4272) * Add PUT api to update shard routing weights Signed-off-by: Anshu Agarwal <anshukag@amazon.com> * Further simplification of the ZIP publication implementation (#4360) A follow-up of PR #4156 that brings in further simplification of the ZIP publication implementation and new tests. It is possible to remove some of the initialization code because the work is already handled by other library under the hood (most likely by NebulaPublishPlugin). For instance the condition to test the `groupId` presence: `if (groupId == null)` was pointless. It was never `true`. If the `project.group` is not defined the publication task fails with an exception, if there is a custom `groupId` value setup in publication config then it overrides the `project.group` as well. Tests are provided to cover these use cases. As for the new tests they cover the following cases: - verify that the task "publishToMavenLocal" gets expected results. The inspiration for this comes from opensearch-project/opensearch-plugin-template-java#35 - verify that applying only the 'opensearch.pluginzip' is enough, because both the NebulaPublish and MavenPublishPlugin plugins are added explicitly and tasks are chained correctly - verify that if the plugin is applied but no publication is defined then a message is printed for the user Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io> Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io> * Add missing Javadoc tag descriptions in unit tests (#4629) * Add missing Javadoc tag descriptions in unit tests Using JDK14 (downloaded from https://jdk.java.net/archive/), I tried running ./gradlew check, and received errors like: server/src/test/java/org/opensearch/indices/replication/SegmentReplicationTargetTests.java:440: warning: no description for @throws The build then failed with "warnings found and -Werror specified". I tried again with JDK17 and the build passed. According to DEVELOPER_GUIDE.md, we should be able to build with JDK14, I added the missing Javadoc tag descriptions. Signed-off-by: Michael Froh <froh@amazon.com> * Update CHANGELOG.md Signed-off-by: Michael Froh <froh@amazon.com> Signed-off-by: Michael Froh <froh@amazon.com> * Bump reactor-netty-http from 1.0.18 to 1.0.23 in /plugins/repository-azure (#4594) * Bump reactor-netty-http in /plugins/repository-azure Bumps [reactor-netty-http](https://github.com/reactor/reactor-netty) from 1.0.18 to 1.0.23. - [Release notes](https://github.com/reactor/reactor-netty/releases) - [Commits](reactor/reactor-netty@v1.0.18...v1.0.23) --- updated-dependencies: - dependency-name: io.projectreactor.netty:reactor-netty-http dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * Bump jettison from 1.5.0 to 1.5.1 in /plugins/discovery-azure-classic (#4592) * Bump jettison from 1.5.0 to 1.5.1 in /plugins/discovery-azure-classic Bumps [jettison](https://github.com/jettison-json/jettison) from 1.5.0 to 1.5.1. - [Release notes](https://github.com/jettison-json/jettison/releases) - [Commits](jettison-json/jettison@jettison-1.5.0...jettison-1.5.1) --- updated-dependencies: - dependency-name: org.codehaus.jettison:jettison dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * Fix invalid search location of JDK for arm64 (#4613) Related commit: 0e9f74e Signed-off-by: Heemin Kim <heemin@amazon.com> Signed-off-by: Heemin Kim <heemin@amazon.com> * Remove unused object and import from TransportClusterAllocationExplainAction (#4639) Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Relax visibility of the HTTP_CHANNEL_KEY and HTTP_SERVER_CHANNEL_KEY to make it possible for the plugins to access associated Netty4HttpChannel / Netty4HttpServerChannel instance (#4638) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Alex Burck <me@alexburck.com> Signed-off-by: Marc Handalian <handalm@amazon.com> Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Tianli Feng <ftianli@amazon.com> Signed-off-by: Sachin Kale <kalsac@amazon.com> Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io> Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Kartik Ganesh <gkart@amazon.com> Signed-off-by: Rabi Panda <adnapibar@gmail.com> Signed-off-by: Bharathwaj G <bharath78910@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Xue Zhou <xuezhou@amazon.com> Signed-off-by: Mike Wilkinson <mwilkinson@imohealth.com> Signed-off-by: Andrija Pantovic <andrija.pantovic@phoenix-systems.ch> Signed-off-by: Andrija Pantovic <andrija.pantovic@gmail.com> Signed-off-by: Ankit Kala <ankikala@amazon.com> Signed-off-by: Ketan Verma <ketan9495@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Hauck <joaoh14@gmail.com> Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Anshu Agarwal <anshukag@amazon.com> Signed-off-by: Navneet Verma <navneev@amazon.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com> Signed-off-by: Michael Froh <froh@amazon.com> Signed-off-by: Heemin Kim <heemin@amazon.com> Signed-off-by: Dhwanil Patel <dhwanip@amazon.com> Co-authored-by: Alex Burck <me@alexburck.com> Co-authored-by: Marc Handalian <handalm@amazon.com> Co-authored-by: Kunal Kotwani <kkotwani@amazon.com> Co-authored-by: Andrew Ross <andrross@amazon.com> Co-authored-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: Tianli Feng <ftianli@amazon.com> Co-authored-by: Sachin Kale <sachinpkale@gmail.com> Co-authored-by: Lukáš Vlček <lukas.vlcek@aiven.io> Co-authored-by: Suraj Singh <surajrider@gmail.com> Co-authored-by: Kartik Ganesh <gkart@amazon.com> Co-authored-by: Rabi Panda <adnapibar@gmail.com> Co-authored-by: Bharathwaj G <58062316+bharath-techie@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <opensearch-ci-bot@users.noreply.github.com> Co-authored-by: Movva Ajaykumar <majaykumar51@gmail.com> Co-authored-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Rishikesh Pasham <62345295+Rishikesh1159@users.noreply.github.com> Co-authored-by: Owais Kazi <owaiskazi19@gmail.com> Co-authored-by: Xue Zhou <xuezhou@amazon.com> Co-authored-by: mwilkinson-imo <47403752+mwilkinson-imo@users.noreply.github.com> Co-authored-by: Mike Wilkinson <mwilkinson@imohealth.com> Co-authored-by: Andrija Pantovic <andrija.pantovic@gmail.com> Co-authored-by: Ankit Kala <ankikala@amazon.com> Co-authored-by: Ketan Verma <ketanv3@users.noreply.github.com> Co-authored-by: Daniel Widdis <widdis@gmail.com> Co-authored-by: Hauck <67768441+hauck-jvsh@users.noreply.github.com> Co-authored-by: Ashish <ashking94@gmail.com> Co-authored-by: Anshu Agarwal <anshuagarwal11@gmail.com> Co-authored-by: Navneet Verma <navneev@amazon.com> Co-authored-by: Rishab Nahata <rnnahata@amazon.com> Co-authored-by: msfroh <msfroh@gmail.com> Co-authored-by: Heemin Kim <heemin@amazon.com>
Bukhtawar
pushed a commit
that referenced
this pull request
Oct 8, 2022
* [BUG] Running "opensearch-service.bat start" and "opensearch-service.bat manager" (#4289)
* [BUG] Update opensearch-service-x64.exe parameters to //ES for Execute Service. Update opensearch-service-mgr.exe parameters to //ES for Edit Service. Add code comments for the Apache Commons Daemon.
Signed-off-by: Alex Burck <me@alexburck.com>
* update changelog with pull request link
Signed-off-by: Alex Burck <me@alexburck.com>
Signed-off-by: Alex Burck <me@alexburck.com>
* Removing dead code in RecoveryTarget. (#4278)
* Removing dead code in RecoveryTarget.
This code in RecoveryTarget is not invoked, all of these methods are implemented by the parent ReplicationTarget with the same behavior.
Signed-off-by: Marc Handalian <handalm@amazon.com>
* PR Comments.
Signed-off-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: Marc Handalian <handalm@amazon.com>
* Update the head ref to changelog verifier (#4296)
* Update changelog contribution guide
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
* Fix reference to pull request
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
* Add 2.x version to CHANGELOG (#4297)
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
* Do not fail replica shard due to primary closure (#4133)
This commit prevents a replica shard from being failed in the case that
a replication action to a replica is canceled due to the primary shard
being closed.
Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
* Some dependency updates (#4308)
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Restore using the class ClusterInfoRequest and ClusterInfoRequestBuilder from package 'org.opensearch.action.support.master.info' for subclasses (#4307)
* Restore using the class ClusterInfoRequest and ClusterInfoRequestBuilder from package 'org.opensearch.action.support.master.info' for subclasses
Signed-off-by: Tianli Feng <ftianli@amazon.com>
* Add changelog
Signed-off-by: Tianli Feng <ftianli@amazon.com>
Signed-off-by: Tianli Feng <ftianli@amazon.com>
Co-authored-by: Andrew Ross <andrross@amazon.com>
* [BUG] Create logs directory before running OpenSearch on Windows (#4305)
* [BUG] Create logs directory before running OpenSearch on Windows
Signed-off-by: Alex Burck <me@alexburck.com>
* update changlog pr link
Signed-off-by: Alex Burck <me@alexburck.com>
Signed-off-by: Alex Burck <me@alexburck.com>
* Use RemoteSegmentStoreDirectory instead of RemoteDirectory (#4240)
* Use RemoteSegmentStoreDirectory instead of RemoteDirectory
Signed-off-by: Sachin Kale <kalsac@amazon.com>
* ZIP publication groupId value is configurable (#4156)
When publishing Zip POM the groupId value was hard-coded to `org.opensearch.plugin` value which worked fine for existing core plugins but is not convenient for other plugins (such as community plugins maintained in independent repositories).
This PR changes the sources of the ZIP publishing groupId value.
Specifically, there are two ways to set the value:
1) It is automatically inherited from the Gradle "project.group"
2) It can be manually specified in the ZIP publication POM object
This PR also brings a major rework of tests in PublishTests class. Individual testing scenarios are driven by "real" gradle building scripts (utilizing `java-gradle-plugin` gradle plugin).
Closes #3692
Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
* [Segment Replication] Add timeout on Mockito.verify to reduce flakyness in testReplicationOnDone test (#4314)
* [Segment Replication] testReplicationOnDone Add timeout to allow time for verify call
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Update changelog
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Add change log entry
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Adding @dreamer-89 to Opensearch maintainers. (#4342)
Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Signed-off-by: Kartik Ganesh <gkart@amazon.com>
* [CVE] Update snakeyaml dependency (#4341)
The package `org.yaml:snakeyaml` before version 1.31 are vulnerable to Denial of Service (DoS) due missing to nested depth limitation for collections.
Details at https://nvd.nist.gov/vuln/detail/CVE-2022-25857
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
* Fixed commit workflow for dependabot PR helper (#4331)
* Fixed label for dependabot PR helper
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
* Update autocommit workflow for dependabot changelog
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
* Add version config for dependabot changelog helper
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
* Add release notes for patch release 1.3.5 (#4343)
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
* Add release notes for patch release 2.2.1 (#4344)
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
* Add label configuration for dependabot PRs (#4348)
* Support for HTTP/2 (server-side) (#3847)
* Support for HTTP/2 (server-side)
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Addressing code review comments
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Added HTTP/1.1 channel configuration
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Addressing code review comments
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Update pul request URL in CHANGELOG.md
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Fix token usage for changelog helper (#4351)
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
* Revert "Fix token usage for changelog helper (#4351)" (#4361)
This reverts commit c28221e0176ad3ce782c18a2b23ea2e59ed0e0a8.
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
* Segment Replication - Implement segment replication event cancellation. (#4225)
* Segment Replication. Fix Cancellation of replication events.
This PR updates segment replication paths to correctly cancel replication events on the primary and replica.
In the source service, any ongoing event for a primary that is sending to a replica that shuts down or is promoted as a new primary are cancelled.
In the target service, any ongoing event for a replica that is promoted as a new primary or is fetching from a primary that shuts down.
It wires up SegmentReplicationSourceService as an IndexEventListener so that it can respond to events and cancel any ongoing transfer state.
This change also includes some test cleanup for segment replication to rely on actual components over mocks.
Signed-off-by: Marc Handalian <handalm@amazon.com>
Fix to not start/stop SegmentReplicationSourceService as a lifecycle component with feature flag off.
Signed-off-by: Marc Handalian <handalm@amazon.com>
Update logic to properly mark SegmentReplicationTarget as cancelled when cancel initiated by primary.
Signed-off-by: Marc Handalian <handalm@amazon.com>
Minor updates from self review.
Signed-off-by: Marc Handalian <handalm@amazon.com>
* Add missing changelog entry.
Signed-off-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: Marc Handalian <handalm@amazon.com>
* Bug fixes for dependabot changelog verifier (#4364)
* Fix token usage for changelog helper
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
* Add conditional check for dependabot steps
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
* Add dependency section
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
* Bug fixes for dependabot changelog verifier
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
* Update the changelog
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
* Add changes for Create PIT and Delete PIT rest layer and rest high level client (#4064)
* Create and delete PIT search rest layer changes
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
* Bump com.diffplug.spotless from 6.9.1 to 6.10.0 (#4319)
* Update to Netty 4.1.80.Final (#4359)
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Bump xmlbeans from 5.1.0 to 5.1.1 in /plugins/ingest-attachment (#4354)
* Bump xmlbeans from 5.1.0 to 5.1.1 in /plugins/ingest-attachment
Bumps xmlbeans from 5.1.0 to 5.1.1.
---
updated-dependencies:
- dependency-name: org.apache.xmlbeans:xmlbeans
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Updating SHAs
Signed-off-by: dependabot[bot] <support@github.com>
* Update changelog
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
* Fix randomized test failure NRTReplicationEngineTests.testUpdateSegments (#4352)
Overload `generateHistoryOnReplica` to be able to generate only a specific `Engine.Operation.TYPE` operations as required by the `testUpdateSegments` test
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
* [AUTO] [main] Added bwc version 2.2.2. (#4383)
* Added bwc version 2.2.2
* Add changelog
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-ci-bot@users.noreply.github.com>
Co-authored-by: Kunal Kotwani <kkotwani@amazon.com>
* [Segment Replication] Bump segment infos counter before commit during replica promotion (#4365)
* [Segment Replication] Bump segment infos counter before commit during replica promotion
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Add changelog entry
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* [Segment Replication] Add check to cancel ongoing replication with old primary on onNewCheckpoint on replica (#4363)
* [Segment Replication] Add check to cancel ongoing replication with old primary on onNewCheckpoint on replica
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Add changelog entry
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Address review comments
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Address review comments 2
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Test failures
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Adding support for labels on version bump PRs, skip label support for… (#4391)
* Adding support for labels on version bump PRs, skip label support for changelog verifier
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
* Add changelog
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
* [Segment Replication] Extend FileChunkWriter to allow cancel on transport client (#4386)
* [Segment Replication] Extend FileChunkWriter to allow cancel on retryable transport client
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Add changelog entry
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Address review comments
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Integration test
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Added RestLayer Changes for PIT stats (#4217)
Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
* Modified cat shards test for pit stats (#4408)
Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
* [Remote Store] Add index specific setting for remote repository (#4253)
* Add index specific setting for remote repository
* Fix for failover incremental uploads
Signed-off-by: Sachin Kale <kalsac@amazon.com>
* [Semgnet Replication] Update flaky testOnNewCheckpointFromNewPrimaryCancelOngoingReplication unit test (#4414)
* [Semgnet Replication] Update flaky testOnNewCheckpointFromNewPrimaryCancelOngoingReplication unit test
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Add changelog entry
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Update changelog entry
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Segment Replication - Fix NoSuchFileException errors caused when computing metadata snapshot on primary shards. (#4366)
* Segment Replication - Fix NoSuchFileException errors caused when computing metadata snapshot on primary shards.
This change fixes the errors that occur when computing metadata snapshots on primary shards from the latest in-memory SegmentInfos. The error occurs when a segments_N file that is referenced by the in-memory infos is deleted as part of a concurrent commit. The segments themselves are incref'd by IndexWriter.incRefDeleter but the commit file (Segments_N) is not. This change resolves this by ignoring the segments_N file when computing metadata for CopyState and only sending incref'd segment files to replicas.
Signed-off-by: Marc Handalian <handalm@amazon.com>
* Fix spotless.
Signed-off-by: Marc Handalian <handalm@amazon.com>
* Update StoreTests.testCleanupAndPreserveLatestCommitPoint to assert additional segments are deleted.
Signed-off-by: Marc Handalian <handalm@amazon.com>
* Rename snapshot to metadataMap in CheckpointInfoResponse.
Signed-off-by: Marc Handalian <handalm@amazon.com>
* Refactor segmentReplicationDiff method to compute off two maps instead of MetadataSnapshots.
Signed-off-by: Marc Handalian <handalm@amazon.com>
* Fix spotless.
Signed-off-by: Marc Handalian <handalm@amazon.com>
* Revert catchall in SegmentReplicationSourceService.
Signed-off-by: Marc Handalian <handalm@amazon.com>
* Revert log lvl change.
Signed-off-by: Marc Handalian <handalm@amazon.com>
* Fix SegmentReplicationTargetTests
Signed-off-by: Marc Handalian <handalm@amazon.com>
* Cleanup unused logger.
Signed-off-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: Marc Handalian <handalm@amazon.com>
Co-authored-by: Suraj Singh <surajrider@gmail.com>
* Bump org.gradle.test-retry from 1.4.0 to 1.4.1 (#4411)
* Bump org.gradle.test-retry from 1.4.0 to 1.4.1
Bumps org.gradle.test-retry from 1.4.0 to 1.4.1.
---
updated-dependencies:
- dependency-name: org.gradle.test-retry
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update changelog
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
* Revert to Netty 4.1.79.Final (#4428)
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
* [Segment Replication] Fix timeout issue by calculating time needed to process getSegmentFiles. (#4426)
* Fix timeout issue by calculating time needed to process getSegmentFiles.
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
* Formatting sizeOfSegmentFiles for time calculation.
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
* Addressing comments and applying spotless check.
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
* [Bug]: gradle check failing with java heap OutOfMemoryError (#4328)
* [Bug]: gradle check failing with java heap OutOfMemoryError
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Fork JavaCompile task
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Bump azure-core-http-netty from 1.12.0 to 1.12.4 in /plugins/repository-azure (#4160)
* Bump azure-core-http-netty in /plugins/repository-azure
Bumps [azure-core-http-netty](https://github.com/Azure/azure-sdk-for-java) from 1.12.0 to 1.12.4.
- [Release notes](https://github.com/Azure/azure-sdk-for-java/releases)
- [Commits](https://github.com/Azure/azure-sdk-for-java/compare/azure-core_1.12.0...azure-core-http-netty_1.12.4)
---
updated-dependencies:
- dependency-name: com.azure:azure-core-http-netty
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Updating SHAs
Signed-off-by: dependabot[bot] <support@github.com>
* Added missing forbidden classes
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
* update version of azure-storage-common and azure-core-http-netty
Signed-off-by: Xue Zhou <xuezhou@amazon.com>
* update version of azure-storage-common and azure-core-http-netty
Signed-off-by: Xue Zhou <xuezhou@amazon.com>
* adding changelog information
Signed-off-by: Xue Zhou <xuezhou@amazon.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Xue Zhou <xuezhou@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Owais Kazi <owaiskazi19@gmail.com>
Co-authored-by: Xue Zhou <xuezhou@amazon.com>
* Bugfix: Allow opensearch.bat file and opensearch-env.bat files to run when install path includes a space. (#4362)
* Bugfix: Prevent escaping of in `else-if` statement by setting variable without double quotes.
Signed-off-by: Mike Wilkinson <mwilkinson@imohealth.com>
* Add changelog entry for fix
Signed-off-by: Mike Wilkinson <mwilkinson@imohealth.com>
* Escape double quotes for environment variables set by `opensearch-env.bat`. Explicitly apply quotes where those environment variables are invoked.
Signed-off-by: Mike Wilkinson <mwilkinson@imohealth.com>
Signed-off-by: Mike Wilkinson <mwilkinson@imohealth.com>
Co-authored-by: Mike Wilkinson <mwilkinson@imohealth.com>
* [Segment Replication] - Update replicas to commit SegmentInfos instead of relying on segments_N from primary shards. (#4402)
* Segment Replication - Update replicas to commit SegmentInfos instead of relying on segments_N from primary shards.
This change updates replicas to commit SegmentInfos before the shard is closed, on receiving a new commit point from a primary, and when a new primary is detected. This change also makes the public commitSegmentInfos on NRTEngine obsolete, refactoring IndexShard to simply call reset on the engine.
Signed-off-by: Marc Handalian <handalm@amazon.com>
* Remove noise & extra log statement.
Signed-off-by: Marc Handalian <handalm@amazon.com>
* PR feedback.
Signed-off-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: Marc Handalian <handalm@amazon.com>
* Bump reactor-netty-core from 1.0.19 to 1.0.22 in /plugins/repository-azure (#4447)
* Bump reactor-netty-core in /plugins/repository-azure
Bumps [reactor-netty-core](https://github.com/reactor/reactor-netty) from 1.0.19 to 1.0.22.
- [Release notes](https://github.com/reactor/reactor-netty/releases)
- [Commits](https://github.com/reactor/reactor-netty/compare/v1.0.19...v1.0.22)
---
updated-dependencies:
- dependency-name: io.projectreactor.netty:reactor-netty-core
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Updating SHAs
Signed-off-by: dependabot[bot] <support@github.com>
* Update changelog
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
* Add bwcVersion 2.4.0 (#4455)
* Add bwcVersion 2.4.0
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Add changelog entry
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* add support for s390x architecture (#4001)
* add s390x support in systemcallfilter
https://github.com/opensearch-project/OpenSearch/issues/4000
Signed-off-by: Andrija Pantovic <andrija.pantovic@phoenix-systems.ch>
* add gradle cfg for s390x
Signed-off-by: Andrija Pantovic <andrija.pantovic@gmail.com>
* change assertion for architecture
Signed-off-by: Andrija Pantovic <andrija.pantovic@gmail.com>
* change assertion for architecture
Signed-off-by: Andrija Pantovic <andrija.pantovic@gmail.com>
* update changelog
Signed-off-by: Andrija Pantovic <andrija.pantovic@gmail.com>
Signed-off-by: Andrija Pantovic <andrija.pantovic@phoenix-systems.ch>
Signed-off-by: Andrija Pantovic <andrija.pantovic@gmail.com>
* 2.3.0 release notes (#4457) (#4464)
* 2.3.0 release notes
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Add changelog entry
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Add getHistoryOperationsFromTranslog method to fetch the history snapshot from translogs (#3948)
* Add getHistoryOperationsFromTranslog method to fetch the hostory snapshot from translogs
Signed-off-by: Ankit Kala <ankikala@amazon.com>
* Fixed flaky test: ResourceAwareTasksTests.testTaskIdPersistsInThreadContext (#4484)
Signed-off-by: Ketan Verma <ketan9495@gmail.com>
* Getting security exception due to access denied 'java.lang.RuntimePermission' 'accessDeclaredMembers' when trying to get snapshot with S3 IRSA (#4469)
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: Suraj Singh <surajrider@gmail.com>
* [Javadoc] add missing javadocs for :distribution:tools modules (#4483)
* Add javadocs for distribution:tools:java-version-checker
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* Add javadocs for distribution:tools:keystore-cli
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* Add javadocs for distribution:tools:plugin-cli
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* Add javadocs for distribution:tools:launchers
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* Change log
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* Bump reactive-streams from 1.0.3 to 1.0.4 in /plugins/repository-azure (#4488)
* Bump reactive-streams from 1.0.3 to 1.0.4 in /plugins/repository-azure
Bumps [reactive-streams](https://github.com/reactive-streams/reactive-streams) from 1.0.3 to 1.0.4.
- [Release notes](https://github.com/reactive-streams/reactive-streams/releases)
- [Changelog](https://github.com/reactive-streams/reactive-streams-jvm/blob/master/RELEASE-NOTES.md)
- [Commits](https://github.com/reactive-streams/reactive-streams/compare/v1.0.3...v1.0.4)
---
updated-dependencies:
- dependency-name: org.reactivestreams:reactive-streams
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Updating SHAs
Signed-off-by: dependabot[bot] <support@github.com>
* Update changelog
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
* Ignore all malformed objects when ignore_malformed is true (#4494)
Fixes a bug to not fail the entire document when "ignore_malformed" is set to true. Allowing the valid fields
to be indexed and ignore only the malformed fields.
Signed-off-by: Hauck <joaoh14@gmail.com>
* [AUTO] [main] Added bwc version 2.3.1. (#4513)
* Added bwc version 2.3.1
* Add changelog of adding bwc version 2.3.1
Signed-off-by: Tianli Feng <ftianli@amazon.com>
* [Segment Replication] Add snapshot and restore tests for segment replication feature (#3993)
* [Segment Replication] Add snapshots tests with segment replication enabled
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Fix spotless failures
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Add changelog entry, address review comments, add failover test
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Fix spotless failures
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* Address review comments 2
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
* [Remote Store] Change behaviour in replica recovery for remote translog enabled indices (#4318)
Signed-off-by: Ashish Singh <ssashish@amazon.com>
* Weighted round-robin scheduling policy for shard coordination traffic… (#4241)
* Weighted round-robin scheduling policy for shard coordination traffic routing
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
* [Javadoc] add missing javadocs for :example-plugin modules (#4540)
* Add javadocs for example-plugins:custom-settings module
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* Add javadocs for example-plugins:custom-significance-heuristic
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* Add javadocs for example-plugins:custom-suggester
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* Add javadocs to example-plugins:painless-allowlist
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* Add javadocs to example-plugins:rescore
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* Add javadocs to example-plugins:rest-handler
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* Add javadocs to example-plugins:script-expert-scoring
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* Remove exclusions for module which aren't giving javadoc errors
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* CI testing apparently needs to instantiate a no-op class
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* Add GeoBounds aggregation on GeoShape field type.(#3980) (#4266)
Enables geo_bounds aggregation to work with geo_shape field types.
This enhancement includes:
* Addition of Doc values on the GeoShape Field.
* Addition of GeoShape ValueSource level code interfaces for accessing the DocValues.
* Addition of Missing Value feature in the GeoShape Aggregations.
Signed-off-by: Navneet Verma <navneev@amazon.com>
* Updates jackson and snakeyml dependencies (#4556)
* Upgrade jackson and snakeyml dependencies
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
* Updated changelog
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
* Bump com.diffplug.spotless from 6.10.0 to 6.11.0 (#4547)
* Bump com.diffplug.spotless from 6.10.0 to 6.11.0
---
updated-dependencies:
- dependency-name: com.diffplug.spotless
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* Bump reactor-core from 3.4.18 to 3.4.23 in /plugins/repository-azure (#4548)
* Bump reactor-core from 3.4.18 to 3.4.23 in /plugins/repository-azure
Bumps [reactor-core](https://github.com/reactor/reactor-core) from 3.4.18 to 3.4.23.
- [Release notes](https://github.com/reactor/reactor-core/releases)
- [Commits](https://github.com/reactor/reactor-core/compare/v3.4.18...v3.4.23)
---
updated-dependencies:
- dependency-name: io.projectreactor:reactor-core
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Bump jempbox from 1.8.16 to 1.8.17 in /plugins/ingest-attachment (#4550)
* Bump jempbox from 1.8.16 to 1.8.17 in /plugins/ingest-attachment
Bumps jempbox from 1.8.16 to 1.8.17.
---
updated-dependencies:
- dependency-name: org.apache.pdfbox:jempbox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Bump log4j-core from 2.18.0 to 2.19.0 in /buildSrc/src/testKit/thirdPartyAudit (#4549)
* Bump log4j-core in /buildSrc/src/testKit/thirdPartyAudit
Bumps log4j-core from 2.18.0 to 2.19.0.
---
updated-dependencies:
- dependency-name: org.apache.logging.log4j:log4j-core
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update changelog
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
* Ignore lock file when testing cleanupAndPreserveLatestCommitPoint (#4544)
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* Remove deprecated code to add node name into log pattern of log4j property file (#4568)
Signed-off-by: Tianli Feng <ftianli@amazon.com>
* Unmute RelocationIT.testRelocationWhileIndexingRandom. (#4580)
Signed-off-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: Marc Handalian <handalm@amazon.com>
* Add DecommissionService and helper to execute awareness attribute decommissioning (#4084)
* Add Executor to decommission node attribute
* Decommission service implementation with cluster metadata
* Master abdication changes to decommission local awareness leader
* Update join validator changes to validate decommissioned node join request
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
* Added rest layer changes for List all PITs and PIT segments (#4388)
* Changes for list all and pit segments
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
* Add PUT api to update shard routing weights (#4272)
* Add PUT api to update shard routing weights
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
* Further simplification of the ZIP publication implementation (#4360)
A follow-up of PR #4156 that brings in further simplification of the ZIP publication implementation and new tests.
It is possible to remove some of the initialization code because the work is already handled by other library under the hood (most likely by NebulaPublishPlugin).
For instance the condition to test the `groupId` presence: `if (groupId == null)` was pointless. It was never `true`. If the `project.group` is not defined the publication task fails with an exception, if there is a custom `groupId` value setup in publication config then it overrides the `project.group` as well. Tests are provided to cover these use cases.
As for the new tests they cover the following cases:
- verify that the task "publishToMavenLocal" gets expected results. The inspiration for this comes from https://github.com/opensearch-project/opensearch-plugin-template-java/pull/35
- verify that applying only the 'opensearch.pluginzip' is enough, because both the NebulaPublish and MavenPublishPlugin plugins are added explicitly and tasks are chained correctly
- verify that if the plugin is applied but no publication is defined then a message is printed for the user
Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
* Add missing Javadoc tag descriptions in unit tests (#4629)
* Add missing Javadoc tag descriptions in unit tests
Using JDK14 (downloaded from https://jdk.java.net/archive/), I tried
running ./gradlew check, and received errors like:
server/src/test/java/org/opensearch/indices/replication/SegmentReplicationTargetTests.java:440:
warning: no description for @throws
The build then failed with "warnings found and -Werror specified".
I tried again with JDK17 and the build passed.
According to DEVELOPER_GUIDE.md, we should be able to build with JDK14,
I added the missing Javadoc tag descriptions.
Signed-off-by: Michael Froh <froh@amazon.com>
* Update CHANGELOG.md
Signed-off-by: Michael Froh <froh@amazon.com>
Signed-off-by: Michael Froh <froh@amazon.com>
* Bump reactor-netty-http from 1.0.18 to 1.0.23 in /plugins/repository-azure (#4594)
* Bump reactor-netty-http in /plugins/repository-azure
Bumps [reactor-netty-http](https://github.com/reactor/reactor-netty) from 1.0.18 to 1.0.23.
- [Release notes](https://github.com/reactor/reactor-netty/releases)
- [Commits](https://github.com/reactor/reactor-netty/compare/v1.0.18...v1.0.23)
---
updated-dependencies:
- dependency-name: io.projectreactor.netty:reactor-netty-http
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Updating SHAs
Signed-off-by: dependabot[bot] <support@github.com>
* Update changelog
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
* Bump jettison from 1.5.0 to 1.5.1 in /plugins/discovery-azure-classic (#4592)
* Bump jettison from 1.5.0 to 1.5.1 in /plugins/discovery-azure-classic
Bumps [jettison](https://github.com/jettison-json/jettison) from 1.5.0 to 1.5.1.
- [Release notes](https://github.com/jettison-json/jettison/releases)
- [Commits](https://github.com/jettison-json/jettison/compare/jettison-1.5.0...jettison-1.5.1)
---
updated-dependencies:
- dependency-name: org.codehaus.jettison:jettison
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Updating SHAs
Signed-off-by: dependabot[bot] <support@github.com>
* Update changelog
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
* Fix invalid search location of JDK for arm64 (#4613)
Related commit: 0e9f74e35f1255cb9ec45be3d8960aad195a9f6e
Signed-off-by: Heemin Kim <heemin@amazon.com>
Signed-off-by: Heemin Kim <heemin@amazon.com>
* Remove unused object and import from TransportClusterAllocationExplainAction (#4639)
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
* Relax visibility of the HTTP_CHANNEL_KEY and HTTP_SERVER_CHANNEL_KEY to make it possible for the plugins to access associated Netty4HttpChannel / Netty4HttpServerChannel instance (#4638)
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Bumping hadoop-hdfs version to 3.3.4 (#4644)
* Updating hadoop-hdfs version
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
* Adding changelog
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
* Bugfix/496 rollover alias with filters (#4499)
* 496: Added filters, indexRouting and searchRouting when doing rollover on alias
Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
* 496: Removed unused map property in metada alias rollover tests
Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Co-authored-by: Stevan Buzejic <stevan.buzejic@htecgroup.com>
* Load the deprecated master role in a dedicated method instead of in setAdditionalRoles() (#4582)
Signed-off-by: Tianli Feng <ftianli@amazon.com>
* Add APIs (GET/PUT) to decommission awareness attribute (#4261)
* Add APIs (GET/PUT) to decommission awareness attribute
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
* Adding check to make sure checkpoint is not processed when a shard's shard routing is primary. (#4630)
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Co-authored-by: Suraj Singh <surajrider@gmail.com>
* Bump azure-storage-common from 12.18.0 to 12.18.1 in /plugins/repository-azure (#4664)
* Bump azure-storage-common in /plugins/repository-azure
Bumps [azure-storage-common](https://github.com/Azure/azure-sdk-for-java) from 12.18.0 to 12.18.1.
- [Release notes](https://github.com/Azure/azure-sdk-for-java/releases)
- [Commits](https://github.com/Azure/azure-sdk-for-java/compare/azure-storage-blob_12.18.0...azure-storage-common_12.18.1)
---
updated-dependencies:
- dependency-name: com.azure:azure-storage-common
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Updating SHAs
Signed-off-by: dependabot[bot] <support@github.com>
* Update changelog
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
* Bump forbiddenapis from 3.3 to 3.4 in /buildSrc/src/testKit/thirdPartyAudit (#4662)
* Bump forbiddenapis in /buildSrc/src/testKit/thirdPartyAudit
Bumps [forbiddenapis](https://github.com/policeman-tools/forbidden-apis) from 3.3 to 3.4.
- [Release notes](https://github.com/policeman-tools/forbidden-apis/releases)
- [Commits](https://github.com/policeman-tools/forbidden-apis/compare/3.3...3.4)
---
updated-dependencies:
- dependency-name: de.thetaphi:forbiddenapis
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update changelog
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
* Fixed the SnapshotsInProgress error during index deletion (#4570)
Signed-off-by: Xue Zhou <xuezhou@amazon.com>
* Update to Apache Lucene 9.4.0 (#4661)
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Fixed day of year defaulting for round up parser (#4627)
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
* Fix PIT flaky tests (#4632)
* Fixing PIT flaky tests
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
* Add getter for path field in NestedQueryBuilder (#4636)
* Pre-commit checks now check for missing javadoc, and the Gradle check Jenkins build now waits for pre-commit checks to pass before attempting (#4660)
* Ignore all malformed objects when ignore_malformed is true (#4494)
Fixes a bug to not fail the entire document when "ignore_malformed" is set to true. Allowing the valid fields
to be indexed and ignore only the malformed fields.
Signed-off-by: Hauck <joaoh14@gmail.com>
Signed-off-by: Braddy Yeoh <braddy.yeoh@ucdconnect.ie>
* Adding javadoc check to the precommi\t GitHub Action
Signed-off-by: Braddy Yeoh <braddy.yeoh@ucdconnect.ie>
* gradle check now only runs after successful gradle precommit check
Signed-off-by: Braddy Yeoh <braddy.yeoh@ucdconnect.ie>
* Added to CHANGELOG
Signed-off-by: Braddy Yeoh yeohbraddy@gmail.com
Signed-off-by: Braddy Yeoh <braddy.yeoh@ucdconnect.ie>
Signed-off-by: Hauck <joaoh14@gmail.com>
Signed-off-by: Braddy Yeoh <braddy.yeoh@ucdconnect.ie>
Signed-off-by: Braddy Yeoh yeohbraddy@gmail.com
Co-authored-by: Hauck <67768441+hauck-jvsh@users.noreply.github.com>
Co-authored-by: Braddy Yeoh <braddy.yeoh@ucdconnect.ie>
* Backport Apache Lucene version change for 2.4.0 (#4677)
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Attempt to fix Github workflow for Gradle Check job (#4679)
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Adding precommit support for Windows (#4676)
* First draft for Windows precommit
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
* Adding changelog
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
* Adding precommit support for MacOS (darwin) (#4682)
* First draft for Windows precommit
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
* Adding changelog
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
* Adding precommit for macos
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
* Adding Changelog
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
* Fix flaky DecommissionControllerTests.testTimesOut (#4683)
This test fails pretty reliably if I run it on repeat. I believe the
problem is that the test assumes the function will take longer than 2ms,
which is likely not a valid assumption in all cases. Fortunately, I can
pass in a zero duration which is guaranteed to timeout even if the
system clock does not advance at all.
Also moved the assertions out of the callback into the main test method,
otherwise the assertion error messages would get buried and the test
report would just show a timeout error.
Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
* Include Windows OS in Bootstrap initializeNatives() check for definitelyRunningAsRoot() (#4656)
* Bump jna from 5.11.0 to 5.12.1
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* Include Windows OS in check for definitelyRunningAsRoot()
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* Combine try/catch blocks
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* Someone sniped my PR number between predicting and pushing
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* Update SHAs
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
* Add release notes for 1.3.6 (#4681)
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
* Service Layer changes for Recommission API (#4320)
* Recommission API service level changes
Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>
* Add GET api to get shard routing weights (#4275)
* Weighted round-robin scheduling policy for shard coordination traffic routing
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
* Fix new race condition in DecommissionControllerTests (#4688)
My previous fix introduced a new race condition by making the assertions
before waiting on the latch.
Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
* Fixing SearchStats (de)serialization (#4697)
Fixes bwc failure caused by commit
6993ac9834d0f7e8e77e6cade09de2245d2a20f7.
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Fixed misunderstanding message 'No OpenSearchException found' when detailed_error disabled (#4669)
* Fixed misunderstanding message 'No OpenSearchException found' when detailed_error disabled
Signed-off-by: Xue Zhou <xuezhou@amazon.com>
* Update GeoGrid base class access modifier to support extensibility (#4572)
* Update access modifier to support extensibility
Change access modifier from default to protected.
This will help to build new geo based aggregation
outside OpenSearch, by keeping GeoGrid Classes as base class.
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
* Updated CHANGELOG
Added PR details to CHANGELOG.md
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
* Rename InternalGeoGridBucket to BaseGeoGridBucket
Update class names, references and comments.
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
* Rename InternalGeoGrid to BaseGeoGrid
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
* Make GridBucket classes package-private
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
* Remove Internal prefix from Geo Grid classes
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
* Update constructor and class access modifier
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
* Update access modifier based on usage
Made classes package private if it is not used
outside the package.
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
* [Remove] LegacyESVersion.V_7_0_* and V_7_1_* constants (#2768)
* [Remove] LegacyESVersion.V_7_0_* and V_7_1_* constants
Removes all usages of LegacyESVersion.V_7_0_ and LegacyESVersion.V_7_1 version
constants.
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
* Rebase from main
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
* fix serialization issue with build flavor removal
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
* remove stale bwc test
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
* rebase and update
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
* cleanup
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
* fix failing mapper test
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
* Fixing Gradle warnings associated with publishPluginZipPublicationToXxx tasks (#4696)
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Bump gson from 2.9.0 to 2.9.1 in /test/fixtures/hdfs-fixture (#4066)
* Bump gson from 2.9.0 to 2.9.1 in /test/fixtures/hdfs-fixture
Bumps [gson](https://github.com/google/gson) from 2.9.0 to 2.9.1.
- [Release notes](https://github.com/google/gson/releases)
- [Changelog](https://github.com/google/gson/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/gson/compare/gson-parent-2.9.0...gson-parent-2.9.1)
---
updated-dependencies:
- dependency-name: com.google.code.gson:gson
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update changelog
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
* Always auto release the flood stage block (#4703)
* Always auto release the flood stage block
Removes support for using a system property to disable the automatic release of
the write block applied when a node exceeds the flood-stage watermark.
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
* update IAE message
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
* Controlling discovery for decommissioned nodes (#4590)
* Controlling discovery for decommissioned nodes
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
* [Remove] LegacyESVersion.V_7_2_* and V_7_3_* constants (#4702)
Removes all usages of LegacyESVersion.V_7_2_ and LegacyESVersion.V_7_3 version
constants along with related ancient APIs.
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
* [Remove] LegacyESVersion.V_7_4_* and V_7_5_* constants (#4704)
Removes all usages of LegacyESVersion.V_7_4_ and LegacyESVersion.V_7_5
version constants along with ancient API logic.
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Alex Burck <me@alexburck.com>
Signed-off-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Tianli Feng <ftianli@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Xue Zhou <xuezhou@amazon.com>
Signed-off-by: Mike Wilkinson <mwilkinson@imohealth.com>
Signed-off-by: Andrija Pantovic <andrija.pantovic@phoenix-systems.ch>
Signed-off-by: Andrija Pantovic <andrija.pantovic@gmail.com>
Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Ketan Verma <ketan9495@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Hauck <joaoh14@gmail.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Navneet Verma <navneev@amazon.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: Michael Froh <froh@amazon.com>
Signed-off-by: Heemin Kim <heemin@amazon.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Signed-off-by: Vishal Sarda <vsarda@amazon.com>
Signed-off-by: Braddy Yeoh <braddy.yeoh@ucdconnect.ie>
Signed-off-by: Braddy Yeoh yeohbraddy@gmail.com
Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
Co-authored-by: Alex Burck <me@alexburck.com>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Co-authored-by: Kunal Kotwani <kkotwani@amazon.com>
Co-authored-by: Andrew Ross <andrross@amazon.com>
Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: Tianli Feng <ftianli@amazon.com>
Co-authored-by: Sachin Kale <sachinpkale@gmail.com>
Co-authored-by: Lukáš Vlček <lukas.vlcek@aiven.io>
Co-authored-by: Suraj Singh <surajrider@gmail.com>
Co-authored-by: Kartik Ganesh <gkart@amazon.com>
Co-authored-by: Rabi Panda <adnapibar@gmail.com>
Co-authored-by: Bharathwaj G <58062316+bharath-techie@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: opensearch-ci-bot <opensearch-ci-bot@users.noreply.github.com>
Co-authored-by: Movva Ajaykumar <majaykumar51@gmail.com>
Co-authored-by: Craig Perkins <cwperx@amazon.com>
Co-authored-by: Rishikesh Pasham <62345295+Rishikesh1159@users.noreply.github.com>
Co-authored-by: Owais Kazi <owaiskazi19@gmail.com>
Co-authored-by: Xue Zhou <xuezhou@amazon.com>
Co-authored-by: mwilkinson-imo <47403752+mwilkinson-imo@users.noreply.github.com>
Co-authored-by: Mike Wilkinson <mwilkinson@imohealth.com>
Co-authored-by: Andrija Pantovic <andrija.pantovic@gmail.com>
Co-authored-by: Ankit Kala <ankikala@amazon.com>
Co-authored-by: Ketan Verma <ketanv3@users.noreply.github.com>
Co-authored-by: Daniel Widdis <widdis@gmail.com>
Co-authored-by: Hauck <67768441+hauck-jvsh@users.noreply.github.com>
Co-authored-by: Ashish <ashking94@gmail.com>
Co-authored-by: Anshu Agarwal <anshuagarwal11@gmail.com>
Co-authored-by: Navneet Verma <navneev@amazon.com>
Co-authored-by: Rishab Nahata <rnnahata@amazon.com>
Co-authored-by: msfroh <msfroh@gmail.com>
Co-authored-by: Heemin Kim <heemin@amazon.com>
Co-authored-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Co-authored-by: Stevan Buzejic <30922513+stevanbz@users.noreply.github.com>
Co-authored-by: Stevan Buzejic <stevan.buzejic@htecgroup.com>
Co-authored-by: Xue Zhou <85715413+xuezhou25@users.noreply.github.com>
Co-authored-by: Vishal Sarda <Vishalks@users.noreply.github.com>
Co-authored-by: Pavlo Smahin <Pavlo_Smahin@epam.com>
Co-authored-by: Braddy Yeoh <yeohbraddy@gmail.com>
Co-authored-by: Braddy Yeoh <braddy.yeoh@ucdconnect.ie>
Co-authored-by: pranikum <109206473+pranikum@users.noreply.github.com>
Co-authored-by: Vijayan Balasubramanian <vijayan.balasubramanian@gmail.com>
Co-authored-by: Nick Knize <nknize@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sachin Kale kalsac@amazon.com
Description
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.