Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add APIs (GET/PUT) to decommission awareness attribute #4261
Add APIs (GET/PUT) to decommission awareness attribute #4261
Changes from all commits
e3dcf4a
1dfc3cd
f5f676a
4c8b65b
8c2ddbc
c7e4bcc
e2b38cb
1c9fe9f
17f2548
f9bfff9
6ba62c2
6f2f3d3
81748c1
f4ec908
0c08d98
a1289a2
93ae7c2
c9b0b48
00270f0
7152932
9a9f5af
1c845db
40ffde7
da2ea43
a206a08
1873519
c0d5de7
fbe0e7d
ef33115
908fe08
fc6dd88
14f4ce0
4aa3790
534a3de
80449a8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decommissioning is only supported on awareness attributes, what about decommissioning by nodeId, nodeName etc.?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, we are supporting decommissioning an awareness attribute. Incrementally, we can have this feature for decommissioning a node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we just keep the API generic and pass awareness as query param instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we make
awareness
query param then putting attribute type and attribute value real confusing.As part of discussion here in the RFC - #3639 we discussed to have this as
/_cluster/decommission/awareness/{awareness_attribute_name}/{awareness_attribute_value}
which is also in consistence with weights APIThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could do two GET APIs
/_cluster/decommission/awareness/{awareness_attribute_name}/_status
/_cluster/decommission/awareness/_status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened issue to add another route - #4640