Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Support shard promotion with Segment Replication. (#4135) #4325

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Aug 29, 2022

This is a backport of #4135. Conflicts here were around translogManager & remote store updates that are in main but not yet backported. This backport removes those changes from the original commit.

  • Support shard promotion with Segment Replication.

This change adds basic failover support with segment replication. Once selected, a replica will commit and reopen a writeable engine.

Signed-off-by: Marc Handalian handalm@amazon.com

  • Add check to ensure a closed shard does not publish checkpoints.

Signed-off-by: Marc Handalian handalm@amazon.com

  • Clean up in SegmentReplicationIT.

Signed-off-by: Marc Handalian handalm@amazon.com

  • PR feedback.

Signed-off-by: Marc Handalian handalm@amazon.com

  • Fix merge conflict.

Signed-off-by: Marc Handalian handalm@amazon.com

Signed-off-by: Marc Handalian handalm@amazon.com

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

…nsearch-project#4135)

* Support shard promotion with Segment Replication.

This change adds basic failover support with segment replication.  Once selected, a replica will commit and reopen a writeable engine.

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Add check to ensure a closed shard does not publish checkpoints.

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Clean up in SegmentReplicationIT.

Signed-off-by: Marc Handalian <handalm@amazon.com>

* PR feedback.

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Fix merge conflict.

Signed-off-by: Marc Handalian <handalm@amazon.com>

Signed-off-by: Marc Handalian <handalm@amazon.com>
@mch2 mch2 marked this pull request as ready for review August 29, 2022 18:27
@mch2 mch2 requested review from a team and reta as code owners August 29, 2022 18:27
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@mch2 mch2 merged commit d4dd71c into opensearch-project:2.x Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants