[Backport 2.x] Revert to Netty 4.1.79.Final

[cwperks]

Signed-off-by: Craig Perkins cwperx@amazon.com

Description

See related issue: #4427

The last minor version of Netty included a change to eagerly load certificates using BouncyCastle if BouncyCastle is on the classpath: netty/netty#12670

This change has led to errors on startup with the security plugin (See #4427) because of a bug in checking all required BouncyCastle dependencies (See netty/netty#12743)

There is another bug related to the change that impacts custom bundles for private keys (netty/netty#12746). Both bugs have since been fixed and are targeted for the next 4.1.X release of netty.

This PR reverts netty until the next 4.1.X (4.1.81.Final) release. The full list of changes in netty 4.1.80.Final can be found here

Issues Resolved

#4427

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[cliu123]

@dreamer-89 Precommit failed due to > Task :modules:transport-netty4:dependencyLicenses FAILED. Does this need to be resolved before merging? Would you please help with this? Thanks!

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/2771/
• CommitID: 2008d55

[cwperks]

@cliu123 That file was added in this PR (#3847) which is in main and not in 2.x. I believe the license file can be removed safely. I did not remove it initially when creating the manual backport.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/2773/
• CommitID: e652f42

[dreamer-89]

Flaky test failure. Tracked in #4162 . Refiring!

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testRestoreSnapshotAllocationDoesNotExceedWatermark" -Dtests.seed=11BDC26C6A36BD41 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=tr -Dtests.timezone=Etc/GMT-6 -Druntime.java=17

org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT > testRestoreSnapshotAllocationDoesNotExceedWatermark FAILED
    java.lang.AssertionError: 
    Expected: an empty collection
         but: <[[hwlddrmihf][2], node[JkVtuaGDRaCplowzx7P-Ag], [P], s[STARTED], a[id=B5wyH7XqQ6GdEMupdA3sXg], [hwlddrmihf][0], node[JkVtuaGDRaCplowzx7P-Ag], [P], s[STARTED], a[id=Tg9IHB4BQJOF_TU1QK4_Xg]]>
        at __randomizedtesting.SeedInfo.seed([11BDC26C6A36BD41:305640D018FA2F9]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.junit.Assert.assertThat(Assert.java:930)
        at org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.lambda$testRestoreSnapshotAllocationDoesNotExceedWatermark$2(DiskThresholdDeciderIT.java:260)
        at org.opensearch.test.OpenSearchTestCase.assertBusy(OpenSearchTestCase.java:1049)
        at org.opensearch.test.OpenSearchTestCase.assertBusy(OpenSearchTestCase.java:1022)
        at org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testRestoreSnapshotAllocationDoesNotExceedWatermark(DiskThresholdDeciderIT.java:260)

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/2775/
• CommitID: e652f42