Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/extensions] Handles version conflicts for AD Extension #4539

Conversation

owaiskazi19
Copy link
Member

@owaiskazi19 owaiskazi19 commented Sep 16, 2022

Signed-off-by: Owais Kazi owaiskazi19@gmail.com

Description

jackson 2.13.3 brings a transitive dependency of snakeyml:1.30 which has a CVE and also conflict with other dependencies for AD exetension

Companion PR on AD: opensearch-project/anomaly-detection#672
SDK: opensearch-project/opensearch-sdk-java#145

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2022

Codecov Report

Merging #4539 (b7bb31c) into feature/extensions (8283ede) will increase coverage by 0.02%.
The diff coverage is 53.84%.

@@                   Coverage Diff                    @@
##             feature/extensions    #4539      +/-   ##
========================================================
+ Coverage                 70.60%   70.62%   +0.02%     
- Complexity                57409    57431      +22     
========================================================
  Files                      4641     4641              
  Lines                    276257   276271      +14     
  Branches                  40386    40389       +3     
========================================================
+ Hits                     195045   195115      +70     
+ Misses                    64905    64871      -34     
+ Partials                  16307    16285      -22     
Impacted Files Coverage Δ
...va/org/opensearch/common/settings/KeyStoreCli.java 0.00% <ø> (ø)
...rc/main/java/org/opensearch/plugins/PluginCli.java 0.00% <ø> (ø)
...main/java/org/opensearch/plugins/PluginHelper.java 100.00% <ø> (+9.09%) ⬆️
...rch/extensions/rest/RestSendToExtensionAction.java 27.77% <ø> (ø)
...in/java/org/opensearch/index/shard/IndexShard.java 68.98% <0.00%> (-0.29%) ⬇️
...search/index/translog/InternalTranslogManager.java 71.01% <0.00%> (-0.52%) ⬇️
...opensearch/index/translog/NoOpTranslogManager.java 66.66% <0.00%> (-2.30%) ⬇️
...earch/index/translog/WriteOnlyTranslogManager.java 66.66% <0.00%> (-13.34%) ⬇️
.../java/org/opensearch/index/mapper/FieldMapper.java 80.74% <30.00%> (-0.71%) ⬇️
...java/org/opensearch/repositories/s3/S3Service.java 81.48% <100.00%> (+0.58%) ⬆️
... and 490 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Sep 17, 2022

@owaiskazi19 I think we should bring 2.13.4 to main and 2.x branches, plus we have new snakeyaml release - 1.32, I was about to submit the pull request with these dependency update but please feel free to go ahead

@owaiskazi19
Copy link
Member Author

owaiskazi19 commented Sep 19, 2022

@owaiskazi19 I think we should bring 2.13.4 to main and 2.x branches, plus we have new snakeyaml release - 1.32, I was about to submit the pull request with these dependency update but please feel free to go ahead

Here you go @reta : #4556

@owaiskazi19
Copy link
Member Author

Changes are merged to main. We can rebase to get it on feature/extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants