Recommission api level support #4604

pranikum · 2022-09-27T07:08:21Z

Description

This PR is taken from #4321.
Some checks were failing in above PR. Required to fix the previous commits. Which was creating issue. Hence created a separate PR.

This change contain REST API layer changes for Recommission API support.
This pr is dependent of Service layer changes. (#4320)

This change has some changes for the PR #4084

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-27T07:25:17Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3457/
CommitID: c614b9a

github-actions · 2022-09-27T07:33:24Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3459/
CommitID: 55c4b42

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-27T08:38:04Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/3463/
CommitID: 74758e6

imRishN · 2022-09-27T08:45:02Z

LGTM. Please merge this only after service level changes for recommission is merged

saratvemulapalli

Looks like a lot of boiler plate code, which is absolutely ok but could you help understand:

how this will be hooked up?
Looks like the API/feature is experimental, do you plan on to gate it by a feature flag?

saratvemulapalli · 2022-09-27T23:38:16Z

rest-api-spec/src/main/resources/rest-api-spec/api/cluster.delete_decommission_awareness.json

+{
+  "cluster.delete_decommission_awareness": {
+    "documentation": {
+      "url": "https://opensearch.org/docs/latest/opensearch/rest-api/decommission/",


This link redirects to docs. Is the documentation work in progress? or Am I missing something?

...earch/action/admin/cluster/decommission/awareness/delete/DeleteDecommissionStateRequest.java

...st/java/org/opensearch/rest/action/admin/cluster/RestDeleteDecommissionStateActionTests.java

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-28T12:00:40Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3524/
CommitID: 07cd63a

...arch/action/admin/cluster/decommission/awareness/delete/DeleteDecommissionStateResponse.java

anshu1106 · 2022-09-29T06:05:42Z

...tion/admin/cluster/decommission/awareness/delete/TransportDeleteDecommissionStateAction.java

+        ActionListener<DeleteDecommissionStateResponse> listener
+    ) {
+        // TODO: Enable when service class change is merged
+        logger.info("Received delete decommission Request");


is it better to put this in debug log?

Keeping it as info only. Don't expect call to decommission/recommission be called frequently. It will be a nice checkpoint to track.

please make it more verbose with the request details. This PR is still WIP, please also rename the PR appropriately

Added request object in the log.

rest-api-spec/src/main/resources/rest-api-spec/api/cluster.delete_decommission_awareness.json

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-09-29T07:34:40Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/3562/
CommitID: 0aca81b

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-10-12T05:13:06Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/4466/
CommitID: 0d98d0c

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-10-12T06:54:15Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/4479/
CommitID: 28e5c69

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-10-12T07:50:32Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/4482/
CommitID: 69a281a

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-10-13T07:28:49Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/4557/
CommitID: 9bd1717

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-10-13T08:42:49Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/4565/
CommitID: 760aaaf

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-10-13T09:46:00Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/4567/
CommitID: 3d842ef

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

github-actions · 2022-10-13T10:28:06Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/4569/
CommitID: 6305812

* Add changes for Recommission API Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Add DecommissionService and helper to execute awareness attribute decommissioning #4084 * Add APIs (GET/PUT) to decommission awareness attribute #4261 * Controlling discovery for decommissioned nodes #4590 * Fix decommission status update to non leader nodes #4800 * Remove redundant field from GetDecommissionStateResponse #4751 * Service Layer changes for Recommission API #4320 * Recommission api level support #4604 * Fix bug in AwarenessAttributeDecommissionIT #4822 Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Add DecommissionService and helper to execute awareness attribute decommissioning opensearch-project#4084 * Add APIs (GET/PUT) to decommission awareness attribute opensearch-project#4261 * Controlling discovery for decommissioned nodes opensearch-project#4590 * Fix decommission status update to non leader nodes opensearch-project#4800 * Remove redundant field from GetDecommissionStateResponse opensearch-project#4751 * Service Layer changes for Recommission API opensearch-project#4320 * Recommission api level support opensearch-project#4604 * Fix bug in AwarenessAttributeDecommissionIT opensearch-project#4822 Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Awareness attribute decommission backports (#4970) * Add DecommissionService and helper to execute awareness attribute decommissioning #4084 * Add APIs (GET/PUT) to decommission awareness attribute #4261 * Controlling discovery for decommissioned nodes #4590 * Fix decommission status update to non leader nodes #4800 * Remove redundant field from GetDecommissionStateResponse #4751 * Service Layer changes for Recommission API #4320 * Recommission api level support #4604 * Fix bug in AwarenessAttributeDecommissionIT #4822 Signed-off-by: Rishab Nahata <rnnahata@amazon.com>

* Add changes for Recommission API Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

pranikum added 2 commits September 27, 2022 12:34

Add changes for Recommission API

8e1056a

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Update json file name

c614b9a

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

pranikum requested review from a team and reta as code owners September 27, 2022 07:08

Add line for the file

55c4b42

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Delete decommission awareness

74758e6

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

imRishN approved these changes Sep 27, 2022

View reviewed changes

pranikum mentioned this pull request Sep 27, 2022

REST API Layer changes for recommission support #4321

Closed

6 tasks

dblock requested review from andrross, Bukhtawar and mch2 September 27, 2022 19:23

saratvemulapalli reviewed Sep 27, 2022

View reviewed changes

pranikum added 5 commits September 28, 2022 16:54

Merge with latest

d76f281

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Resolve conflict

686a9a2

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Merge branch 'main' into recommission-api-level-support-2

c74a18c

Conflict resolution

ebb0d1a

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Spotless java check

07cd63a

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

anshu1106 reviewed Sep 29, 2022

View reviewed changes

...arch/action/admin/cluster/decommission/awareness/delete/DeleteDecommissionStateResponse.java Outdated Show resolved Hide resolved

anshu1106 reviewed Sep 29, 2022

View reviewed changes

rest-api-spec/src/main/resources/rest-api-spec/api/cluster.delete_decommission_awareness.json Show resolved Hide resolved

pranikum added 4 commits September 29, 2022 12:26

Remove toxcontet implements

746100a

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Merge with main changes

9d60fd6

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Merge branch 'main' into recommission-api-level-support-2

1011f35

Update change log

0aca81b

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

pranikum added 2 commits October 12, 2022 10:09

Merge branch 'main' into recommission-api-level-support-2

bfe13cb

Resolve changelog cnflict

0d98d0c

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

pranikum added 3 commits October 12, 2022 11:51

Merge with latest

d572494

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Merge branch 'main' into recommission-api-level-support-2

97df22d

Resolve conflict

28e5c69

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Fix comments

69a281a

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

pranikum added 3 commits October 13, 2022 12:30

Merge with latest

2981de5

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Merge branch 'main' into recommission-api-level-support-2

9557048

Resolve conflict

9bd1717

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Update comments

760aaaf

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Empty commit

3d842ef

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Empty commit

6305812

Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Bukhtawar merged commit 89550c0 into opensearch-project:main Oct 13, 2022

imRishN mentioned this pull request Oct 18, 2022

[Zone Decommission] API for deleting decommission #4369

Closed

imRishN mentioned this pull request Oct 28, 2022

Awareness attribute decommission backports #4970

Merged

6 tasks

imRishN mentioned this pull request Nov 3, 2022

Awareness attribute decommission 2.4 backport #5056

Closed

6 tasks

imRishN mentioned this pull request Nov 4, 2022

[DOC] Awareness Attribute Decommission opensearch-project/documentation-website#1812

Closed

4 tasks

ashking94 pushed a commit to ashking94/OpenSearch that referenced this pull request Nov 7, 2022

Recommission api level support (opensearch-project#4604)

a47abb2

* Add changes for Recommission API Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Recommission api level support #4604

Recommission api level support #4604

pranikum commented Sep 27, 2022 •

edited

Loading

github-actions bot commented Sep 27, 2022

github-actions bot commented Sep 27, 2022

github-actions bot commented Sep 27, 2022

imRishN commented Sep 27, 2022

saratvemulapalli left a comment

saratvemulapalli Sep 27, 2022

github-actions bot commented Sep 28, 2022

anshu1106 Sep 29, 2022

pranikum Sep 29, 2022

Bukhtawar Sep 29, 2022

pranikum Oct 6, 2022

github-actions bot commented Sep 29, 2022

github-actions bot commented Oct 12, 2022

github-actions bot commented Oct 12, 2022

github-actions bot commented Oct 12, 2022

github-actions bot commented Oct 13, 2022

github-actions bot commented Oct 13, 2022

github-actions bot commented Oct 13, 2022

github-actions bot commented Oct 13, 2022

Recommission api level support #4604

Recommission api level support #4604

Conversation

pranikum commented Sep 27, 2022 • edited Loading

Description

Issues Resolved

Check List

github-actions bot commented Sep 27, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Sep 27, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Sep 27, 2022

Gradle Check (Jenkins) Run Completed with:

imRishN commented Sep 27, 2022

saratvemulapalli left a comment

Choose a reason for hiding this comment

saratvemulapalli Sep 27, 2022

Choose a reason for hiding this comment

github-actions bot commented Sep 28, 2022

Gradle Check (Jenkins) Run Completed with:

anshu1106 Sep 29, 2022

Choose a reason for hiding this comment

pranikum Sep 29, 2022

Choose a reason for hiding this comment

Bukhtawar Sep 29, 2022

Choose a reason for hiding this comment

pranikum Oct 6, 2022

Choose a reason for hiding this comment

github-actions bot commented Sep 29, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 12, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 12, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 12, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 13, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 13, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 13, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 13, 2022

Gradle Check (Jenkins) Run Completed with:

pranikum commented Sep 27, 2022 •

edited

Loading