Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.x] Fixed the SnapshotsInProgress error during index deletion (#4570) #4670

Conversation

xuezhou25
Copy link
Contributor

Signed-off-by: Xue Zhou xuezhou@amazon.com

Description

Backport #4570 2.x

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@xuezhou25 xuezhou25 requested review from a team and reta as code owners October 4, 2022 04:41
Signed-off-by: Xue Zhou <xuezhou@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2022

Codecov Report

Merging #4670 (4e596cc) into 2.x (bd532e1) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                2.x    #4670      +/-   ##
============================================
- Coverage     70.70%   70.56%   -0.14%     
+ Complexity    57157    57104      -53     
============================================
  Files          4585     4585              
  Lines        274523   274526       +3     
  Branches      40232    40233       +1     
============================================
- Hits         194099   193731     -368     
- Misses        64180    64528     +348     
- Partials      16244    16267      +23     
Impacted Files Coverage Δ
...ava/org/opensearch/snapshots/SnapshotsService.java 39.60% <0.00%> (-0.13%) ⬇️
.../org/opensearch/index/MockEngineFactoryPlugin.java 0.00% <0.00%> (-100.00%) ⬇️
...n/indices/forcemerge/ForceMergeRequestBuilder.java 0.00% <0.00%> (-75.00%) ⬇️
...org/opensearch/test/engine/MockInternalEngine.java 0.00% <0.00%> (-65.22%) ⬇️
.../org/opensearch/test/engine/MockEngineSupport.java 0.00% <0.00%> (-63.56%) ⬇️
.../indices/forcemerge/TransportForceMergeAction.java 25.00% <0.00%> (-58.34%) ⬇️
...ch/transport/ReceiveTimeoutTransportException.java 50.00% <0.00%> (-50.00%) ⬇️
...cluster/coordination/PendingClusterStateStats.java 20.00% <0.00%> (-48.00%) ⬇️
...adcast/BroadcastShardOperationFailedException.java 55.55% <0.00%> (-44.45%) ⬇️
.../opensearch/client/indices/CloseIndexResponse.java 56.25% <0.00%> (-35.00%) ⬇️
... and 491 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

Gradle Check (Jenkins) Run Completed with:

@reta reta merged commit a90fd73 into opensearch-project:2.x Oct 4, 2022
@xuezhou25 xuezhou25 deleted the 2.x_fix_snapshotsInProgress_bug_during_index_deletion branch October 4, 2022 17:49
@tlfeng tlfeng added bug Something isn't working backport PRs or issues specific to backporting features or enhancments v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments bug Something isn't working v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants